From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#37440: [PATCH] New rx implementation with extension constructs Date: Tue, 24 Sep 2019 10:55:07 -0700 Organization: UCLA Computer Science Department Message-ID: <958a595d-41f1-f2ea-186c-672e783316ba@cs.ucla.edu> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------144428797921FE7A106F2DA7" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="182187"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 Cc: 37440@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 24 19:56:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCp2q-000lG3-Qn for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Sep 2019 19:56:12 +0200 Original-Received: from localhost ([::1]:49568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCp2p-0000OU-PJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Sep 2019 13:56:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46035) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCp2h-0000Nx-PU for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 13:56:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCp2g-0003RF-Io for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 13:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59529) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iCp2g-0003R8-D3 for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 13:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iCp2g-0006fu-9p for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 13:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Sep 2019 17:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37440-submit@debbugs.gnu.org id=B37440.156934771725589 (code B ref 37440); Tue, 24 Sep 2019 17:56:02 +0000 Original-Received: (at 37440) by debbugs.gnu.org; 24 Sep 2019 17:55:17 +0000 Original-Received: from localhost ([127.0.0.1]:40117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCp1x-0006ed-9Y for submit@debbugs.gnu.org; Tue, 24 Sep 2019 13:55:17 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCp1u-0006eK-Pq for 37440@debbugs.gnu.org; Tue, 24 Sep 2019 13:55:16 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7FB6816022F; Tue, 24 Sep 2019 10:55:08 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id rUbpHjJh06rR; Tue, 24 Sep 2019 10:55:07 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 500C8160235; Tue, 24 Sep 2019 10:55:07 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VbMKOItOpi2J; Tue, 24 Sep 2019 10:55:07 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 3434916022F; Tue, 24 Sep 2019 10:55:07 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167116 Archived-At: This is a multi-part message in MIME format. --------------144428797921FE7A106F2DA7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit I tried the proposed patches with current Emacs master on Fedora 30 x86-64 and got a test failure as shown in the attached file. Could you please look into that? Thanks. --------------144428797921FE7A106F2DA7 Content-Type: text/x-log; charset=UTF-8; name="rx-tests.log" Content-Disposition: attachment; filename="rx-tests.log" Content-Transfer-Encoding: quoted-printable Running 25 tests (2019-09-24 10:51:06-0700, selector `(not (or (tag :expe= nsive-test) (tag :unstable)))') passed 1/25 rx-any (0.000164 sec) passed 2/25 rx-atoms (0.000106 sec) passed 3/25 rx-category (0.000088 sec) passed 4/25 rx-char-any (0.000077 sec) passed 5/25 rx-char-any-range-nl (0.000078 sec) Test rx-char-any-raw-byte backtrace: signal(ert-test-failed (((should (equal (rx (any "\326A\333B")) (str ert-fail(((should (equal (rx (any "\326A\333B")) (string-to-multibyt #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name rx-char-any-raw-byte :documentation " ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...=20 ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/rx-tests" command-line() normal-top-level() Test rx-char-any-raw-byte condition: (ert-test-failed ((should (equal (rx ...) (string-to-multibyte "[AB\326\333]"))) :form (equal "[AB\326\333]" "[AB\326\333]") :value nil :explanation (array-elt 3 (different-atoms (214 "#xd6" "?=C3=96") (4194262 "#x3fffd6" "?\326"))))) FAILED 6/25 rx-char-any-raw-byte (0.000191 sec) passed 7/25 rx-constituents (0.000136 sec) passed 8/25 rx-define (0.000081 sec) passed 9/25 rx-eval (0.000076 sec) passed 10/25 rx-group (0.000075 sec) passed 11/25 rx-kleene (0.000084 sec) passed 12/25 rx-let (0.000109 sec) passed 13/25 rx-let-define (0.000081 sec) passed 14/25 rx-let-eval (0.000102 sec) passed 15/25 rx-literal (0.000083 sec) passed 16/25 rx-not (0.000084 sec) passed 17/25 rx-or (0.000084 sec) passed 18/25 rx-pcase (0.000108 sec) passed 19/25 rx-redefine-builtin (0.000129 sec) passed 20/25 rx-regexp (0.000087 sec) passed 21/25 rx-repeat (0.000090 sec) passed 22/25 rx-seq (0.000095 sec) passed 23/25 rx-syntax (0.000083 sec) passed 24/25 rx-to-string (0.000091 sec) Test rx-to-string-define backtrace: signal(error ("Unknown rx symbol `rx--d'")) apply(signal (error ("Unknown rx symbol `rx--d'"))) #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name rx-to-string-define :documentation "C ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/rx-tests" command-line() normal-top-level() Test rx-to-string-define condition: (error "Unknown rx symbol `rx--d'") FAILED 25/25 rx-to-string-define (0.000149 sec) Ran 25 tests, 23 results as expected, 2 unexpected (2019-09-24 10:51:06-0= 700, 0.264977 sec) 2 unexpected results: FAILED rx-char-any-raw-byte FAILED rx-to-string-define --------------144428797921FE7A106F2DA7--