Faces in bash-ts-mode

Faces in bash-ts-mode

[Eli Zaretskii]

Is there an easy way of having some of the sh-script's special faces
in bash-ts-mode?  The one I spotted to be missing is
sh-escaped-newline, but maybe sh-quoted-exec is also missing?

Also, do we use sh-heredoc face for here-documents in bash-ts-mode?
If not, can we use it in that case?

Thanks.

Re: Faces in bash-ts-mode

[Yuan Fu]

> On Mar 2, 2023, at 11:53 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> Is there an easy way of having some of the sh-script's special faces
> in bash-ts-mode?  The one I spotted to be missing is
> sh-escaped-newline, but maybe sh-quoted-exec is also missing?

I added support for sh-quoted-exec, but because tree-sitter ignores the escaped newline, it doesn’t show up in the parse tree, so it’s not as easy to support that.

I not an expert in bash syntax, can I assume that an backslash at the end of a line that’s not in a string must be an escaped newline?

> Also, do we use sh-heredoc face for here-documents in bash-ts-mode?
> If not, can we use it in that case?

We do, so that’s taken care of :-)

Yuan

Re: Faces in bash-ts-mode

[Eli Zaretskii]

> From: Yuan Fu <casouri@gmail.com>
> Date: Sun, 5 Mar 2023 14:23:06 -0800
> Cc: emacs-devel@gnu.org
> 
> I not an expert in bash syntax, can I assume that an backslash at the end of a line that’s not in a string must be an escaped newline?

I guess so.  (I'm not an expert, either.)

> > Also, do we use sh-heredoc face for here-documents in bash-ts-mode?
> > If not, can we use it in that case?
> 
> We do, so that’s taken care of :-)

Thanks!

Re: Faces in bash-ts-mode

[Yuri Khan]

On Mon, 6 Mar 2023 at 05:23, Yuan Fu <casouri@gmail.com> wrote:

> I not an expert in bash syntax, can I assume that an backslash at the end of a line that’s not in a string must be an escaped newline?

I don’t know the full context, but a backslash at the end of a line
could be a backslash-escaped backslash:

    echo \\
    # that was a command to output a single backslash

and the whole heuristic if you’re not doing a full parser would
probably be “a backslash at the end of a line that is preceded by an
even number (incl. 0) of backslashes is an escaped newline”.

    echo \\\
        this is a continuation line