From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware? Date: Thu, 28 Oct 2021 08:49:13 -0700 Message-ID: <94c1e53f-98cb-8891-77d9-81f3c401149e@gmail.com> References: <69264ece-bb7f-4db1-f461-dacd33db2402@gmail.com> <87cznqev5g.fsf@gmx.de> <2c3dffbc-9af0-f318-15bc-cce91a106898@gmail.com> <8735olwp95.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------3F7F9D323F4046BE3CE154BC" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7542"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51426@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 28 17:50:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mg7fb-0001oD-U8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Oct 2021 17:50:24 +0200 Original-Received: from localhost ([::1]:47804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mg7fa-00015l-3w for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Oct 2021 11:50:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mg7fH-000126-0K for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 11:50:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mg7fG-0002t5-Nw for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 11:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mg7fG-0004lW-Ie for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 11:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Oct 2021 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51426-submit@debbugs.gnu.org id=B51426.163543616518269 (code B ref 51426); Thu, 28 Oct 2021 15:50:02 +0000 Original-Received: (at 51426) by debbugs.gnu.org; 28 Oct 2021 15:49:25 +0000 Original-Received: from localhost ([127.0.0.1]:52955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mg7ee-0004ka-Vw for submit@debbugs.gnu.org; Thu, 28 Oct 2021 11:49:25 -0400 Original-Received: from mail-pf1-f177.google.com ([209.85.210.177]:40580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mg7eZ-0004kJ-4a for 51426@debbugs.gnu.org; Thu, 28 Oct 2021 11:49:22 -0400 Original-Received: by mail-pf1-f177.google.com with SMTP id x7so1365295pfh.7 for <51426@debbugs.gnu.org>; Thu, 28 Oct 2021 08:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=9EDXHkdiyvRgDBMynWyk1NTQQSs7G+BvlTZh6YrPWkw=; b=BBzk27IIIb2bfBNfWlyYd1jTPCt2OUzT7znfn5H5003lBF6EMth6uWMBEHHrbbsY7q QxJvQ6jEdfHlpdijXwW4xGGy8zVpnwEtvnXTwPAFgakiXUpoz/83ysQ2fKhx7BeprQpr /vfZ0BC3eAZgv3xegxsP8oU/1nvtrY7v2kTzVgE7fYoKEsl9kesJGBmCtuMKkDuapOKT FgELptf2cxI0PHC4GmX0ITqfJ0Of5ssNQVdp6oqbWxOnmD7g0dDdzGzJQ2b5f1NfMsm7 7D8L1y5l7bg/oY7U0NpIHeLYbKI0HcLojwA6CxbQwm8poT0igW78uSnPfBZzru4bThZL wBOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=9EDXHkdiyvRgDBMynWyk1NTQQSs7G+BvlTZh6YrPWkw=; b=5oEBnzUVgbT5SfA0+3f1QnRRNHAAXcILXIF4CF8+QDdw7+fGkBx/T9nIuYMAxQH5cd 9HgPzbGgp0Em8UJtru9KwMs/OSNss4PZHC8G3MY4mteM6lGQ0r1GayOzWYgzAq3klx2N GLq0z/iHX7tqcE1RzgdDMLxMGzqAXwrDufcl5hYDEX2ALNpkB2pVoBwbXyVGUm1oDPbC KtvLnp10Naq5GBOKbmAkvyapyPpu5MyCzxHwSWhmHo9iLuMFRGxT0ANUM4/YUXBrr8Rz 9lwCbFv6n2tLecMz6yVO1HUYFvxHe9WBd9/4sQvqylRqla/GzKs7caVSdxP2B/z1jsSe 4RPg== X-Gm-Message-State: AOAM532yZQhcx4G1pOR6+JTh+qYh8I3A/4JomblE/QK2BY/WjmJzaoou 4vmZT7l0fZe9LhCe+XelYlL2x9DvagQ= X-Google-Smtp-Source: ABdhPJx5N+4OnPq8DnEzQx207cYayf2C6o5rHopM5KBDDhxTyd6+WU9NVyWdAigHqZ9ROt2Us3vqgg== X-Received: by 2002:a62:8017:0:b0:47b:fc93:f252 with SMTP id j23-20020a628017000000b0047bfc93f252mr5104193pfd.39.1635436153147; Thu, 28 Oct 2021 08:49:13 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x16sm3826391pff.186.2021.10.28.08.49.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Oct 2021 08:49:12 -0700 (PDT) In-Reply-To: <8735olwp95.fsf@gmx.de> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218510 Archived-At: This is a multi-part message in MIME format. --------------3F7F9D323F4046BE3CE154BC Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 10/28/2021 1:02 AM, Michael Albinus wrote: >> +@code{comint-terminfo-terminal} to let you choose a terminal with more >> +advanced features, as defined in your system's terminfo database. >> +When @code{system-uses-terminfo} is non-nil, Emacs will use this >> +option as the value for @env{TERM}. > > "this option" sounds like Emacs uses system-uses-terminfo for TERM, at > least in my ears. Could you pls rephrase it a little bit? Looking at it again, I definitely agree. I've tried to reword it without making it too much more verbose. How's this? --------------3F7F9D323F4046BE3CE154BC Content-Type: text/plain; charset=UTF-8; name="0001-Support-setting-comint-terminal-connection-locally.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Support-setting-comint-terminal-connection-locally.patc"; filename*1="h" RnJvbSA3ZmUzZTJiNmMxMTg1MDgzMDBlMDhkYTA0ZjAzOWQyMTQwM2ZmOWQwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMjggT2N0IDIwMjEgMDg6NDU6MTUgLTA3MDAKU3ViamVjdDogW1BB VENIXSBTdXBwb3J0IHNldHRpbmcgY29taW50IHRlcm1pbmFsIGNvbm5lY3Rpb24tbG9jYWxs eQoKKiBsaXNwL2NvbWludC5lbCAoY29taW50LXRlcm0tZW52aXJvbm1lbnQpOiBNYWtlIGl0 IGNvbm5lY3Rpb24tYXdhcmUuCiogZG9jL2VtYWNzL21pc2MudGV4aSAoU2hlbGwgT3B0aW9u cyk6IERvY3VtZW50IHRoZSBhYm92ZSBjaGFuZ2UsIGFuZApleHBsYWluIGhvdyB0aGlzIGlu dGVyYWN0cyB3aXRoICdzeXN0ZW0tdXNlcy10ZXJtaW5mbycuCiogZXRjL05FV1M6IEFubm91 bmNlIHRoZSBhYm92ZSBjaGFuZ2UuCi0tLQogZG9jL2VtYWNzL21pc2MudGV4aSB8IDEyICsr KysrKysrKy0tLQogZXRjL05FV1MgICAgICAgICAgICB8ICA4ICsrKysrKysrCiBsaXNwL2Nv bWludC5lbCAgICAgIHwgMTMgKysrKysrKy0tLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCAyNCBp bnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9lbWFjcy9t aXNjLnRleGkgYi9kb2MvZW1hY3MvbWlzYy50ZXhpCmluZGV4IDUxMjNhNzE2ZGMuLjdlN2Y3 YzVlMjcgMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9taXNjLnRleGkKKysrIGIvZG9jL2VtYWNz L21pc2MudGV4aQpAQCAtMTQ5NywxNCArMTQ5NywyMCBAQCBTaGVsbCBPcHRpb25zCiB1bmRl cmx5aW5nIHNoZWxsLCBvZiBjb3Vyc2UuCiAKIEB2aW5kZXggY29taW50LXRlcm1pbmZvLXRl cm1pbmFsCitAdmluZGV4IHN5c3RlbS11c2VzLXRlcm1pbmZvCiBAdmluZGV4IFRFUk1Acnss IGVudmlyb25tZW50IHZhcmlhYmxlLCBpbiBzdWItc2hlbGx9CiBDb21pbnQgbW9kZSBzZXRz IHRoZSBAZW52e1RFUk19IGVudmlyb25tZW50IHZhcmlhYmxlIHRvIGEgc2FmZSBkZWZhdWx0 CiB2YWx1ZSwgYnV0IHRoaXMgdmFsdWUgZGlzYWJsZXMgc29tZSB1c2VmdWwgZmVhdHVyZXMu ICBGb3IgZXhhbXBsZSwKIGNvbG9yIGlzIGRpc2FibGVkIGluIGFwcGxpY2F0aW9ucyB0aGF0 IHVzZSBAZW52e1RFUk19IHRvIGRldGVybWluZSBpZgogY29sb3IgaXMgc3VwcG9ydGVkLiAg VGhlcmVmb3JlLCBFbWFjcyBwcm92aWRlcyBhbiBvcHRpb24KLUBjb2Rle2NvbWludC10ZXJt aW5mby10ZXJtaW5hbH0sIHdoaWNoIHlvdSBjYW4gc2V0IHRvIGEgdGVybWluYWwgdGhhdAot aXMgcHJlc2VudCBpbiB5b3VyIHN5c3RlbSdzIHRlcm1pbmZvIGRhdGFiYXNlLCBpbiBvcmRl ciB0byB0YWtlCi1hZHZhbnRhZ2Ugb2YgYWR2YW5jZWQgZmVhdHVyZXMgb2YgdGhhdCB0ZXJt aW5hbC4KK0Bjb2Rle2NvbWludC10ZXJtaW5mby10ZXJtaW5hbH0gdG8gbGV0IHlvdSBjaG9v c2UgYSB0ZXJtaW5hbCB3aXRoIG1vcmUKK2FkdmFuY2VkIGZlYXR1cmVzLCBhcyBkZWZpbmVk IGluIHlvdXIgc3lzdGVtJ3MgdGVybWluZm8gZGF0YWJhc2UuCitFbWFjcyB3aWxsIHVzZSB0 aGlzIG9wdGlvbiBhcyB0aGUgdmFsdWUgZm9yIEBlbnZ7VEVSTX0gc28gbG9uZyBhcworQGNv ZGV7c3lzdGVtLXVzZXMtdGVybWluZm99IGlzIG5vbi1uaWwuCisKK0JvdGggQGNvZGV7Y29t aW50LXRlcm1pbmZvLXRlcm1pbmFsfSBhbmQgQGNvZGV7c3lzdGVtLXVzZXMtdGVybWluZm99 CitjYW4gYmUgZGVjbGFyZWQgYXMgY29ubmVjdGlvbi1sb2NhbCB0byBhZGp1c3QgdGhlc2Ug b3B0aW9ucyB0byBtYXRjaAord2hhdCBhIHJlbW90ZSBzeXN0ZW0gZXhwZWN0cyAoQHB4cmVm e0Nvbm5lY3Rpb24gVmFyaWFibGVzfSkuCiAKIEBub2RlIFRlcm1pbmFsIGVtdWxhdG9yCiBA c3Vic2VjdGlvbiBFbWFjcyBUZXJtaW5hbCBFbXVsYXRvcgpkaWZmIC0tZ2l0IGEvZXRjL05F V1MgYi9ldGMvTkVXUwppbmRleCBjMWI4YWRjNTExLi4yYThhM2YwOGU3IDEwMDY0NAotLS0g YS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMTgzLDYgKzE4MywxNCBAQCBUbyBpbXBy b3ZlIHNlY3VyaXR5LCBpZiBhbiBzcWwgcHJvZHVjdCBoYXMgJzpwYXNzd29yZC1pbi1jb21p bnQnIHNldAogdG8gdCwgYSBwYXNzd29yZCBzdXBwbGllZCB2aWEgdGhlIG1pbmlidWZmZXIg d2lsbCBiZSBzZW50IGluLXByb2Nlc3MsCiBhcyBvcHBvc2VkIHRvIHZpYSB0aGUgY29tbWFu ZC1saW5lLgogCisqKiBDb21pbnQKKworKysrCisqKiogJ2NvbWludC10ZXJtLWVudmlyb25t ZW50JyBpcyBub3cgYXdhcmUgb2YgY29ubmVjdGlvbi1sb2NhbCB2YXJpYWJsZXMuCitUaGUg b3B0aW9uICdjb21pbnQtdGVybWluZm8tdGVybWluYWwnIGFuZCB2YXJpYWJsZQorJ3N5c3Rl bS11c2VzLXRlcm1pbmZvJyBjYW4gbm93IGJlIHNldCBhcyBjb25uZWN0aW9uLWxvY2FsIHZh cmlhYmxlcyB0bworY2hhbmdlIHRoZSB0ZXJtaW5hbCB1c2VkIG9uIGEgcmVtb3RlIGhvc3Qu CisKIAwKICogTmV3IE1vZGVzIGFuZCBQYWNrYWdlcyBpbiBFbWFjcyAyOS4xCiAKZGlmZiAt LWdpdCBhL2xpc3AvY29taW50LmVsIGIvbGlzcC9jb21pbnQuZWwKaW5kZXggZTkyNWIzYTRi Ni4uYzExNGJkZjc1OCAxMDA2NDQKLS0tIGEvbGlzcC9jb21pbnQuZWwKKysrIGIvbGlzcC9j b21pbnQuZWwKQEAgLTg4OSwxMiArODg5LDEzIEBAIGNvbWludC10ZXJtLWVudmlyb25tZW50 CiAgIDs7IGFuZCB0aGVyZSBpcyBubyB3YXkgZm9yIHVzIHRvIGRlZmluZSBpdCBoZXJlLgog ICA7OyBTb21lIHByb2dyYW1zIHRoYXQgdXNlIHRlcm1pbmZvIGdldCB2ZXJ5IGNvbmZ1c2Vk CiAgIDs7IGlmIFRFUk0gaXMgbm90IGEgdmFsaWQgdGVybWluYWwgdHlwZS4KLSAgKGlmIChh bmQgKGJvdW5kcCAnc3lzdGVtLXVzZXMtdGVybWluZm8pIHN5c3RlbS11c2VzLXRlcm1pbmZv KQotICAgICAgKGxpc3QgKGZvcm1hdCAiVEVSTT0lcyIgY29taW50LXRlcm1pbmZvLXRlcm1p bmFsKQotICAgICAgICAgICAgIlRFUk1DQVA9IgotICAgICAgICAgICAgKGZvcm1hdCAiQ09M VU1OUz0lZCIgKHdpbmRvdy13aWR0aCkpKQotICAgIChsaXN0ICJURVJNPWVtYWNzIgotICAg ICAgICAgIChmb3JtYXQgIlRFUk1DQVA9ZW1hY3M6Y28jJWQ6dGM9dW5rbm93bjoiICh3aW5k b3ctd2lkdGgpKSkpKQorICAod2l0aC1jb25uZWN0aW9uLWxvY2FsLXZhcmlhYmxlcworICAg KGlmIHN5c3RlbS11c2VzLXRlcm1pbmZvCisgICAgICAgKGxpc3QgKGZvcm1hdCAiVEVSTT0l cyIgY29taW50LXRlcm1pbmZvLXRlcm1pbmFsKQorICAgICAgICAgICAgICJURVJNQ0FQPSIK KyAgICAgICAgICAgICAoZm9ybWF0ICJDT0xVTU5TPSVkIiAod2luZG93LXdpZHRoKSkpCisg ICAgIChsaXN0ICJURVJNPWVtYWNzIgorICAgICAgICAgICAoZm9ybWF0ICJURVJNQ0FQPWVt YWNzOmNvIyVkOnRjPXVua25vd246IiAod2luZG93LXdpZHRoKSkpKSkpCiAKIChkZWZ1biBj b21pbnQtbm9uYmxhbmstcCAoc3RyKQogICAiUmV0dXJuIG5vbi1uaWwgaWYgU1RSIGNvbnRh aW5zIG5vbi13aGl0ZXNwYWNlIHN5bnRheC4iCi0tIAoyLjI1LjEKCg== --------------3F7F9D323F4046BE3CE154BC--