From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: missing lexical-binding cookie warning when loading .el files Date: Sat, 4 May 2024 12:31:38 +0200 Message-ID: <94A5D0EC-A261-4440-B080-5028EEC72950@gmail.com> References: <50E29988-D354-4D10-990F-31828DBE6411@gmail.com> <865xvuixnl.fsf@gnu.org> <5EC17E4B-5690-4393-B674-13F90AFD207D@gmail.com> <874jbeb5vu.fsf@yahoo.com> <87zft69pln.fsf@yahoo.com> <87v83u9olw.fsf@yahoo.com> <86seyyghgt.fsf@gnu.org> <87le4q9evf.fsf@yahoo.com> <86ikzugfao.fsf@gnu.org> <87h6fe9eaa.fsf@yahoo.com> <86edaigd6n.fsf@gnu.org> <86cyq2gcaw.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33593"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 04 12:32:04 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3CgV-0008Up-Pl for ged-emacs-devel@m.gmane-mx.org; Sat, 04 May 2024 12:32:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3CgH-0001SN-3r; Sat, 04 May 2024 06:31:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3CgB-0001Qm-1y for emacs-devel@gnu.org; Sat, 04 May 2024 06:31:43 -0400 Original-Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3Cg9-0003fV-CC; Sat, 04 May 2024 06:31:42 -0400 Original-Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2db17e8767cso5563361fa.3; Sat, 04 May 2024 03:31:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714818699; x=1715423499; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=VRCMjzBYZOP7m18NTlEfEUB01mOWEzL6u/sdvDyT0HM=; b=ELK/C1JI0d78LHR0gPK80zsNglVD09OOr/+U53qwKU40FUmyn4JJL0es0DrJ8fcf/0 h6CIgIHFPpZkU+PlRZplvWmt3x5fB2Fq6bkUIaBdYZ7a6Q4qCokkOjrXfZxVGTMP2mEc RG2l69UR7RwdZWok3jrGWJbrXslpAqEe26h23x1QqS0dN7Sfrto5F+70Dt/mVyde7Jor tY46CYBEPbYUewQNwoslKafKRimU/Xh9gQrnoCJT/vfEnbvJwBq7OP1soJDJwTjdWRxW rYaOgcYr9guigUUTkwYtnV7Ok5UkmutIbXxU9bc6D4/G8aMfkEIdLkl8ngxE4es/P0NV lRjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714818699; x=1715423499; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=VRCMjzBYZOP7m18NTlEfEUB01mOWEzL6u/sdvDyT0HM=; b=gaIuoPwdz1OMQNAJPNoA+HoClLS4S3sP8jiU/JL1NoGxAxPtXsUgE+bHMnPqZKmEen cOzOyvmEqd7OExWCiub/UFJRkZmY6iod27jqvA07oNNuUK1jgfOFa6LOctBffW/rNfBP w/7uRj/MYVZE29G+HqjQ6Y2+fumvuqtAPQ+Oym7L22yj3Kn4SUDGauZKSx3/utcN1AHW q21LeFiKnaNKbXioJ02Ae9chS9oELpvnN43++k86vzPr0o+YOnwyFOhUZX4PEDypPlJi sC0pxfgPOC+POAAb0+nU3c5FDu0Xf1rRoMTADOisxQZOvOrj9Zjx/c5AUx3/i9nkai3J Isbg== X-Forwarded-Encrypted: i=1; AJvYcCU5oOEqKa3aTpgzkeKPfCPCB7zkNhkKGC5X+g5t5GG4pPtFPqlI1QocxGcrQZbjesp5U2qgRqszHMtAAjJLW5KN7pzi X-Gm-Message-State: AOJu0YxF4Hc2AiRcHtvMlCiCpuwB/f9EkNo+r1zZp8CdyU1tNOiC/yk9 Kt9qB5j57rlsoPU1KNJtY+H4fImLtgL2qGtS9JbbddcXurP8zZqycVaLvA== X-Google-Smtp-Source: AGHT+IEswPvGcVyDWswtNlPpDkjkgrBCTVDAXOZ3gDyXvIj/+ivtOSORrDTmXvfdU20hdoHbXb3ezw== X-Received: by 2002:a05:6512:3590:b0:515:beef:837f with SMTP id m16-20020a056512359000b00515beef837fmr3131979lfr.29.1714818698873; Sat, 04 May 2024 03:31:38 -0700 (PDT) Original-Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id g30-20020a19e05e000000b0051ef0d8b614sm858770lfj.138.2024.05.04.03.31.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 May 2024 03:31:38 -0700 (PDT) In-Reply-To: <86cyq2gcaw.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::233; envelope-from=mattias.engdegard@gmail.com; helo=mail-lj1-x233.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318741 Archived-At: 4 maj 2024 kl. 11.24 skrev Eli Zaretskii : > I see Mattias already installed something, without waiting for the > discussion to come to conclusions. Sorry, other people had started interfering in the code. I will = implement the consensus, but it's much easier if nobody else carries out = pet changes before even basic adjustments can be made. > . it hard-codes ".emacs" as the file for which we don't warn, thus > leaving the warning in effect for early-init files > . the init file can be named init.el or _emacs (with or without > .el), and the change doesn't handle that Actually it hard-codes .emacs as a file for which we do warn, but I = didn't think of _emacs -- sorry. Anyway, my assumption was that we should warn about the user init = file(s) and you seem to disagree. Here is my reasoning: + Init files often contain substantial amounts of hand-written code for = which lexical-binding matters. + New Emacs-generated init files always include a lexical cookie. - Old Emacs-generated init files did not include a lexical cookie when = created. - Some init files don't contain much actual Lisp code. Not sure what the balance is. Which would you prefer, and why? I'm not = deeply invested in either choice. > . there are files like recentf-save-file (default: ".recentf") or > abbrev-file-name (default: "abbrev_defs") and others, which should > also be exempt of this Yes, any file not ending in .el are now exempt. > I wish people would discuss such changes before committing them. Sorry about that, and I will make sure it's something that we (you = specifically included!) are satisfied with, even if it means removing = the warning entirely.