all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Bozhidar Batsov <bozhidar@batsov.com>,
	Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: helpers.el   [was: ... lisp/emacs-lisp/helpers.el...]
Date: Fri, 29 Nov 2013 15:50:30 -0800 (PST)	[thread overview]
Message-ID: <946783d5-d410-4ee8-87c8-20a2e80258e5@default> (raw)
In-Reply-To: <CAM9Zgm2Q6D2Bb-K19WOQCPBHWok0OgUgN4Sxrop5hYBcRJkAwQ@mail.gmail.com>

FWIW -

`helpers.el' is an *un*helpful file name.

It is bad enough that we already have a file `helper.el' in
the same directory.  Even for that file the name is not so
useful, but at least that is about providing "help in electric
modes".  (Something like `elec-help.el' would have been better.)

Please consider coming up with something better than "helpers".

Especially since `helpers.el' is purportedly "Some non-essential
library extensions."  Library extensions?  What library is
extended?  If not a library, what is extended by this code?

Non-essential is right, however.  This file has 7 one-liner
defsubsts in it - nothing more.  Now maybe big things are
expected for this little file in the future, but even then I'd
suggest that, at least for now, these functions be put
somewhere else.

Where to put such things, if not in a dedicated trifles bag?
Put similar things together (and not just similar by being tiny).

And if the intention is to progressively pick up other such
functions from other files and toss them in `helpers.el', so
that it becomes a growing catch-all, then I'd recommend to
think twice about that project.

But if you really cannot do any better than create a grab bag,
then please at least give it a name that reflects that failure
and does not lead to more confusion.



  reply	other threads:[~2013-11-29 23:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1VmRIu-00084e-Mh@vcs.savannah.gnu.org>
2013-11-29 18:23 ` [Emacs-diffs] trunk r115287: * lisp/emacs-lisp/helpers.el (string-empty-p): New function Stefan Monnier
2013-11-29 21:29   ` Bozhidar Batsov
2013-11-29 23:50     ` Drew Adams [this message]
2013-11-30  7:41       ` helpers.el [was: ... lisp/emacs-lisp/helpers.el...] Bozhidar Batsov
2013-11-30  8:07       ` Jambunathan K
2013-12-04 15:55         ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=946783d5-d410-4ee8-87c8-20a2e80258e5@default \
    --to=drew.adams@oracle.com \
    --cc=bozhidar@batsov.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.