From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?Lindstr=C3=B6m?= Newsgroups: gmane.emacs.bugs Subject: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Date: Tue, 11 Jun 2024 20:16:03 +0200 Message-ID: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=5341e6259c634780b3b71dbea41e16ae Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29514"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.11.0-alpha0-515-g87b2bad5a-fm-20240604.001-g87b2bad5 To: 71499@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 12 06:45:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHFrb-0007Rl-1e for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jun 2024 06:45:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHFr9-00018V-43; Wed, 12 Jun 2024 00:45:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHFr5-000186-Vk for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2024 00:45:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sHFr5-0001pS-Ll for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2024 00:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sHFr4-0007fr-11 for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2024 00:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?Lindstr=C3=B6m?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2024 04:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71499 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.171816747229431 (code B ref -1); Wed, 12 Jun 2024 04:45:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Jun 2024 04:44:32 +0000 Original-Received: from localhost ([127.0.0.1]:37153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHFqZ-0007eb-BF for submit@debbugs.gnu.org; Wed, 12 Jun 2024 00:44:32 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:59872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH8A9-0005ne-Dy for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:32:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH62o-0006Wx-OK for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 14:16:30 -0400 Original-Received: from wfhigh2-smtp.messagingengine.com ([64.147.123.153]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH62m-0008Q4-DG for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 14:16:30 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfhigh.west.internal (Postfix) with ESMTP id CF3F41800080 for ; Tue, 11 Jun 2024 14:16:24 -0400 (EDT) Original-Received: from imap43 ([10.202.2.93]) by compute3.internal (MEProxy); Tue, 11 Jun 2024 14:16:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm3; t=1718129784; x=1718216184; bh=agdLJUks3zEZZOIiGyzSP9KHoBxb9i6K U6bhR0Hp/W8=; b=E6ELE9MS73RwmbQFT1TPAHGx9JqNce64ovLfnC04wDPCdVw8 YwGGkAMMDyNDFjvfM6Z0fQEt68ax5X/GVJhTUFPgyeXETzvdLGXqAdrG5TdGEwrc tf7zzEoVn0LJ/6L5W386sC6f3PNAq0EqXJ6veToZUAmI7Hotpio4RIbXOxw364Ns 3ckFJV6U6G4DFQaDv39RlEnL0YsmY59atH1XHa5NVRIRox4W1eIwG+Y3spF/1+RG UPE8La4AovCA/mBCUAFioMDeAWlANH/iub5UN3wPux7wCnAJKqijOIUYoui5F8jj 3cKo3mNStwdF2tNT8bo2WLL/cAJo6a4fk8xFOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1718129784; x=1718216184; bh=agdLJUks3zEZZOIiGyzSP9KHoBxb9i6KU6b hR0Hp/W8=; b=JAUhmclMZqXEs7jetwyRRXqLsDSK483ija6qDLe7ywIcg3RFBKD QxdBn58i6txE14vlqyLAheNDQLkOJsBRDExO7qtLTmwe2TYtdVGLWvZhU0H5YhI9 d8rTZRQqf7hygLlstqBq/7Zgf7fTFcBZBzyPya38/P9j5CqOH2iAFKJOF83/7XzG Tojn8bPhAKQQmuNPJ/ET0QYr8x2Ea929tlciYRq/6Q4ubfHs48I1zMjMjJUaCW3T Q0UFXFGWOmQmvdR1s/FlDeeE77INtE/qv4fGFHm6HvrDTir1KSeb/aZaLFbXgkhq WJrjBbpi6ZwAEgTzBHyQAShNo2FDPf2uLIw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeduvddguddvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkfffhvffutgesmhdtre erreerjeenucfhrhhomhepuehjnphrnhcunfhinhgushhtrhpnmhcuoegskhhhlhesvghl vghkthhruhgsrgguuhhrrdhsvgeqnecuggftrfgrthhtvghrnhepveevleeiveehleeltd fftdfgueeghfeljedtgfelteeihfeuieeileekuedvvedvnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsghkhhhlsegvlhgvkhhtrhhusggrug hurhdrshgv X-ME-Proxy: Feedback-ID: i05c146bc:Fastmail Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id DCEFA2D405A9; Tue, 11 Jun 2024 14:16:23 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Received-SPF: none client-ip=64.147.123.153; envelope-from=bkhl@elektrubadur.se; helo=wfhigh2-smtp.messagingengine.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 12 Jun 2024 00:44:30 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287132 Archived-At: --5341e6259c634780b3b71dbea41e16ae Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, attaching patch to make the whitespace-cleanup and whitespace-cleanup-re= gion functions add a final newline to a file if whitespace-style contain= s `missing-newline-at-eof I'm aware this somewhat replicates what setting `require-final-newline w= ould do, but I think since whitespace.el with this configuration highlig= hts this as an error, it should also clean it up when asked. Best wishes, Bj=C3=B6rn --5341e6259c634780b3b71dbea41e16ae Content-Disposition: attachment; filename*0="0001-Make-whitespace.el-cleanup-add-missing-final-newline.pat"; filename*1="ch" Content-Type: text/x-patch; name="=?UTF-8?Q?0001-Make-whitespace.el-cleanup-add-missing-final-newline.patc?= =?UTF-8?Q?h?=" Content-Transfer-Encoding: BASE64 RnJvbSA3M2UyMGIzNGMxNjY5YTlkNTJjYmM3MGY0YzAyY2MyNmZhMjNjZjViIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Qmo9QzM9QjZybj0yMExpbmRzdHI9 QzM9QjZtPz0gPGJraGxAZWxla3RydWJhZHVyLnNlPgpEYXRlOiBUdWUsIDExIEp1biAyMDI0 IDE5OjQ5OjU1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gTWFrZSB3aGl0ZXNwYWNlLmVsIGNs ZWFudXAgYWRkIG1pc3NpbmcgZmluYWwgbmV3bGluZQoKKiBsaXNwL3doaXRlc3BhY2UuZWwg KHdoaXRlc3BhY2UtY2xlYW51cC1yZWdpb24pOiBpZiBjbGVhbmluZyB1cCBhdCBlbmQKb2Yg ZmlsZSwgYWRkIG1pc3NpbmcgbmV3bGluZSBpZiBpbmRpY2F0ZWQgYnkgd2hpdGVzcGFjZS1z dHlsZS4KLS0tCiBsaXNwL3doaXRlc3BhY2UuZWwgfCAxMyArKysrKysrKysrKystCiAxIGZp bGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdp dCBhL2xpc3Avd2hpdGVzcGFjZS5lbCBiL2xpc3Avd2hpdGVzcGFjZS5lbAppbmRleCBiYzIz YTg3OTRlYi4uYTQxYTc1MjA5MTUgMTAwNjQ0Ci0tLSBhL2xpc3Avd2hpdGVzcGFjZS5lbAor KysgYi9saXNwL3doaXRlc3BhY2UuZWwKQEAgLTE0NjUsNiArMTQ2NSwxMSBAQCBkZWZ1biB3 aGl0ZXNwYWNlLWNsZWFudXAtcmVnaW9uCiAgICBJZiBgd2hpdGVzcGFjZS1zdHlsZScgaW5j bHVkZXMgdGhlIHZhbHVlCiAgICBgc3BhY2UtYWZ0ZXItdGFiOjpzcGFjZScsIHJlcGxhY2Ug VEFCcyBieSBTUEFDRXMuCiAKKzUuIG1pc3NpbmcgbmV3bGluZSBhdCBlbmQgb2YgZmlsZS4K KyAgIElmIGB3aGl0ZXNwYWNlLXN0eWxlJyBpbmNsdWRlcyB0aGUgdmFsdWUgYG1pc3Npbmct bmV3bGluZS1hdC1lb2YnLAorICAgYW5kIHRoZSBjbGVhbnVwIHJlZ2lvbiBpbmNsdWRlcyB0 aGUgZW5kIG9mIGZpbGUsIGFkZCBhIGZpbmFsIG5ld2xpbmUKKyAgIGlmIGl0IGlzIG5vdCB0 aGVyZSBhbHJlYWR5LgorCiBTZWUgYHdoaXRlc3BhY2Utc3R5bGUnLCBgaW5kZW50LXRhYnMt bW9kZScgYW5kIGB0YWItd2lkdGgnIGZvcgogZG9jdW1lbnRhdGlvbi4iCiAgIChpbnRlcmFj dGl2ZSAiQHIiKQpAQCAtMTU0NSw3ICsxNTUwLDEzIEBAIGRlZnVuIHdoaXRlc3BhY2UtY2xl YW51cC1yZWdpb24KICAgICAgICAgICgobWVtcSAnc3BhY2UtYmVmb3JlLXRhYjo6c3BhY2Ug d2hpdGVzcGFjZS1zdHlsZSkKICAgICAgICAgICAod2hpdGVzcGFjZS1yZXBsYWNlLWFjdGlv bgogICAgICAgICAgICAndW50YWJpZnkgcnN0YXJ0IHJlbmQKLSAgICAgICAgICAgd2hpdGVz cGFjZS1zcGFjZS1iZWZvcmUtdGFiLXJlZ2V4cCAyKSkpKQorICAgICAgICAgICB3aGl0ZXNw YWNlLXNwYWNlLWJlZm9yZS10YWItcmVnZXhwIDIpKSkKKyAgICAgICAgOzsgUFJPQkxFTSA1 OiBtaXNzaW5nIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKKyAgICAgICAgKHdoZW4gKGFuZCAo bWVtcSAnbWlzc2luZy1uZXdsaW5lLWF0LWVvZikKKyAgICAgICAgICAgICAgICAgICAoPSAo cG9pbnQtbWF4KSAod2l0aG91dC1yZXN0cmljdGlvbiAocG9pbnQtbWF4KSkpKQorICAgICAg ICAgIChnb3RvLWNoYXIgKHBvaW50LW1heCkpCisgICAgICAgICAgKHdoZW4gKHJlLXNlYXJj aC1iYWNrd2FyZCAiLlxcJyIgbmlsIHQpCisgICAgICAgICAgICAoaW5zZXJ0ICJcbiIpKSkK ICAgICAgIChzZXQtbWFya2VyIHJlbmQgbmlsKSkpKQkJOyBwb2ludCBtYXJrZXIgdG8gbm93 aGVyZQogCiAKLS0gCjIuNDUuMgoK --5341e6259c634780b3b71dbea41e16ae--