From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Gonzalez Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: arbitools Date: Mon, 22 Feb 2016 10:01:57 +0000 (UTC) Message-ID: <942986116.7989101.1456135317147.JavaMail.yahoo@mail.yahoo.com> References: <87lh6d99h4.fsf@bernoul.li> Reply-To: David Gonzalez NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_7989100_146724929.1456135317143" X-Trace: ger.gmane.org 1456135357 30913 80.91.229.3 (22 Feb 2016 10:02:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Feb 2016 10:02:37 +0000 (UTC) Cc: Emacs-devel To: Jonas Bernoulli Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 22 11:02:27 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aXnJu-0004VC-2h for ged-emacs-devel@m.gmane.org; Mon, 22 Feb 2016 11:02:22 +0100 Original-Received: from localhost ([::1]:48157 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXnJt-0004ZC-3o for ged-emacs-devel@m.gmane.org; Mon, 22 Feb 2016 05:02:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXnJa-0004Yv-A0 for emacs-devel@gnu.org; Mon, 22 Feb 2016 05:02:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXnJX-0000DR-3W for emacs-devel@gnu.org; Mon, 22 Feb 2016 05:02:02 -0500 Original-Received: from nm46-vm5.bullet.mail.bf1.yahoo.com ([216.109.115.108]:59909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXnJW-0000DF-UU for emacs-devel@gnu.org; Mon, 22 Feb 2016 05:01:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1456135317; bh=uYLuKJp/zpaHnhsZz8xokEWi/UXIhuUDe+kxhHJIV9c=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject; b=iuOC5DUDiNXrJZSvS5nmb23G67yw+1xtcHWnHG/j5tCnk8CkCy5P+liUpQKGdT0ZMpxJbcCPuDMtp9ZV/xAHEYBGNlq7ib2gWKcMPqLgwZZCISDkzGLAdQqsFI/X64iaQrGcMvk55rfwNiiRv8vRAyENNdcvfjSyFKbbqRuoIfUL9mYbHgSzmas7byz/FbOGCrJnZxfPeP0eCQdSP4Iv16tPv1ljwiUgIp7oIEtdjtWmxqrjEGRdy0nE/LVl90fKPvXmdZ/w/BUJciZCyi3PmyTGGptPNNMne1KyDDuLr89jID+pS3KzLavJcCitHZQ454fvCzx6erDTCUcdZFS+qw== Original-Received: from [66.196.81.171] by nm46.bullet.mail.bf1.yahoo.com with NNFMP; 22 Feb 2016 10:01:57 -0000 Original-Received: from [98.139.212.237] by tm17.bullet.mail.bf1.yahoo.com with NNFMP; 22 Feb 2016 10:01:57 -0000 Original-Received: from [127.0.0.1] by omp1046.mail.bf1.yahoo.com with NNFMP; 22 Feb 2016 10:01:57 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 903103.44999.bm@omp1046.mail.bf1.yahoo.com X-YMail-OSG: iBS07boVM1mmcM0T7eK6oL5iwY_8FVVMO3.4oCS8hK8trYU9dCFCq6nCzJqkMOk mppH7fEpfxtUQUZfgJw0UZSiu8xsAEzrWs69tRL62Dw.Qd5YKJKu0ZPvx6ntomP56xsmi6EjGo5u RDfyESOpWDlqDMCQpsk7bCMFJr8fS7SOqQaapbpOz3H69jb11neNWLSuXYAtsykEijshrCm5dcrL ApPH7Axqh5mOU_DVGbNswIQaPpb_ifexPLoJanKyYCipN9MEPh_OhAYeqaUpnPb1N_S2wmZyDN1D YQmZ6awXIGLi3EWX1IrGRAOjQlp0XftDfHiM.zBD4iX10xnMJEvdqNTGxM31cTDtsgBHBb7pZDGp Xc3afqDY2feZNJpq0_HFWCveBTyQ3rjJFKIQaxinEQZpkTDZMhK1uYWU.69zqppCwfUWrzocSvdO aXRoyB1ZwYAfMcfelwrjcq24hul83vN8ek8QJeGxpyaatBXFaem75nlVZVHrZPVCAj0xDBVa3wkG _3wpFA9tKwkGeYTwgHrl2OOSULzk2mevgxDO3fdMM72UL Original-Received: by 76.13.26.127; Mon, 22 Feb 2016 10:01:57 +0000 In-Reply-To: <87lh6d99h4.fsf@bernoul.li> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 216.109.115.108 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200448 Archived-At: ------=_Part_7989100_146724929.1456135317143 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Ok. Thanks.I'll do more research on indentation conventions. From: Jonas Bernoulli To: David Gonzalez =20 Cc: "emacs-devel@gnu.org" Sent: Sunday, February 21, 2016 7:58 PM Subject: Re: [ELPA] New package: arbitools =20 The library provides the wrong feature (`arbitools-mode').=C2=A0 It should instead provide the feature which matches the filename (but of course without the ".el" suffix): `arbitools'. Also there is a space missing in ";;;Commentary:". And you might want to consider not putting closing parens in the wrong place.=C2=A0 You should fix that at least for the definition of `arbitools-mode'. For data, like the value of `arbitools-highlights', which is likely to be extended in the future it is okay to put closing parens on a separte line.=C2=A0 But you should put both closing parents on the same line and indent that line correctly.=C2=A0 Actually you should reindent the complete value.=C2=A0 But first you need to correctly comment the commented lines, replacing ";(" with ";; (" (also in other definitions).=C2=A0 Then mark the `defvar' and use `M-x indent-region RET'. ------=_Part_7989100_146724929.1456135317143 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Ok. Thanks.
I'll do more research on indentation = conventions.

<= div id=3D"yui_3_16_0_1_1456133936494_7914" dir=3D"ltr">
From: Jonas Bernoulli <jonas@b= ernoul.li>
To: Davi= d Gonzalez <mr_rookes@yahoo.com>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
= Sent: Sunday, February 21,= 2016 7:58 PM
Subject:<= /b> Re: [ELPA] New package: arbitools

The library provide= s the wrong feature (`arbitools-mode').  It should
i= nstead provide the feature which matches the filename (but of course
without the ".el" suffix): `arbitools'.

Also there is a space missing in ";;;Commentary:".

And you might want to consider not putting clo= sing parens in the wrong
place.  You should fix that= at least for the definition of
`arbitools-mode'.

For data, like the value of `arbitools-highli= ghts', which is likely to
be extended in the future it is= okay to put closing parens on a separte
line.  But = you should put both closing parents on the same line and
= indent that line correctly.  Actually you should reindent the complete=
value.  But first you need to correctly comment the= commented lines,
replacing ";(" with ";; (" (also in oth= er definitions).  Then mark the
`defvar' and use `M-= x indent-region RET'.



------=_Part_7989100_146724929.1456135317143--