From: David Gonzalez <mr_rookes@yahoo.com>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: Emacs-devel <emacs-devel@gnu.org>
Subject: Re: [ELPA] New package: arbitools
Date: Mon, 22 Feb 2016 10:01:57 +0000 (UTC) [thread overview]
Message-ID: <942986116.7989101.1456135317147.JavaMail.yahoo@mail.yahoo.com> (raw)
In-Reply-To: <87lh6d99h4.fsf@bernoul.li>
[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]
Ok. Thanks.I'll do more research on indentation conventions.
From: Jonas Bernoulli <jonas@bernoul.li>
To: David Gonzalez <mr_rookes@yahoo.com>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Sent: Sunday, February 21, 2016 7:58 PM
Subject: Re: [ELPA] New package: arbitools
The library provides the wrong feature (`arbitools-mode'). It should
instead provide the feature which matches the filename (but of course
without the ".el" suffix): `arbitools'.
Also there is a space missing in ";;;Commentary:".
And you might want to consider not putting closing parens in the wrong
place. You should fix that at least for the definition of
`arbitools-mode'.
For data, like the value of `arbitools-highlights', which is likely to
be extended in the future it is okay to put closing parens on a separte
line. But you should put both closing parents on the same line and
indent that line correctly. Actually you should reindent the complete
value. But first you need to correctly comment the commented lines,
replacing ";(" with ";; (" (also in other definitions). Then mark the
`defvar' and use `M-x indent-region RET'.
[-- Attachment #2: Type: text/html, Size: 2903 bytes --]
next prev parent reply other threads:[~2016-02-22 10:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1806012502.7608447.1456049133392.JavaMail.yahoo.ref@mail.yahoo.com>
2016-02-21 10:05 ` [ELPA] New package: arbitools David Gonzalez
2016-02-21 18:58 ` Jonas Bernoulli
2016-02-22 10:01 ` David Gonzalez [this message]
2016-02-22 12:57 ` Artur Malabarba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=942986116.7989101.1456135317147.JavaMail.yahoo@mail.yahoo.com \
--to=mr_rookes@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=jonas@bernoul.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.