From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jes Bodi Klinke" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 1/1] compile.el bug in recognizing -o switches among output Date: Wed, 27 Oct 2010 14:37:09 -0700 (PDT) Message-ID: <93ede5c63f6ca7272e5b0feb43e929f4.squirrel@xspect.dk> References: <5e0d0f4adb8ef5510aeacb9bcbe9a1a7.squirrel@xspect.dk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1288224558 7744 80.91.229.12 (28 Oct 2010 00:09:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 28 Oct 2010 00:09:18 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 28 02:09:15 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PBG3J-0004s2-9B for ged-emacs-devel@m.gmane.org; Thu, 28 Oct 2010 02:09:15 +0200 Original-Received: from localhost ([127.0.0.1]:40693 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBG3B-0002RU-A2 for ged-emacs-devel@m.gmane.org; Wed, 27 Oct 2010 20:09:01 -0400 Original-Received: from [140.186.70.92] (port=57399 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBDgG-00049x-6d for emacs-devel@gnu.org; Wed, 27 Oct 2010 17:37:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PBDgF-0005r0-4L for emacs-devel@gnu.org; Wed, 27 Oct 2010 17:37:12 -0400 Original-Received: from xspect.dk ([77.66.17.204]:57809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PBDgE-0005qe-VD for emacs-devel@gnu.org; Wed, 27 Oct 2010 17:37:11 -0400 Original-Received: from xspect.dk (xspect.dk [127.0.0.1]) by xspect.dk (Postfix) with ESMTP id DE6F88ABEA; Wed, 27 Oct 2010 23:37:08 +0200 (CEST) Original-Received: from 216.239.45.4 (SquirrelMail authenticated user jesk) by xspect.dk with HTTP; Wed, 27 Oct 2010 14:37:09 -0700 (PDT) In-Reply-To: <5e0d0f4adb8ef5510aeacb9bcbe9a1a7.squirrel@xspect.dk> User-Agent: SquirrelMail/1.4.15 X-Priority: 3 (Normal) Importance: Normal X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Mailman-Approved-At: Wed, 27 Oct 2010 20:05:19 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132150 Archived-At: This is embarassing. Apparently I was overconfident in my ability to mak= e some final simplifications of the regex, without needing to retest it. I accidentally messed up the subexpression numbering in my previous patch (by adding an outer pair of parentheses). The correct regex is: " -\\(?:o[=3D ]?\\|-\\(?:outfile\\|output\\)[=3D ]\\)\\(\\S +\\)" Please use this patch instead of my previous one. I am very sorry for th= e inconvenience, I hope that I will be able to provide better contributions in the future. Regards Jes Bodi Klinke =3D=3D=3D modified file 'lisp/progmodes/compile.el' *** lisp/progmodes/compile.el 2010-09-24 03:06:33 +0000 --- lisp/progmodes/compile.el 2010-10-27 21:30:57 +0000 *** 543,549 **** ;; Command output lines. Recognize `make[n]:' lines too. ("^\\([[:alnum:]_/.+-]+\\)\\(\\[\\([0-9]+\\)\\]\\)?[ \t]*:" (1 font-lock-function-name-face) (3 compilation-line-face nil t)) ! (" --?o\\(?:utfile\\|utput\\)?[=3D ]?\\(\\S +\\)" . 1) ("^Compilation \\(finished\\).*" (0 '(face nil message nil help-echo nil mouse-face nil) t) (1 compilation-info-face)) --- 543,549 ---- ;; Command output lines. Recognize `make[n]:' lines too. ("^\\([[:alnum:]_/.+-]+\\)\\(\\[\\([0-9]+\\)\\]\\)?[ \t]*:" (1 font-lock-function-name-face) (3 compilation-line-face nil t)) ! (" -\\(?:o[=3D ]?\\|-\\(?:outfile\\|output\\)[=3D ]\\)\\(\\S +\\)"= . 1) ("^Compilation \\(finished\\).*" (0 '(face nil message nil help-echo nil mouse-face nil) t) (1 compilation-info-face))