From: "Jes Bodi Klinke" <jes@bodi-klinke.dk>
To: emacs-devel@gnu.org
Subject: Re: [PATCH 1/1] compile.el bug in recognizing -o switches among output
Date: Wed, 27 Oct 2010 14:37:09 -0700 (PDT) [thread overview]
Message-ID: <93ede5c63f6ca7272e5b0feb43e929f4.squirrel@xspect.dk> (raw)
In-Reply-To: <5e0d0f4adb8ef5510aeacb9bcbe9a1a7.squirrel@xspect.dk>
This is embarassing. Apparently I was overconfident in my ability to make
some final simplifications of the regex, without needing to retest it. I
accidentally messed up the subexpression numbering in my previous patch
(by adding an outer pair of parentheses). The correct regex is:
" -\\(?:o[= ]?\\|-\\(?:outfile\\|output\\)[= ]\\)\\(\\S +\\)"
Please use this patch instead of my previous one. I am very sorry for the
inconvenience, I hope that I will be able to provide better contributions
in the future.
Regards
Jes Bodi Klinke
=== modified file 'lisp/progmodes/compile.el'
*** lisp/progmodes/compile.el 2010-09-24 03:06:33 +0000
--- lisp/progmodes/compile.el 2010-10-27 21:30:57 +0000
*** 543,549 ****
;; Command output lines. Recognize `make[n]:' lines too.
("^\\([[:alnum:]_/.+-]+\\)\\(\\[\\([0-9]+\\)\\]\\)?[ \t]*:"
(1 font-lock-function-name-face) (3 compilation-line-face nil t))
! (" --?o\\(?:utfile\\|utput\\)?[= ]?\\(\\S +\\)" . 1)
("^Compilation \\(finished\\).*"
(0 '(face nil message nil help-echo nil mouse-face nil) t)
(1 compilation-info-face))
--- 543,549 ----
;; Command output lines. Recognize `make[n]:' lines too.
("^\\([[:alnum:]_/.+-]+\\)\\(\\[\\([0-9]+\\)\\]\\)?[ \t]*:"
(1 font-lock-function-name-face) (3 compilation-line-face nil t))
! (" -\\(?:o[= ]?\\|-\\(?:outfile\\|output\\)[= ]\\)\\(\\S +\\)" . 1)
("^Compilation \\(finished\\).*"
(0 '(face nil message nil help-echo nil mouse-face nil) t)
(1 compilation-info-face))
next prev parent reply other threads:[~2010-10-27 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 21:11 [PATCH 1/1] compile.el bug in recognizing -o switches among output Jes Bodi Klinke
2010-10-27 21:37 ` Jes Bodi Klinke [this message]
2010-10-28 1:13 ` [PATCH 1/1] compile.el bug in recognizing -o switches among Stefan Monnier
2010-10-28 19:43 ` Jes Bodi Klinke
2010-10-29 17:32 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93ede5c63f6ca7272e5b0feb43e929f4.squirrel@xspect.dk \
--to=jes@bodi-klinke.dk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.