From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>, Fritz Stelzer <brotzeitmacher@gmail.com>
Cc: 29206@debbugs.gnu.org
Subject: bug#29206: Make xref-show-xrefs-function a defcustom
Date: Sun, 19 Nov 2017 01:42:17 +0200 [thread overview]
Message-ID: <9392204e-7185-6ae7-137e-d0ccdfa773cc@yandex.ru> (raw)
In-Reply-To: <83wp2ngag7.fsf@gnu.org>
On 11/18/17 12:14 PM, Eli Zaretskii wrote:
>> -(defvar xref-show-xrefs-function 'xref--show-xref-buffer
>> - "Function to display a list of xrefs.")
>> +(defcustom xref-show-xrefs-function 'xref--show-xref-buffer
>> + "Function to display a list of xrefs."
>> + :type 'function)
>>
>> (defvar xref--read-identifier-history nil)
>
> Dmitry, any comments on this? (If accepted, the defcustom should have
> a :version tag.)
I don't really see the point, yet: we don't offer any alternative
functions, and if the user is going to write one, `setq' is just as easy
to do.
Further, applying this kind of minor change (and finding it important)
seems like it would indicate that xref is kind of "stable", which it is
not, so far.
next prev parent reply other threads:[~2017-11-18 23:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 9:43 bug#29206: Make xref-show-xrefs-function a defcustom Fritz Stelzer
2017-11-18 10:14 ` Eli Zaretskii
2017-11-18 23:42 ` Dmitry Gutov [this message]
2017-11-19 15:28 ` Eli Zaretskii
2017-11-20 22:18 ` Dmitry Gutov
2019-06-24 20:31 ` Lars Ingebrigtsen
2019-06-24 23:36 ` Dmitry Gutov
2019-06-25 11:09 ` Lars Ingebrigtsen
2019-06-25 13:32 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9392204e-7185-6ae7-137e-d0ccdfa773cc@yandex.ru \
--to=dgutov@yandex.ru \
--cc=29206@debbugs.gnu.org \
--cc=brotzeitmacher@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.