From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#25995: 26.0.50; Mismatch between documented and actual behaviour of icomplete Date: Mon, 19 Jun 2017 03:19:16 +0300 Message-ID: <93815f6a-22a9-f8b5-2583-5b8bd9906d48@yandex.ru> References: <87a88yveuj.fsf@debian> <87shmm823i.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1497831614 6062 195.159.176.226 (19 Jun 2017 00:20:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 19 Jun 2017 00:20:14 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 Cc: 25995@debbugs.gnu.org To: npostavs@users.sourceforge.net, Alexis Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 19 02:20:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMkQM-00017l-1g for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Jun 2017 02:20:10 +0200 Original-Received: from localhost ([::1]:39999 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMkQO-0004lM-30 for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Jun 2017 20:20:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMkQI-0004jz-NL for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2017 20:20:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMkQE-0000co-Ks for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2017 20:20:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52783) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMkQE-0000cd-Hd for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2017 20:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dMkQE-0005WD-5k for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2017 20:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jun 2017 00:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25995 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 25995-submit@debbugs.gnu.org id=B25995.149783156721162 (code B ref 25995); Mon, 19 Jun 2017 00:20:02 +0000 Original-Received: (at 25995) by debbugs.gnu.org; 19 Jun 2017 00:19:27 +0000 Original-Received: from localhost ([127.0.0.1]:55460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMkPf-0005VG-2P for submit@debbugs.gnu.org; Sun, 18 Jun 2017 20:19:27 -0400 Original-Received: from mail-wm0-f42.google.com ([74.125.82.42]:34606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMkPd-0005V2-FX for 25995@debbugs.gnu.org; Sun, 18 Jun 2017 20:19:25 -0400 Original-Received: by mail-wm0-f42.google.com with SMTP id d64so14924870wmf.1 for <25995@debbugs.gnu.org>; Sun, 18 Jun 2017 17:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=49qaqMdrBcj2mU84jKAP+Y0tov3oD0nk/O30siIAc9w=; b=NvJvmVkgOWeusEIiU2yjd3Rx0jhLtN/7N7zwKqCw0EgriFUkiAz7YNBJvGmiqjyclu frJxaEGtTogUVW2/PSn2CuJ5dnL8QZ6+Z/IrlTgFFrS6xZkQLJpRNq0k2iVW4FnYlKGI GkxW2vKppZYlse5WVgsgkatQuodqYfwjfTXcZzVUPjjMhyUSCfeBx/5i+4D1N3QGgrRD xTSvEB9ocKzXzKMthifQf/9+mhQl579uHlSoAWk9VQ+9/hcLu3LpYxAXdCDnURnlaiiR 96t5u2G7H/DfcCMlFOLCk+3Ip8mrO9S1SnoFGBGwlYtPx46Q7cEsAY9jIkHs5viFAsNT UnJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=49qaqMdrBcj2mU84jKAP+Y0tov3oD0nk/O30siIAc9w=; b=G0YxFh5ggxBcNdkisSeNjmeGesR7RqXxEzmmfZLQusw+UBdkm6ikYsFUeMvpNxDG/g gLfAXaogyV/7HpAkhHR8xKl3caB9UHX11LbOcnaUu+b7nOHQdqEEVHWPzE5Ohuu1DBYS N3krD1smKBpA4zTTf8+UKVvltUNnbJ0m2HZtj6HZhoGlluwpQ7AxSvqpjKLTl4oaBBtm USUhRVUfWo9Huh1sc0EqYwM81Dk8oAscaM7W6TPsyVTq5PdGelEU6Docjorl9/0/2Qev KczbjlmWl+OxIESAoXiqD2JOIPHFCEzWhht3FRLaXyBN7dJQ7lsZoBkaznXMjeKqwSr1 i7IQ== X-Gm-Message-State: AKS2vOwV38bsgkRujZdnyyzAyVa7Ntv0v4T0PLbthx6tf2EKzESkT+Sx Gpg1csqD8MNNVj/inXg= X-Received: by 10.28.189.67 with SMTP id n64mr13863305wmf.115.1497831559404; Sun, 18 Jun 2017 17:19:19 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id n14sm4092075wmd.1.2017.06.18.17.19.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Jun 2017 17:19:18 -0700 (PDT) In-Reply-To: <87shmm823i.fsf@users.sourceforge.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133738 Archived-At: On 3/10/17 1:25 AM, npostavs@users.sourceforge.net wrote: > This seems to have been introduced by [1: 65797b1]. I guess > completion-pcm--filename-try-filter should not reverse its input? > > 1: 2016-04-28 19:31:43 +0200 65797b1d75e9f608ffd50fd88be47a854b143bb1 > Make icomplete respect `completion-ignored-extensions' > > --- i/lisp/minibuffer.el > +++ w/lisp/minibuffer.el > @@ -3257,7 +3257,7 @@ completion-pcm--filename-try-filter > "\\)\\'"))) > (dolist (f all) > (unless (string-match-p re f) (push f try))) > - (or try all)))) > + (or (nreverse try) all)))) Looks good to me, thank you. But what are the chances of this 'nreverse' (or the whole function) being performance-significant? Maybe we could switch this code to `cl-delete-if'. From my testing, it's considerably faster than dolist+push (even without nreverse).