From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eugen Dedu Newsgroups: gmane.emacs.bugs Subject: bug#20619: Scrollbars Date: Fri, 23 Dec 2016 21:30:17 +0100 Message-ID: <932ffe0b-8e9e-5a47-1a3f-47df43f7be42@univ-fcomte.fr> References: <555CD05C.4070303@stsci.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1482525079 2424 195.159.176.226 (23 Dec 2016 20:31:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Dec 2016 20:31:19 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 To: 20619@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 23 21:31:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKWUd-0007jo-7y for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Dec 2016 21:31:07 +0100 Original-Received: from localhost ([::1]:40806 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKWUh-0000Sj-TV for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Dec 2016 15:31:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKWUc-0000Sd-9o for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 15:31:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKWUZ-0000cz-3f for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 15:31:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37617) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cKWUZ-0000cv-0c for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 15:31:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cKWUY-0002hB-3H for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 15:31:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <555CD05C.4070303@stsci.edu> Resent-From: Eugen Dedu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Dec 2016 20:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20619-submit@debbugs.gnu.org id=B20619.148252502710304 (code B ref 20619); Fri, 23 Dec 2016 20:31:02 +0000 Original-Received: (at 20619) by debbugs.gnu.org; 23 Dec 2016 20:30:27 +0000 Original-Received: from localhost ([127.0.0.1]:53016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKWTy-0002g8-Ui for submit@debbugs.gnu.org; Fri, 23 Dec 2016 15:30:27 -0500 Original-Received: from ufc-sortie.univ-fcomte.fr ([194.57.91.199]:56370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKWTw-0002fu-UH for 20619@debbugs.gnu.org; Fri, 23 Dec 2016 15:30:25 -0500 Original-Received: from ufc204.univ-fcomte.fr (ufc204.univ-fcomte.fr [194.57.91.204]) by ufc-sortie.univ-fcomte.fr (Postfix) with ESMTP id AAEA160455 for <20619@debbugs.gnu.org>; Fri, 23 Dec 2016 21:30:18 +0100 (CET) Original-Received: from smtps.univ-fcomte.fr (localhost.localdomain [127.0.0.1]) by ufc204.univ-fcomte.fr (Postfix) with ESMTP id 8B2C1906D for <20619@debbugs.gnu.org>; Fri, 23 Dec 2016 21:30:18 +0100 (CET) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127380 Archived-At: So I have successfully compiled emacs 25.1.1 to make tests. I applied the patch given in message #13, but it works partially, I will discuss about it later. Now, to advance emacs support for HIDPI I would like to fix the scrollbar. Do all people here agree that the scrollbar has a width twice as normal? The reason is that in src/gtkutil.c there is this code: int xg_get_default_scrollbar_width (void) { return scroll_bar_width_for_theme * xg_get_gdk_scale (); } where xg_get_gdk_scale returns GDK_SCALE variable, i.e. 2 in general. If I replace with: return scroll_bar_width_for_theme; the scrollbar is shown correctly. This change was made by https://github.com/emacs-mirror/emacs/commit/c0055ff5b03c9121ab5bf752496b09416f0f0a7d. I think there was an error there, or perhaps in the mean time (since May 2015) GTK has changed in a way so that scrollbars are taken into account. Anyway, using "GTK_SCALE=2 emacs" shows correctly the scrollbar with my proposition. Note that GDK_DPI_SCALE is only for font, AFAIU from https://developer.gnome.org/gtk3/stable/gtk-x11.html. What do you think? Would you commit such a modification? I would like to look into other issues as well.