all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eugen Dedu <eugen.dedu@univ-fcomte.fr>
To: 20619@debbugs.gnu.org
Subject: bug#20619: Scrollbars
Date: Fri, 23 Dec 2016 21:30:17 +0100	[thread overview]
Message-ID: <932ffe0b-8e9e-5a47-1a3f-47df43f7be42@univ-fcomte.fr> (raw)
In-Reply-To: <555CD05C.4070303@stsci.edu>

So I have successfully compiled emacs 25.1.1 to make tests.

I applied the patch given in message #13, but it works partially, I will 
discuss about it later.

Now, to advance emacs support for HIDPI I would like to fix the 
scrollbar.  Do all people here agree that the scrollbar has a width 
twice as normal?  The reason is that in src/gtkutil.c there is this code:

int
xg_get_default_scrollbar_width (void)
{
   return scroll_bar_width_for_theme * xg_get_gdk_scale ();
}

where xg_get_gdk_scale returns GDK_SCALE variable, i.e. 2 in general.

If I replace with:
   return scroll_bar_width_for_theme;
the scrollbar is shown correctly.

This change was made by 
https://github.com/emacs-mirror/emacs/commit/c0055ff5b03c9121ab5bf752496b09416f0f0a7d. 
  I think there was an error there, or perhaps in the mean time (since 
May 2015) GTK has changed in a way so that scrollbars are taken into 
account.

Anyway, using "GTK_SCALE=2 emacs" shows correctly the scrollbar with my 
proposition.

Note that GDK_DPI_SCALE is only for font, AFAIU from 
https://developer.gnome.org/gtk3/stable/gtk-x11.html.

What do you think?  Would you commit such a modification?

I would like to look into other issues as well.





  parent reply	other threads:[~2016-12-23 20:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 18:20 bug#20619: 24.5; Pop-up menus clipped on HiDPI (Gtk3/X11) Michael Droettboom
2015-05-23 12:06 ` Jan Djärv
2016-05-11 15:02 ` bug#20619: Another HiDPI issue C. Scott Ananian
2016-05-16  8:20   ` martin rudalics
2016-05-16 18:31     ` C. Scott Ananian
2016-05-18  7:00       ` martin rudalics
2016-05-18 12:20         ` C. Scott Ananian
     [not found]           ` <CAHD_y+aqKdHYBucR3VkwduiVWDex4oCmX6EeYYkoKC+Fb=RoSA@mail.gmail.com>
     [not found]             ` <CAHD_y+Z1D37uNOcnrn2SaxSO9bksEOV_Ni0QhZ2fE1nLvMRD+g@mail.gmail.com>
2016-05-18 12:24               ` C. Scott Ananian
2016-05-19 12:55                 ` martin rudalics
2016-12-22 15:33 ` bug#20619: Improving HiDPI experience with emacs Eugen Dedu
2016-12-23 20:30 ` Eugen Dedu [this message]
2016-12-24  7:56   ` bug#20619: Scrollbars Eli Zaretskii
2016-12-27 22:45     ` Eugen Dedu
2016-12-28 15:41       ` Eli Zaretskii
2016-12-28 16:35         ` Eugen Dedu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=932ffe0b-8e9e-5a47-1a3f-47df43f7be42@univ-fcomte.fr \
    --to=eugen.dedu@univ-fcomte.fr \
    --cc=20619@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.