From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete Date: Tue, 24 Dec 2019 21:53:46 +0200 Message-ID: <932cfe15-5e8b-1bf4-5b81-9d0f2a513dea@yandex.ru> References: <877e5dzgnb.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="75295"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: Dan Nicolaescu , 34949@debbugs.gnu.org To: Lars Ingebrigtsen , Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 24 20:54:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ijqFv-000JTX-Dw for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Dec 2019 20:54:11 +0100 Original-Received: from localhost ([::1]:41634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijqFt-0005GX-JE for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Dec 2019 14:54:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37012) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijqFn-0005Dt-G4 for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2019 14:54:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ijqFm-0007t1-Ip for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2019 14:54:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47114) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ijqFm-0007sw-E1 for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2019 14:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ijqFm-00012D-6l for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2019 14:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Dec 2019 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 34949-submit@debbugs.gnu.org id=B34949.15772172373966 (code B ref 34949); Tue, 24 Dec 2019 19:54:02 +0000 Original-Received: (at 34949) by debbugs.gnu.org; 24 Dec 2019 19:53:57 +0000 Original-Received: from localhost ([127.0.0.1]:53087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijqFh-00011u-Hj for submit@debbugs.gnu.org; Tue, 24 Dec 2019 14:53:57 -0500 Original-Received: from mail-wr1-f51.google.com ([209.85.221.51]:46796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijqFf-00011h-6T for 34949@debbugs.gnu.org; Tue, 24 Dec 2019 14:53:56 -0500 Original-Received: by mail-wr1-f51.google.com with SMTP id z7so20490838wrl.13 for <34949@debbugs.gnu.org>; Tue, 24 Dec 2019 11:53:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fmVo+WrtFJXmeWlJdvSVPqlLoByxJvGa6D8iEfapyJs=; b=K1lyjMI++h5mAprLOMnt5EUOZpjSpcqh1fW6Q6M5cj7GWQz1hg8aI9ygyqnyModcdY pz7aPJHXBh1MLlFqtQ3+YC1cmDSGzj6m4gFsnJRKkPsVmBH6PYI42FNK6P9OY3RDUdDx ClFHp0XWsou9a9KoNwS7qW7sFA9JH03MV+/9lhghnbtFY5F1GakIYt+iO8UWOci6SH2C o2t2QWLxcongfEaMv70y7yBHtHoUhZNKFVBisLq8nIRCSJ/ZPSjbP4/NFbIFYG9ml3VU ytW3QHJYJNidZgo8aLWqLZ0x7hqMQBVVtX6F7iZ2uvJSmNApmbjiavLJ5rSEe41JFPds gz3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fmVo+WrtFJXmeWlJdvSVPqlLoByxJvGa6D8iEfapyJs=; b=T2mhW1c4zDedjZFe00UiLfcyKcMSdhtTlgy0fOylYr5teHf1mdiL6i5+/Ws10ZFaBS wl3fYhkQ/l+uPSJGXtWGOmZeAU6GNypuuhaA8gQD4vFiHTw1/FrWBoz13uTGirjG4i1J tzRL+3vy8EFe/2AlCRx3eA5xhvuJMSMoMNN3QPhrJjI6TlhGUj/o74sRQsgjauucWiSg Rwa2TgPkMc0z88EeTeWwgVHDJ0bDtJ0xc3MxPJ5aDzTLgAfMIRellDx9Ol4bANwj1MNt E2kdlmaXYfll8fGG6ZTGENZfqAJComfJdByIbaOoGmSG4ygQghfnJZN0kAi+Gjl/Ckvc coOg== X-Gm-Message-State: APjAAAUyoD8xShd6OY6RX9cO9/cTq+AVJaAFwnIJX2FassZ9M7ziyxXm XoPK0TEAEvgtzE+yAhYaYrc= X-Google-Smtp-Source: APXvYqwHELx4P+Xc0oDpIV4xR56PL3vz/C8Wggaw0KXRLOdssKpFcAIf599MH2cmITyCBUIhhE1Xjg== X-Received: by 2002:adf:e5cf:: with SMTP id a15mr19838794wrn.140.1577217229261; Tue, 24 Dec 2019 11:53:49 -0800 (PST) Original-Received: from [192.168.0.2] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id z187sm3535894wme.16.2019.12.24.11.53.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Dec 2019 11:53:48 -0800 (PST) In-Reply-To: <877e5dzgnb.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173723 Archived-At: Hi Lars, On 10.10.2019 1:40, Lars Ingebrigtsen wrote: > But we see that it's used, and used for one thing only: If we call this > function in a dired buffer, the function will signal an error if > OBSERVER is nil. So all the callers of this function pass in t if it's > a non-state-changing operation. This is my impression as well. > So the parameter does make some sense: OBSERVER non-nil means that it's > a non-destructive operation we're doing to do (but we only care in dired > buffers). Exactly. So step 1 is probably to document is with 1-2 lines in a docstring. Maybe a rename as well? E.g. to READONLY-OPERATION. > Having that check in this function may be a bit odd, but... I think it's fine to have it there, since most VC commands end up calling this function. What I don't fully understand, however, is why prohibit state-changing operations in Dired buffers. Is it just because there's no VC-Dir buffer easily at hand, to update the visible file statuses? Or maybe it's for the user not to circumvent the "similar VC states" logic in VC-Dir.