From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: Setting `minibuffer-completion-table` buffer-locally Date: Sat, 24 Apr 2021 13:08:35 +0200 Message-ID: <931a4f41-44fd-a7d2-46e6-86b8cdffb0cf@daniel-mendler.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1697"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 24 13:10:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1laGAk-0000Jk-Ii for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Apr 2021 13:10:02 +0200 Original-Received: from localhost ([::1]:45190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laGAj-0005nm-N3 for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Apr 2021 07:10:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laG9k-0005O6-3J for emacs-devel@gnu.org; Sat, 24 Apr 2021 07:09:00 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:40487 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laG9h-0005Qc-FU for emacs-devel@gnu.org; Sat, 24 Apr 2021 07:08:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=owtj9JaOjSYu2gvFco3+4C/Y/Qj1eW/W8LhOgKzr5zA=; b=AfwsAsH9UM6OhKYc1/+Tb/zx3f pIASX23RoX2yTyODbthfGGO6R92JbH5ck61fQwjft768Rdr91u7ANQ7dzIoPLFiTzA7vyiIH7jiqi 8vgOp0r9/p/5tAlVNtwEOFPFGkZ4ftl9rheoXCqCxtfFr25pW9mDPRow9Pj+AdmRfKB4=; In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268331 Archived-At: On 4/24/21 4:56 AM, Stefan Monnier wrote: > Following a long discussion in bug#45474, I'm warming up to the idea to > install the patch below which changes `completing-read(-default)` such > that it sets the `minibuffer-completion-*` variables buffer-locally in > the mini-buffer instead of let-binding them globally. I am in favor of such a change. In the completion systems or packages centered around completion I am involved with (Selectrum, Vertico, Marginalia, Consult, Embark, ...) we always followed the style of encapsulating minibuffer-local state inside the minibuffer. Let-binding the built-in table always seemed odd. I don't expect breakage from these packages. If some issues occur despite my expectations we will fix them promptly. It is no problem to fix issues in a backward compatible way by always accessing the minibuffer-completion-table via the minibuffer, if for some reason the variable is accessed from the context of another buffer. Daniel