From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?iso-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: Build failure from trunk Date: Thu, 9 May 2013 10:10:45 +0200 Message-ID: <9304549B-E62D-46DC-BE7A-48F71ED274AD@swipnet.se> References: <518A655A.4080508@cs.ucla.edu> <2F51B02E-645E-41A1-91A0-1198E9898D1F@swipnet.se> <518AD8F1.6000502@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1368087061 27231 80.91.229.3 (9 May 2013 08:11:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 May 2013 08:11:01 +0000 (UTC) Cc: Matthew Leach , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 09 10:10:59 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UaLwJ-0002Fr-3N for ged-emacs-devel@m.gmane.org; Thu, 09 May 2013 10:10:59 +0200 Original-Received: from localhost ([::1]:37636 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaLwI-0001Gx-LE for ged-emacs-devel@m.gmane.org; Thu, 09 May 2013 04:10:58 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaLwA-0001Fn-0V for emacs-devel@gnu.org; Thu, 09 May 2013 04:10:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaLw8-0004ET-G6 for emacs-devel@gnu.org; Thu, 09 May 2013 04:10:49 -0400 Original-Received: from mailout.melmac.se ([62.20.26.67]:53849) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaLw7-0004Cg-Mh for emacs-devel@gnu.org; Thu, 09 May 2013 04:10:47 -0400 Original-Received: from mail01.melmac.se (mail01.melmac.se [62.20.26.80]) by mailout.melmac.se (Postfix) with ESMTP id 55D159202 for ; Thu, 9 May 2013 10:10:42 +0200 (CEST) Original-Received: (qmail 27324 invoked by uid 89); 9 May 2013 08:10:32 -0000 Original-Received: from unknown (HELO coolsville.localdomain) (boel.djarv@bdtv.se@176.10.223.235) by mail01.melmac.se with ESMTPA; 9 May 2013 08:10:32 -0000 Original-Received: from [172.20.199.13] (unknown [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id 468271A1D45; Thu, 9 May 2013 08:11:12 +0000 (UTC) In-Reply-To: <518AD8F1.6000502@cs.ucla.edu> X-Mailer: Apple Mail (2.1503) X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 62.20.26.67 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159442 Archived-At: Hello. 9 maj 2013 kl. 01:00 skrev Paul Eggert : > On 05/08/13 09:01, Jan Dj=E4rv wrote: >> At least they should be the same so someone reading the code can see = that they are related. >=20 > Good point. Glibc has a good style here; it defines macros > __GNUC_PREREQ, __GLIBC_PREREQ, etc., to check version numbers. > I added a macro GTK_PREREQ to do that with the similar uses > for GTK version numbers, as trunk bzr 112523. Please feel > free to change it if you still find it confusing. Good idea. But you missed one in gtkutils.c. Jan D.