From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Matthew Leach <matthew@mattleach.net>, emacs-devel@gnu.org
Subject: Re: Build failure from trunk
Date: Thu, 9 May 2013 10:10:45 +0200 [thread overview]
Message-ID: <9304549B-E62D-46DC-BE7A-48F71ED274AD@swipnet.se> (raw)
In-Reply-To: <518AD8F1.6000502@cs.ucla.edu>
Hello.
9 maj 2013 kl. 01:00 skrev Paul Eggert <eggert@cs.ucla.edu>:
> On 05/08/13 09:01, Jan Djärv wrote:
>> At least they should be the same so someone reading the code can see that they are related.
>
> Good point. Glibc has a good style here; it defines macros
> __GNUC_PREREQ, __GLIBC_PREREQ, etc., to check version numbers.
> I added a macro GTK_PREREQ to do that with the similar uses
> for GTK version numbers, as trunk bzr 112523. Please feel
> free to change it if you still find it confusing.
Good idea. But you missed one in gtkutils.c.
Jan D.
next prev parent reply other threads:[~2013-05-09 8:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 8:43 Build failure from trunk Matthew Leach
2013-05-07 17:48 ` Jan Djärv
2013-05-07 19:29 ` Paul Eggert
2013-05-08 5:06 ` Jan Djärv
2013-05-08 14:46 ` Paul Eggert
2013-05-08 16:01 ` Jan Djärv
2013-05-08 23:00 ` Paul Eggert
2013-05-09 8:10 ` Jan Djärv [this message]
2013-05-09 14:51 ` Paul Eggert
2013-05-09 15:19 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9304549B-E62D-46DC-BE7A-48F71ED274AD@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=matthew@mattleach.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.