From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#25268: 25.1; configure.ac libpng search error Date: Sat, 24 Dec 2016 17:08:10 -0800 Organization: UCLA Computer Science Department Message-ID: <92f77364-2356-8861-a500-fcec4bcc7fdc@cs.ucla.edu> References: <87fulddnfn.fsf@willow.schemamania.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------AD9D9A8D1BE9A5FA04EC6905" X-Trace: blaine.gmane.org 1482628159 7211 195.159.176.226 (25 Dec 2016 01:09:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Dec 2016 01:09:19 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 Cc: 25268-done@debbugs.gnu.org To: "James K. Lowden" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 25 02:09:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKxJH-00013t-Ob for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Dec 2016 02:09:11 +0100 Original-Received: from localhost ([::1]:45290 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKxJM-0000Ge-BG for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Dec 2016 20:09:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKxJC-0000GE-3Q for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 20:09:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKxJ8-0000De-UY for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 20:09:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38769) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cKxJ8-0000DR-Q7 for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 20:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cKxJ8-0006CP-FX for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 20:09:02 -0500 In-Reply-To: <87fulddnfn.fsf@willow.schemamania.org> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Dec 2016 01:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 25268 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 25268@debbugs.gnu.org, eggert@cs.ucla.edu, jklowden@schemamania.org Original-Received: via spool by 25268-done@debbugs.gnu.org id=D25268.148262810223758 (code D ref 25268); Sun, 25 Dec 2016 01:09:02 +0000 Original-Received: (at 25268-done) by debbugs.gnu.org; 25 Dec 2016 01:08:22 +0000 Original-Received: from localhost ([127.0.0.1]:54168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKxIU-0006B8-9w for submit@debbugs.gnu.org; Sat, 24 Dec 2016 20:08:22 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:33190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKxIT-0006At-39 for 25268-done@debbugs.gnu.org; Sat, 24 Dec 2016 20:08:21 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 04DC216006D; Sat, 24 Dec 2016 17:08:15 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id s4r8PxF1Bmuj; Sat, 24 Dec 2016 17:08:11 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E9D2816009E; Sat, 24 Dec 2016 17:08:10 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yR2CaHCT2EYX; Sat, 24 Dec 2016 17:08:10 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.153.178.162]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C02F916006D; Sat, 24 Dec 2016 17:08:10 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127423 Archived-At: This is a multi-part message in MIME format. --------------AD9D9A8D1BE9A5FA04EC6905 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > I believe the fix is to change line 3413 of configure.ac to read: > > png_libs=`(libpng-config --ldflags) 2>&AS_MESSAGE_LOG_FD` || { Thanks, I did something along those lines by installing the attached patch into master, and I'm boldly marking the bug report as done. > although IMO that's not quite sufficient, because it doesn't set RPATH. --ldflags is supposed to output any -R options needed, no? If it's not, it sounds like the libpng-config configuration is incorrect. --------------AD9D9A8D1BE9A5FA04EC6905 Content-Type: text/x-diff; name="0001-Use-libpng-config-ldflags-not-libs.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Use-libpng-config-ldflags-not-libs.patch" >From 5bdbbe3e89adbb2a2092cc73586ffc38ddbb95d9 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 24 Dec 2016 17:03:22 -0800 Subject: [PATCH] Use libpng-config --ldflags, not --libs Problem reported by James K. Lowden (Bug#25268). * configure.ac (LIBPNG): Pass --ldflags, not --libs, to libpng-config. --- configure.ac | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 5aaf006..cd6c689 100644 --- a/configure.ac +++ b/configure.ac @@ -3476,7 +3476,7 @@ AC_DEFUN elif test "${HAVE_X11}" = "yes" || test "${HAVE_W32}" = "yes"; then AC_MSG_CHECKING([for png]) png_cflags=`(libpng-config --cflags) 2>&AS_MESSAGE_LOG_FD` && - png_libs=`(libpng-config --libs) 2>&AS_MESSAGE_LOG_FD` || { + png_ldflags=`(libpng-config --ldflags) 2>&AS_MESSAGE_LOG_FD` || { # libpng-config does not work; configure by hand. # Debian unstable as of July 2003 has multiple libpngs, and puts png.h # in /usr/include/libpng. @@ -3486,18 +3486,18 @@ AC_DEFUN else png_cflags= fi - png_libs='-lpng' + png_ldflags='-lpng' } SAVE_CFLAGS=$CFLAGS SAVE_LIBS=$LIBS CFLAGS="$CFLAGS $png_cflags" - LIBS="$png_libs -lz -lm $LIBS" + LIBS="$png_ldflags -lz -lm $LIBS" AC_LINK_IFELSE( [AC_LANG_PROGRAM([[#include ]], [[return !png_get_channels (0, 0);]])], [HAVE_PNG=yes PNG_CFLAGS=`AS_ECHO(["$png_cflags"]) | sed -e "$edit_cflags"` - LIBPNG=$png_libs + LIBPNG=$png_ldflags # $LIBPNG requires explicit -lz in some cases. # We don't know what those cases are, exactly, so play it safe and # append -lz to any nonempty $LIBPNG, unless we're already using LIBZ. -- 2.7.4 --------------AD9D9A8D1BE9A5FA04EC6905--