From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#51497: 29.0.50; (vc-print-log) broken over TRAMP Date: Mon, 8 Nov 2021 01:36:18 +0300 Message-ID: <92da67f0-9133-98ba-69e3-7408fab30539@yandex.ru> References: <877ddv9ue0.fsf@jpl.nasa.gov> <87tugyptju.fsf@gnus.org> <87tugy8h3a.fsf@secretsauce.net> <87pmrl8yhy.fsf@secretsauce.net> <60fea707-a9b2-d9f4-cc45-ffd4539887b6@yandex.ru> <87o87253sv.fsf@secretsauce.net> <60af7952-d702-d40f-928e-1320e6d9520f@yandex.ru> <83f40a2a-ae5a-2c6c-cf6a-44ff7c933d16@yandex.ru> <831r3tb7un.fsf@gnu.org> <7e04f090-81de-d5bd-746c-7f09ed0c38b0@yandex.ru> <83lf219i3u.fsf@gnu.org> <86r1btvsso.fsf@gmail.com> <86ilx4x4xv.fsf@gmail.com> <1f17978c-0498-a19b-6bb0-6f316a536f8e@yandex.ru> <83h7coa2cs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26189"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: 51497@debbugs.gnu.org, andrewjmoreton@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 07 23:37:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjqmk-0006bw-Ol for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Nov 2021 23:37:10 +0100 Original-Received: from [::1] (port=52150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjqmj-0003iy-LD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Nov 2021 17:37:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjqmc-0003gA-JL for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 17:37:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43638) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjqmc-0006a2-9f for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 17:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjqmc-0003mD-7F for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 17:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Nov 2021 22:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51497 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 51497-submit@debbugs.gnu.org id=B51497.163632459214473 (code B ref 51497); Sun, 07 Nov 2021 22:37:02 +0000 Original-Received: (at 51497) by debbugs.gnu.org; 7 Nov 2021 22:36:32 +0000 Original-Received: from localhost ([127.0.0.1]:55184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjqm8-0003lN-BG for submit@debbugs.gnu.org; Sun, 07 Nov 2021 17:36:32 -0500 Original-Received: from mail-lf1-f46.google.com ([209.85.167.46]:43736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjqm6-0003l7-HJ for 51497@debbugs.gnu.org; Sun, 07 Nov 2021 17:36:31 -0500 Original-Received: by mail-lf1-f46.google.com with SMTP id b40so2630566lfv.10 for <51497@debbugs.gnu.org>; Sun, 07 Nov 2021 14:36:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PaoXmscWeUQvD9xoxB3BbPCvvjx4vC48bMQl/1LmyLQ=; b=eju/K2TM+EitHtfguKjmfh66yBXqB8dH1mQ5oYRv6GF8mLCsq71vNEBlWQhBvqGjVc fcO8UFXeuGDbSvrUBF1kNqhVEmHdpgVPSR1mP4xGWFjorVjBFL5oyrgPIXwglO8h+YHg n6lS4GvcOfwAARCD4uJ6v2LseqFzwrQ6SK28GX45QhGzZpeZWQr2xqbOR0QliwfJkYC7 /wHuH15dWg0/bKYD7PPxFzaNhGSTApi7XtMRrZwgYZ/MZwdb8sQYxdvnurQiK54VhjWq OJ0qnypJeKdWZOz6zyXH3mK3ElGzB97h8DS3ROiDaS9NMyLRMs5+FNUsGkTuEeEaoqNI tpdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PaoXmscWeUQvD9xoxB3BbPCvvjx4vC48bMQl/1LmyLQ=; b=KDSZP0z/jYEltoPRtDKbmMLl35GtGSgxEfgd0qLGUkSRPkQJlZgRUmsQ1J9Ft7m8qT VI5o+XCtI2BJ05cthnpMKb7FAj/tJCNblSKfLP8vQcAd1xZMGTJvgvmDSylKlBBIMPR+ nT9EQUbIIPpkSKAQcnIXY3AwTFS+5ZvddlGkjlLamZN0YnBrV2N/nQHwy3n0muZn+IR1 e5izAXraolRQV33dIkbxVC53bJiw6aUzTSLFiLnW/eVA4p/cba1QkuIWsT5jLONBOC4A kgYpU6PDolJR4Ev6V1gANfKpmaFHyfbaqTh7F3gdolv5i755bj6V2J8FIFajV/Qkm6WE X9/w== X-Gm-Message-State: AOAM531eSGbA6GBdqfPoml7RKUNUWVR2lsppm3U9n5hvrI+dExCSixyk Sp/FafRsqOLau+ouDuT7jTs= X-Google-Smtp-Source: ABdhPJxzpGeelac84NI/TJhJvBTqKt1eS64ItxIba/go1nNQ9mPuKZpc/5YZ/p3nvo6yPjqQ2jbJFw== X-Received: by 2002:a05:6512:ace:: with SMTP id n14mr67640381lfu.460.1636324584279; Sun, 07 Nov 2021 14:36:24 -0800 (PST) Original-Received: from [192.168.0.103] ([5.18.235.131]) by smtp.googlemail.com with ESMTPSA id 138sm232663ljf.89.2021.11.07.14.36.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Nov 2021 14:36:23 -0800 (PST) In-Reply-To: <83h7coa2cs.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219299 Archived-At: On 07.11.2021 09:47, Eli Zaretskii wrote: >> From: Dmitry Gutov >> Date: Sun, 7 Nov 2021 03:11:43 +0300 >> >> Failing that, I think we'll need to change the "literal pathspecs" >> implementation to yet another approach (adding --literl-pathspecs flag >> instead of manipulating file names). It comes with the same general >> drawbacks as the env var (which is used under the hood), but the >> explicit approach of specifying it in every command would avoid the >> problem of my original fix for that bug. > > Why wasn't --literal-pathspecs used in the first place? what are the > downsides? IME, using magic file names is always worse, because it > can run afoul of various shells that consider some characters special. It wasn't among the proposed solutions. I went with the env var solution initially (because it required less code and brought fewer -- none -- Git version compatibility problems), but it didn't yield itself as easily to the per-action opt-in as the other proposal (currently installed). But now that I think about it, it would be possible to do this without a new macro, just adding a new variable that default to nil, and set it to t in every backend method that needs it.