From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#73552: obsolete (and broken) face attribute :reverse-video Date: Sun, 29 Sep 2024 14:35:01 +0200 Message-ID: <92B0B60A-A2A3-470B-A269-75531CA4FCE2@gmail.com> References: Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4601"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73552@debbugs.gnu.org, eliz@gnu.org, monnier@iro.umontreal.ca To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 29 14:35:45 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sut9M-00013l-DY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Sep 2024 14:35:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sut9F-00025W-VQ; Sun, 29 Sep 2024 08:35:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sut9D-00025J-Vb for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:35:35 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sut9D-0000FE-Kj for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:35:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=yRCOH1OLDMFtmD+y9alzoPhQ1yAS4s/6BPXEtzvwiv4=; b=aqsQZK2VS6uuoZJvsnFxF07FTfuFxKhEfh28iZeMrtBRG85en8gbN0QX6Y7vpR/0sUDyyfBr2HIynDBhGvt0l74AUCfGA+CZc3Ojzh9T3FUXfWhBdMosz56XkLhk108GzCmJS3AE5exyRUlxjFak4FiA07VmaoQtNtUOi3q7B1kWcmV9eqD4mEF3DbbNvc6NRpoAy5yk4gUZAMw/u97Rhnvb3B/5iuBHahCOn3nbO8DkRoxvH0zM8LIOLtEwDQH/fJiG5K9CiTA5sV182xvPh8k3PitAeh5uMRfb4tFxqDdNvNrPZO+WW94Hw/z3+guxRXsaP+AOjQ8U4DNql5msZw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sut9i-0005T8-J6 for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:36:06 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2024 12:36:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73552 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: Emacs Bug Report , Eli Zaretskii , Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.172761334420343 (code B ref -1); Sun, 29 Sep 2024 12:36:06 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Sep 2024 12:35:44 +0000 Original-Received: from localhost ([127.0.0.1]:40226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sut9K-0005Gy-26 for submit@debbugs.gnu.org; Sun, 29 Sep 2024 08:35:43 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:59514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sut9H-0005GK-Q8 for submit@debbugs.gnu.org; Sun, 29 Sep 2024 08:35:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sut8m-00021e-7r for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:35:08 -0400 Original-Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sut8k-0000BY-Kd; Sun, 29 Sep 2024 08:35:07 -0400 Original-Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2fac187eef2so9270251fa.3; Sun, 29 Sep 2024 05:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727613303; x=1728218103; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=yRCOH1OLDMFtmD+y9alzoPhQ1yAS4s/6BPXEtzvwiv4=; b=F5fvKPN1Djy04YjUa0nlpwyHI3NMwP5HWHwgV+J8P3e81l/6OSADLZP22NCRcRNd/W ji4RILFdExb/ZkgjyJt/sggUXr0zwd4GJb4C3KDG3udsSFD/NQlP2tHOcMC3g7GeGVeN ophK+4wcb8viR1YF5LJGkF7QQUlqCAptqSHarz20PcchFyf07Xs8ZM9KNMUQrop1DboT 3EnC1ZrU2Y/kC1e1f+py7lXvhThBlsK3CYkHpVO48+7/GyXSYxeBn83XwTVNw91Hm0az bLrBvzVSYxGAtDPYjAb5MLH11e9vqGSxPRAdSnTLa64OS0bvTGvewXBPuGm0qwh8hnlh 3mmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727613303; x=1728218103; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yRCOH1OLDMFtmD+y9alzoPhQ1yAS4s/6BPXEtzvwiv4=; b=a3tEnmh0lzve9Uzhi4RuLGZjaAgLGURXPkoS8376BWUBgYWzQ/7zx8JFz0dnzdrVW+ jJ4/GZZ5YgqJdbG3g95i77cdXtzR7gSRulu3RKeQeCS32RhF+tgXy0k0WdNnkdsnoJY4 eQfMoDaxsRChQUnK2HWzeACEwJrJDwV7+lygHCO7mP6V9n8cgeMzTyBFOYv5XRDt3GTX a97SVAeQX+FQhVubXoaPZ4yuVwXaGHmm1tsg0CJpZjEG8e1+oYOzYxzAv6P82dyg22hM 3ljxvHWD5byx8EIov+B9q2sBaB3gSgqp5MCK9Q8OBzKjpzOd0ADoRzmjaB+GrgkiNhap SnGA== X-Forwarded-Encrypted: i=1; AJvYcCVioByhT5uoFJu9e/I9ngthHQq5YdPZJC13+DAuBSYkOYzp5yuh+o2RVf76awi8N0J72JRy@gnu.org X-Gm-Message-State: AOJu0YwE8tLJVUKxaSQphNadqGlXwCrKfZMgAJrFwp08Cf+fXNh0yFUT 1cRL13y46GQ1DOms9NtzdAdheErw8abGQ7Z2vaCltvIvn38pukvZ X-Google-Smtp-Source: AGHT+IFCLP81FvPrHmvecOeq5VQZz5jxJoRQD5OXfVT83TUyXyKNJptr/Q5oKqAuANWOZrRjIXuH5Q== X-Received: by 2002:a2e:bc17:0:b0:2f7:5a83:a90b with SMTP id 38308e7fff4ca-2f9d3e380ebmr47446551fa.8.1727613303089; Sun, 29 Sep 2024 05:35:03 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-191-82.bredband.tele2.se. [188.150.191.82]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f9d45d7385sm10076701fa.31.2024.09.29.05.35.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Sep 2024 05:35:02 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::229; envelope-from=mattias.engdegard@gmail.com; helo=mail-lj1-x229.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292635 Archived-At: 29 sep. 2024 kl. 13.31 skrev Gerd M=C3=B6llmann = : >> I first blamed a simple 14 years old mistake in = `custom-fix-face-spec` >> but fixing that doesn't help, not sure why. Having said that I naturally had to find the bug and it appears to be = `face-spec-set-2` which only sets attributes that are present in = `face-x-resources` for some reason. > I'm pretty sure that I added :italic, :bold, :reverse-video to what > later became Emacs 21 only for backwards compatibility with the old > pre-21 face implementation. At least on the surface, because 21 faces > work completely differently. (I also seem to remeber that = reverse-video > was a synonym for inverse-video in the old code, maybe even > undocumented. Thanks. Given Gerd's testimony, the lack of use and general brokenness, = I propose we just give up on :reverse-video, perhaps removing it from = xfaces.c.