From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: 73552@debbugs.gnu.org, eliz@gnu.org, monnier@iro.umontreal.ca
Subject: bug#73552: obsolete (and broken) face attribute :reverse-video
Date: Sun, 29 Sep 2024 14:35:01 +0200 [thread overview]
Message-ID: <92B0B60A-A2A3-470B-A269-75531CA4FCE2@gmail.com> (raw)
In-Reply-To: <m27causnlw.fsf@pro2.fritz.box>
29 sep. 2024 kl. 13.31 skrev Gerd Möllmann <gerd.moellmann@gmail.com>:
>> I first blamed a simple 14 years old mistake in `custom-fix-face-spec`
>> but fixing that doesn't help, not sure why.
Having said that I naturally had to find the bug and it appears to be `face-spec-set-2` which only sets attributes that are present in `face-x-resources` for some reason.
> I'm pretty sure that I added :italic, :bold, :reverse-video to what
> later became Emacs 21 only for backwards compatibility with the old
> pre-21 face implementation. At least on the surface, because 21 faces
> work completely differently. (I also seem to remeber that reverse-video
> was a synonym for inverse-video in the old code, maybe even
> undocumented.
Thanks. Given Gerd's testimony, the lack of use and general brokenness, I propose we just give up on :reverse-video, perhaps removing it from xfaces.c.
next prev parent reply other threads:[~2024-09-29 12:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 10:49 bug#73552: obsolete (and broken) face attribute :reverse-video Mattias Engdegård
2024-09-29 11:31 ` Gerd Möllmann
2024-09-29 12:35 ` Mattias Engdegård [this message]
2024-09-29 12:55 ` Eli Zaretskii
2024-09-29 13:41 ` Mattias Engdegård
2024-09-29 13:49 ` Eli Zaretskii
2024-09-29 13:55 ` Stefan Kangas
2024-09-29 16:22 ` Mattias Engdegård
2024-09-29 16:42 ` Eli Zaretskii
2024-09-29 17:25 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92B0B60A-A2A3-470B-A269-75531CA4FCE2@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=73552@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.