Re: master 3beb8bc 3/3: Allow controlling the look of the line/column indicators

Re: master 3beb8bc 3/3: Allow controlling the look of the line/column indicators

[Robert Pluim]

>>>>> On Tue, 15 Sep 2020 11:16:25 -0400 (EDT), larsi@gnus.org (Lars Ingebrigtsen) said:
    Lars> +the column number format (when 'column-number-mode') is on.  These are
    Lars> +also used if both modes are on, which leads to the default in that
    Lars> +case going from "(5,9)" to "(L5,C9)".

Uhm, what? Is that really what we want to use our precious mode-line
space for? (working out which is which if youʼre unsure is easy, you
just move point and see which one changes).

Robert

Re: master 3beb8bc 3/3: Allow controlling the look of the line/column indicators

[Lars Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

> Uhm, what? Is that really what we want to use our precious mode-line
> space for? (working out which is which if youʼre unsure is easy, you
> just move point and see which one changes).

By default, column number mode isn't switched on.  Shortening it is a
just an `M-x customize' away.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

RE: master 3beb8bc 3/3: Allow controlling the look of the line/column indicators

[Drew Adams]

>     Lars> +the column number format (when 'column-number-mode') is on.  These are
>     Lars> +also used if both modes are on, which leads to the default in that
>     Lars> +case going from "(5,9)" to "(L5,C9)".
> 
> Uhm, what? Is that really what we want to use our precious mode-line
> space for? (working out which is which if youʼre unsure is easy, you
> just move point and see which one changes).

FWIW, library `modeline-posn.el' adds some possibilities
for variable `mode-line-position'.

https://www.emacswiki.org/emacs/ModeLinePosition

https://www.emacswiki.org/emacs/download/modeline-posn.el

Re: master 3beb8bc 3/3: Allow controlling the look of the line/column indicators

[Robert Pluim]

>>>>> On Tue, 15 Sep 2020 17:43:03 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:

    Lars> Robert Pluim <rpluim@gmail.com> writes:
    >> Uhm, what? Is that really what we want to use our precious mode-line
    >> space for? (working out which is which if youʼre unsure is easy, you
    >> just move point and see which one changes).

    Lars> By default, column number mode isn't switched on.  Shortening it is a
    Lars> just an `M-x customize' away.

column number mode should be switched on by default. And we shouldn't
show these L,C monstrosities. Get off my lawn!

Robert

Re: master 3beb8bc 3/3: Allow controlling the look of the line/column indicators

[Juri Linkov]

>     Lars> +the column number format (when 'column-number-mode') is on.  These are
>     Lars> +also used if both modes are on, which leads to the default in that
>     Lars> +case going from "(5,9)" to "(L5,C9)".
>
> Uhm, what? Is that really what we want to use our precious mode-line
> space for? (working out which is which if youʼre unsure is easy, you
> just move point and see which one changes).

I don't care about the default value as long as there is a way
to revert it back in the init file.  But currently customization
of mode-line-position-column-format and mode-line-position-line-format
back to "%c" and "%l" has no effect.

Re: master 3beb8bc 3/3: Allow controlling the look of the line/column indicators

[Lars Ingebrigtsen]

Juri Linkov <juri@linkov.net> writes:

> I don't care about the default value as long as there is a way
> to revert it back in the init file.  But currently customization
> of mode-line-position-column-format and mode-line-position-line-format
> back to "%c" and "%l" has no effect.

D'oh.  I was thinking it was OK to require the user to set those
variables before loading the file mode-line-position is defined in, but
that file is preloaded in Emacs.  :-/

OK, so this needs a rethink...  mode-line-position precomputes some bits
presumably because it doesn't want to create a lot of garbage from the
`propertize' calls...  Hm...  OK, I think I see how to be make as little
garbage as before, but allow those variables to be taken into account
dynamically.

It'll even make the code shorter, I think.  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 3beb8bc 3/3: Allow controlling the look of the line/column indicators

[Lars Ingebrigtsen]

Juri Linkov <juri@linkov.net> writes:

> I don't care about the default value as long as there is a way
> to revert it back in the init file.  But currently customization
> of mode-line-position-column-format and mode-line-position-line-format
> back to "%c" and "%l" has no effect.

I think I've got all the combinations right here now...

And I've obsoleted column-number-indicator-zero-based, since you can
just alter the format specs instead.  (But it's still respected now, of
course.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 3beb8bc 3/3: Allow controlling the look of the line/column indicators

[Juri Linkov]

>> I don't care about the default value as long as there is a way
>> to revert it back in the init file.  But currently customization
>> of mode-line-position-column-format and mode-line-position-line-format
>> back to "%c" and "%l" has no effect.
>
> I think I've got all the combinations right here now...

Thanks.  I noticed another problem: the column/line format string
is not fixed-length anymore.  So when its length changes from e.g.
"(9,9)" to "(10,10)", the rest of the mode-line is shifted to the right,
and jumps right/left all the time when the cursor moves in the buffer.
This is a regression.  The mode-line was not so jumpy before,
the format string "  (%l, %c)  " was always the same fixed length.

Re: master 3beb8bc 3/3: Allow controlling the look of the line/column indicators

[Lars Ingebrigtsen]

Juri Linkov <juri@linkov.net> writes:

> Thanks.  I noticed another problem: the column/line format string
> is not fixed-length anymore.  So when its length changes from e.g.
> "(9,9)" to "(10,10)", the rest of the mode-line is shifted to the right,
> and jumps right/left all the time when the cursor moves in the buffer.
> This is a regression.  The mode-line was not so jumpy before,
> the format string "  (%l, %c)  " was always the same fixed length.

Yup.  I misunderstood what (-6 "...") meant -- it's max width, not min
width.  But (6 "...") is not, confusingly enough, not max width in the
context of a :propertize?  *scratches head*

I've now restored the min-width elements of these two elements on the
trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no