From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Tue, 3 Jan 2023 06:43:23 +0100 Message-ID: <92941757-2E9A-4883-A3F1-2DCA2E4E8767@secure.kjonigsen.net> References: <83118080-231f-cadf-a903-58e609a82751@secure.kjonigsen.net> Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21024"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60376@debbugs.gnu.org, eliz@gnu.org To: Yuan Fu , Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 03 06:44:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCa5v-0005DC-S0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Jan 2023 06:44:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCa5j-0007gM-5d; Tue, 03 Jan 2023 00:44:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCa5i-0007g9-Ey for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2023 00:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCa5h-0003gD-TR for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2023 00:44:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCa5h-00030q-Lz for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2023 00:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Jan 2023 05:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60376 X-GNU-PR-Package: emacs Original-Received: via spool by 60376-submit@debbugs.gnu.org id=B60376.167272462411546 (code B ref 60376); Tue, 03 Jan 2023 05:44:01 +0000 Original-Received: (at 60376) by debbugs.gnu.org; 3 Jan 2023 05:43:44 +0000 Original-Received: from localhost ([127.0.0.1]:44532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCa5Q-000309-GB for submit@debbugs.gnu.org; Tue, 03 Jan 2023 00:43:44 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCa5N-0002zu-5a for 60376@debbugs.gnu.org; Tue, 03 Jan 2023 00:43:43 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B142A5C054E; Tue, 3 Jan 2023 00:43:35 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 03 Jan 2023 00:43:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1672724615; x=1672811015; bh=2Drch5Tvyx iZlLdm4A5JpQlkRssvtoY7fECUGYM4mAU=; b=LvV24pVvfG9oy6QxFHRqGHPzVS tV7+J3egxu7SjY/z45p2kDWy65vaG5UV27+ImJKs5AzMIkzJLwOLwda8455vPKkS TTDUQhhRUsR5iXVftXNo/w/NBGmTtWtEfTdRSnyhcTJs2nI1D47nMVxoZzP8Ou/c yiA9e3QfousppvR2ZuKE7gf3rl0NyERCqgZNCpDJ/6gqzBGwV168Z3pa3RoHMfHB 973ZqhnlITTbFkGAinfgJJ0veSQabbGZLakvi2K69OHoc/hfHR1FHjTjoc8rmIK2 r6luJNXfoF1o+6gwshXNbJfHKCd26yz4Zpc/JUY6LiTXisAE4zc4e8tqW8YA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1672724615; x= 1672811015; bh=2Drch5TvyxiZlLdm4A5JpQlkRssvtoY7fECUGYM4mAU=; b=d DuRA2iKpmt98MWvmAhJJToWKlHpU7SRTylz7pqJwSnjsgZEttZ6wpK3Pjp9HrK08 yNQtHwxDJ4mvCpnVYRnEblcjxZY9giCujmmzDJvTrpkpSMjV+8VzprZ9lOPjuFzt wELTwepMi2mZVRtaASUBDjb4/WcMRJXWiVrxfQmCZzWy73DgD4WEV8i+k0X64Vur WACXUOrqoe3h/6jrfho5lWnq2TTmE5jF6bJyH48jF66TTNQOfscPY61l5ml2dBpE 17FBMj/ylDPIN0GMc4HrVgktBpU9KcuzpnPndusyPwncoMdFH9/DTbWOSFiylR1b KB3SCC3Gk1avCaULH7ebw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeefgdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtgffhggfufffkfhevjgfvofesthhqmhdthhdtjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeegudevffeifeegveduieetfedt gfetgfffgeeffeeghffgfefhffeggeduvddunecuffhomhgrihhnpehkjhhnihhgshgvnh drnhgvthenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Jan 2023 00:43:35 -0500 (EST) In-Reply-To: <83118080-231f-cadf-a903-58e609a82751@secure.kjonigsen.net> X-Mailer: iPhone Mail (20C65) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252376 Archived-At: Yuan: did you forget applying this last patch? :) =E2=80=94 Jostein Kj=C3=B8nigsen https://jostein.kj=C3=B8nigsen.net > On 2 Jan 2023, at 10:59, Jostein Kj=C3=B8nigsen wrote: >=20 > =EF=BB=BF >> On 02.01.2023 01:12, Yuan Fu wrote: >> Fantastic! I applied the patch, thanks! >>=20 >> Yuan >=20 > Great! Thanks! >=20 > Please note: The previous patch removed a very wide (generic_name (identif= ier)) selector, which incorrectly caused generic functions to be highlighted= as a types. >=20 > This has lead to having to add in more specific (xxx (generic_name (identi= fier)) selectors around the codebase to compensate, and the previous patch e= vidently didn't have "all" the ones we need. >=20 > Attached is a very small patch which should make support for highlighting g= eneric types more complete. I won't promise it has 100% coverage, but with t= his in place, I can't see any obvious places in code where I'm missing out. >=20 > With this in place, the only thing I'd like to improve now (if any) is ind= entation for object-creation/initialization expressions. I've made a few att= empts and can't get those to behave properly. >=20 > Is this anything you could take a look at, Theo? :) >=20 > -- > Jostein >