From: Dmitry Gutov <dgutov@yandex.ru>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Glenn Morris <rgm@gnu.org>, 13692@debbugs.gnu.org
Subject: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks
Date: Sat, 23 Jan 2021 03:43:19 +0200 [thread overview]
Message-ID: <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> (raw)
In-Reply-To: <87o8hijql0.fsf@gnus.org>
On 21.01.2021 16:46, Lars Ingebrigtsen wrote:
> Dmitry Gutov <dgutov@yandex.ru> writes:
>
>> On 20.01.2021 05:58, Lars Ingebrigtsen wrote:
>>> So the suggestion is to remove the `[mouse-2]' binding in
>>> `vc-dir-mode'.
>>
>> I'm not sure, actually. Perhaps the complaint is about the mouse-1
>> effect on status buttons.
>>
>> But the rest of my email is on the assumption that we're talking about
>> the mouse-2 binding.
>
> Depending on your settings, it's the same binding. I think the default
> is that mouse-1 and mouse-2 will work the same here (because of the
>
> (define-key map [follow-link] 'mouse-face)
>
> thing)?
We're talking about slightly different things.
When I hear "mouse-2 binding", I think the global bidning in
vc-dir-mode-map, which affects how mouse-2 works also when clicking
outside of any buttons (on whitespace beside the buttons). And I think
that behavior is relatively weird and could be removed.
But we also have the behavior of mouse-1 and mouse-2 clicks on the
"status" button. Which seem fairly sensible to me, but might be the
cause of Glenn's annoyance in this report because it's relatively easy
to click mouse-1 anywhere in the buffer by mistake.
>> I don't have a strong opinion about this feature, but it seems like it
>> was designed almost with the main goal of being non-discoverable. As
>> such, I don't think it has many users.
>>
>> It only works when you click on an empty space; if you click on a file
>> or directory name (which are highlighted as buttons and thus invite
>> you to click on them), using mouse-1 or mouse-2, you get to visit the
>> file instead. Only the "status" buttons work for that.
>
> It works on the status column, which normally has text like "edited "
> in it (if you've edited something) -- the button extends to the end of
> the column...
Right. But if that is what is at issue here, I think the question
becomes whether to remove the "buttons" from that column (and keep the
mouse-2 binding globally) or whether to remove the mouse-2 binding, but
set up the buttons to continue working. Or make mouse-1 stop working on
the buttons but keep mouse-2 working everywhere (except the file names,
I guess?).
next prev parent reply other threads:[~2021-01-23 1:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 4:56 bug#13692: mouse clicks in vc-dir buffers accidentally changing marks Glenn Morris
2021-01-20 3:58 ` Lars Ingebrigtsen
2021-01-21 3:08 ` Dmitry Gutov
2021-01-21 14:46 ` Lars Ingebrigtsen
2021-01-23 1:43 ` Dmitry Gutov [this message]
2021-01-23 19:02 ` Lars Ingebrigtsen
2021-01-24 2:23 ` Dmitry Gutov
2021-01-25 23:59 ` Lars Ingebrigtsen
2021-01-26 0:36 ` Dmitry Gutov
2021-01-27 1:39 ` Lars Ingebrigtsen
2021-01-30 2:01 ` Dmitry Gutov
2021-01-30 6:21 ` Lars Ingebrigtsen
2021-01-30 14:05 ` Dmitry Gutov
2021-01-31 7:27 ` Lars Ingebrigtsen
2021-08-23 14:12 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru \
--to=dgutov@yandex.ru \
--cc=13692@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.