From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62663: 28.2; vc-hg-state returns incorrect results on directories in some repos Date: Thu, 13 Apr 2023 03:44:30 +0300 Message-ID: <9272e622-ba9b-7c9d-b143-57bb97696ba3@gutov.dev> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34289"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: Spencer Baugh , 62663@debbugs.gnu.org, Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 13 02:45:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pml5a-0008iL-0c for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Apr 2023 02:45:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pml5E-0002es-Dm; Wed, 12 Apr 2023 20:45:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pml5C-0002ec-Cn for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 20:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pml5C-0005Hv-4R for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 20:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pml5B-00074k-LP for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 20:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Apr 2023 00:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62663 X-GNU-PR-Package: emacs Original-Received: via spool by 62663-submit@debbugs.gnu.org id=B62663.168134668627158 (code B ref 62663); Thu, 13 Apr 2023 00:45:01 +0000 Original-Received: (at 62663) by debbugs.gnu.org; 13 Apr 2023 00:44:46 +0000 Original-Received: from localhost ([127.0.0.1]:42113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pml4v-00073y-LK for submit@debbugs.gnu.org; Wed, 12 Apr 2023 20:44:45 -0400 Original-Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:58787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pml4r-00073i-GR for 62663@debbugs.gnu.org; Wed, 12 Apr 2023 20:44:44 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id F04E12B06861; Wed, 12 Apr 2023 20:44:33 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 12 Apr 2023 20:44:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681346673; x=1681350273; bh=PE2O4wdjs5iFL8Md6w1U9IiosC/1nGqv8Ef PwRfTYIM=; b=oLQlMo6I/24M8r5Pjf2Wu4BTea2kH6EMiBAjsfEF4HEtUv4AJj9 j7n0ymFH/IjLTeB2Kyene+sm0TNC95I+LYID0CZIlzpaY7jirWC9JPrljNFD1LQ5 Ycb/Oai+o6SdOiMpKlRJM4B0gIppTeWIB85/AnY85fxOV+Pap7HVTaA84AeCV9GR UtV3LmtMI4ELcZpvZs63F2wbndVBtztydFiMGtDFamqtk0RVJz3uDuGue39cnxMM tTVZ7RazCwCXI7RhOW860jwwbra60/kCOmUEBh0rvcFEklybQGeiMwf/DLh3UNUI c1HMoI2EgG96wwvhj91ez57ZThU0Jj8wsqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1681346673; x= 1681350273; bh=PE2O4wdjs5iFL8Md6w1U9IiosC/1nGqv8EfPwRfTYIM=; b=O TB85VaFVPACaMlQTBCisEUo8S8rR1QtV7WBpLe7gd9hYPrF8EIu5bihC1GRasMhZ AQRoVUPx+0e7+dHQmwl7mLzveSeO8htPW3xWSJHbksnvqkC6H9Qp7DwjKDfZf3vP VjquFSdMD1/iFP/NXas1PS5C/zgwLK9zdsT1SAHGpMOVzdMeIg7Fj21PWVMVkKLu X/n38w25x46dvhEKH/0NAStd4nVMt8gmJjR3P28q6ivr9h9TLNAejB926FFr98K2 wcbR5OJrWmIJTTPKnV9EwgRCw/LYEJ9467ph95WB0j6LvFNMvvdjhLTtKiLVEzgt J9tmk1zsGA+QRDmqVxWJg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekjedgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeghedthedujeeiteeutddtjeekheejteeukeehffdutdejuedvfeevueeviedu udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Apr 2023 20:44:31 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259823 Archived-At: Hi! Thanks for the report. On 04/04/2023 17:05, Spencer Baugh wrote: > The problem is with vc-hg-state-fast, which parses Mercurial data > structures instead of shelling out to hg. This is a great idea but our > parsing seems to be wrong right now in some way. > > 1. Create a new hg repo with: > > hg init > --config format.use_share_safe=false > --config format.use-persistent-nodemap=false > --config format.sparse-revlog=false > --config format.revlog-compression=zlib > > (This is disabling some recent hg features which make vc-hg-state use > the slow path. You can verify that vc-hg-state-fast is going to run by > checking that .hg/requirements is a subset of > vc-hg-supported-requirements) > > 2. touch foo && hg add foo && hg commit -m. > 3. (vc-hg-state-slow ".") > Returns 'up-to-date which is correct (because it shells out to hg) > 4. (vc-hg-state ".") > Returns 'unregistered which is wrong > > To a user, this manifests as various hg commands failing with errors, > often something like > "vc-find-backend-function: Cannot open load file: No such file or directory, vc-nil" > > This also happens on Emacs 29. > > (Note that this is independent of my other bug about lack of support for > certain repo requirements. That bug is about expanding vc-hg-state-fast > support to new repos; this bug is showing that the already existing > support is buggy!) Patches are welcome, of course. I'm going to Cc the original author of that code, but that's just for courtesy.