From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#57367: [PATCH] Speed up em-smart Date: Mon, 5 Sep 2022 12:01:21 -0700 Message-ID: <9257e0e5-232e-7e20-f4d1-385066c4337e@gmail.com> References: <87r10q6byc.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10010"; mail-complaints-to="usenet@ciao.gmane.io" Cc: johnw@gnu.org, 57367@debbugs.gnu.org To: Lars Ingebrigtsen , Morgan Smith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 05 21:02:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVHMd-0002S5-65 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Sep 2022 21:02:31 +0200 Original-Received: from localhost ([::1]:44648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVHMc-0003YC-9b for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Sep 2022 15:02:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVHMA-0003Wn-7Y for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 15:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60179) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVHM9-0008G1-U7 for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 15:02:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVHM9-0001KJ-Pk for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 15:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Sep 2022 19:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 57367-submit@debbugs.gnu.org id=B57367.16624044915063 (code B ref 57367); Mon, 05 Sep 2022 19:02:01 +0000 Original-Received: (at 57367) by debbugs.gnu.org; 5 Sep 2022 19:01:31 +0000 Original-Received: from localhost ([127.0.0.1]:48878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVHLe-0001Jb-Rm for submit@debbugs.gnu.org; Mon, 05 Sep 2022 15:01:31 -0400 Original-Received: from mail-pf1-f176.google.com ([209.85.210.176]:43607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVHLd-0001JM-Ly for 57367@debbugs.gnu.org; Mon, 05 Sep 2022 15:01:29 -0400 Original-Received: by mail-pf1-f176.google.com with SMTP id r12so55060pfl.10 for <57367@debbugs.gnu.org>; Mon, 05 Sep 2022 12:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:from:to:cc:subject :date; bh=qkvA2KRDkqrq8ABXRc2y5oN0/8+/HkevdkxznZMcwKI=; b=D+69Wgk80r+4VpqN5G36GnSCBQvqthZkq3EH0zsZ/QgsVclJMfIEm/2dMdAm73hPdO Z0xnGYdPs+D3sr+VjLgy2g6X31Q2YNSpegTs8PEkdrgA2atqnVyexGb8G36NEUhEsUmE wUAZopBHlrY7AejRW7GRb2s2lghuo47TBqz5iEMYOOlNgjRvTNn92r4UM17/S5vBn9Bh B7bUgUdgczONX+Z3/6J0lFn226K2J4KVSQSb47qQQ6woVCYqh464bOPDWIrOYLybRDp2 lQrVsirjwQq0lrSaukj1xL/8243sUlxRAs3HVW56AmjsxHXq+zXtEC51y8oytExy8zGp EOMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:x-gm-message-state :from:to:cc:subject:date; bh=qkvA2KRDkqrq8ABXRc2y5oN0/8+/HkevdkxznZMcwKI=; b=jeTeO/AQdUNv70/++iOiGKJVQpffNc0O89fwjsDKudwxEqHhQhoqFi3gLlU4HhPH34 C7Q5Idp/FLYMrCzLrT8JCBqTHMULJnktIp94LYAXn6U0WLBHX4QDgaOdFEjpL27VQ2qj pCwd26sY9I40CeDRdmPqoXH0VR+arU8JUIXHT6A4gjPkOTxqp9xKTtSIJPKbINhYlCPw jCMj2PDQ6KE9vCOpH5qETaNy++RYGr2rUdnZksDFs9hs4T/xnTnYHhvvBSvVl/3YDBdS nhc+zq85GCNfbOJ6ZqyvSFhoTjqVzE/Ouz0yMGU/Y7165e2/Se4i4WKg9MK2X+bxeNAu 6/fg== X-Gm-Message-State: ACgBeo0l4cORumj6YYMFECGmLw3SOa5VDlFI9H6ITqu/QTt6tbOEpZ7D sg+1NAnajtVPVh3CpdZqCie4BCZblUc= X-Google-Smtp-Source: AA6agR5U+7gCr7ddEY/6OvrkNvw8Sju+EtwxaqmCTijJ4N9rq2plnaQfajalNtludwe9Nr0oENL9xg== X-Received: by 2002:a63:87c2:0:b0:42b:74d2:e12c with SMTP id i185-20020a6387c2000000b0042b74d2e12cmr40713791pge.25.1662404483742; Mon, 05 Sep 2022 12:01:23 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id c67-20020a621c46000000b005384c3b220asm8149525pfc.50.2022.09.05.12.01.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 12:01:22 -0700 (PDT) In-Reply-To: <87r10q6byc.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241586 Archived-At: On 9/4/2022 2:56 PM, Lars Ingebrigtsen wrote: > Morgan Smith writes: > >> em-smart is very slow. This patch makes it much faster. idk why there >> was all this redisplay stuff in the module as everything seems to work >> great when I remove it all. > > Skimming the patch, I think it makes sense, but I'm not that familiar > with eshell. Perhaps Jim has some comments; added to the CCs. I don't know much about the smart scrolling module in Eshell, but I'll try to familiarize myself with it and then take a look. I'm slightly hesitant about deleting a bunch of code until I know why it was there in the first place; from the comments in em-smart.el, it sounds like these hooks are intentional: ;; @ While output is being generated from a command, the window will ;; be constantly reconfigured (until it would otherwise make no ;; difference) in order to always show you the most output from the ;; command possible. This happens if you change window sizes, ;; scroll, etc. However, maybe there's a better way to do this, or failing that, to at least provide some more options in the module so that users can tune the performance to their liking.