BUG: blank items in the agenda

BUG: blank items in the agenda

[Peter Westlake]

This is quite obscure, and an odd corner case, but here it is.

If you have an item which is:

- a TODO
- scheduled
- ordered
- blocked by a child TODO

then it leaves an empty line in the agenda.

Here's a test case:
,----
| * Press t r on this line in the agenda
|   SCHEDULED: <2009-09-02 Wed>
|   :PROPERTIES:
|   :ORDERED:  t
|   :END:
| *** TODO Report invisible scheduled items
`----

C-a a a will show an agenda with "Scheduled: Press t r ...".
Press "t" on that line to add a TODO.
Press "r" to redisplay, and see the line go blank.

Peter.

Re: BUG: blank items in the agenda

[Manish]

On Wed, Sep 2, 2009 at 10:37 PM, Peter Westlake wrote:
> This is quite obscure, and an odd corner case, but here it is.
>
> If you have an item which is:
>
> - a TODO
> - scheduled
> - ordered
> - blocked by a child TODO
>
> then it leaves an empty line in the agenda.
>
> Here's a test case:
> ,----
> | * Press t r on this line in the agenda
> |   SCHEDULED: <2009-09-02 Wed>
> |   :PROPERTIES:
> |   :ORDERED: t
> |   :END:
> | *** TODO Report invisible scheduled items
> `----
>
> C-a a a will show an agenda with "Scheduled: Press t r ...".
> Press "t" on that line to add a TODO.
> Press "r" to redisplay, and see the line go blank.

Is the value of org-use-fast-todo-selection set to "t"?

And what's the value for org-agenda-dim-blocked-tasks in your setup?

,----[ org-agenda-dim-blocked-tasks ]
| org-agenda-dim-blocked-tasks is a variable defined in `org-agenda.el'.
| Its value is t
|
| Documentation:
| Non-nil means, dim blocked tasks in the agenda display.
| This causes some overhead during agenda construction, but if you
| have turned on `org-enforce-todo-dependencies',
| `org-enforce-todo-checkbox-dependencies', or any other blocking
| mechanism, this will create useful feedback in the agenda.
|
| Instead ot t, this variable can also have the value `invisible'.
| Then blocked tasks will be invisible and only become visible when
| they become unblocked.  An exemption to this behavior is when a task is
| blocked because of unchecked checkboxes below it.  Since checkboxes do
| not show up in the agenda views, making this task invisible you remove any
| trace from agenda views that there is something to do.  Therefore, a task
| that is blocked because of checkboxes will never be made invisible, it
| will only be dimmed.
`----

-- 
Manish

Re: BUG: blank items in the agenda

[Matt Lundin]

"Peter Westlake" <peter.westlake@pobox.com> writes:

> This is quite obscure, and an odd corner case, but here it is.
>
> If you have an item which is:
>
> - a TODO
> - scheduled
> - ordered
> - blocked by a child TODO
>
> then it leaves an empty line in the agenda.
>
> Here's a test case:
> ,----
> | * Press t r on this line in the agenda
> |   SCHEDULED: <2009-09-02 Wed>
> |   :PROPERTIES:
> |   :ORDERED:  t
> |   :END:
> | *** TODO Report invisible scheduled items
> `----
>
> C-a a a will show an agenda with "Scheduled: Press t r ...".
> Press "t" on that line to add a TODO.
> Press "r" to redisplay, and see the line go blank.

I can't duplicate this.

GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.16.5)

Org-mode version 6.30c

Best,
Matt

Re: BUG: blank items in the agenda

[Peter Westlake]

On Wed, 02 Sep 2009 23:12 +0530, "Manish"
<mailtomanish.sharma@gmail.com> wrote:
> On Wed, Sep 2, 2009 at 10:37 PM, Peter Westlake wrote:
> > This is quite obscure, and an odd corner case, but here it is.
> >
> > If you have an item which is:
> >
> > - a TODO
> > - scheduled
> > - ordered
> > - blocked by a child TODO
> >
> > then it leaves an empty line in the agenda.
> >
> > Here's a test case:
> > ,----
> > | * Press t r on this line in the agenda
> > |   SCHEDULED: <2009-09-02 Wed>
> > |   :PROPERTIES:
> > |   :ORDERED: t
> > |   :END:
> > | *** TODO Report invisible scheduled items
> > `----
> >
> > C-a a a will show an agenda with "Scheduled: Press t r ...".
> > Press "t" on that line to add a TODO.
> > Press "r" to redisplay, and see the line go blank.
> 
> Is the value of org-use-fast-todo-selection set to "t"?

No, it's nil. Sorry, I was forgetting that not everyone
has the same keys! This isn't part of the bug, just a
way to make the behaviour more visible.

> And what's the value for org-agenda-dim-blocked-tasks in your setup?

It is "invisible", but I would have expected the item not to
appear in the agenda at all rather than leaving a gap.

Whether scheduled items should be hidden is an interesting
question: if I'm meant to do something at a given time, it
would be helpful to know that something is stopping me. That
applies even more to deadlines.

Peter.

P.S. Matt - I have org-enforce-todo-dependencies "t", which
is another possible difference that might stop this happening
in your case.

Re: Re: BUG: blank items in the agenda

[Nick Dokos]

Matt Lundin <mdl@imapmail.org> wrote:

> "Peter Westlake" <peter.westlake@pobox.com> writes:
> 
> > This is quite obscure, and an odd corner case, but here it is.
> >
> > If you have an item which is:
> >
> > - a TODO
> > - scheduled
> > - ordered
> > - blocked by a child TODO
> >
> > then it leaves an empty line in the agenda.
> >
> > Here's a test case:
> > ,----
> > | * Press t r on this line in the agenda
> > |   SCHEDULED: <2009-09-02 Wed>
> > |   :PROPERTIES:
> > |   :ORDERED:  t
> > |   :END:
> > | *** TODO Report invisible scheduled items
> > `----
> >
> > C-a a a will show an agenda with "Scheduled: Press t r ...".
> > Press "t" on that line to add a TODO.
> > Press "r" to redisplay, and see the line go blank.
> 
> I can't duplicate this.
> 
> GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.16.5)
> 
> Org-mode version 6.30c
> 

Neither can I (same versions, more-or-less).

Peter, can you check the faces? Maybe the item disappears in a
same-color background? I get 'org-agenda-dimmed-todo-face' for your item
and 'org-scheduled-previously' for other items (not sure why), so it's
conceivable that a face setting is responsible.

M-x describe-face while the cursor is on the appropriate text will do it
(if you have hl-line-mode on, you may have to turn it off first).

Nick

Re: Re: BUG: blank items in the agenda

[Peter Westlake]

On Wed, 02 Sep 2009 14:11 -0400, "Nick Dokos" <nicholas.dokos@hp.com>
wrote:
> Matt Lundin <mdl@imapmail.org> wrote:
...

> > I can't duplicate this.
> > 
> > GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.16.5)
> > 
> > Org-mode version 6.30c
> > 
> 
> Neither can I (same versions, more-or-less).
> 
> Peter, can you check the faces? Maybe the item disappears in a
> same-color background? I get 'org-agenda-dimmed-todo-face' for your item
> and 'org-scheduled-previously' for other items (not sure why), so it's
> conceivable that a face setting is responsible.
> 
> M-x describe-face while the cursor is on the appropriate text will do it
> (if you have hl-line-mode on, you may have to turn it off first).

It's org-scheduled-today, foreground DarkGreen. That's the colour it
appears
when it isn't a TODO item. It doesn't change when I add a TODO, or when
the
agenda is redisplayed with the blank line.

One reason for treating this as a bug rather than an oddity of display
is
that the apparently blank line still responds to commands, so it could
be
modified without the user knowing.

Peter.

Re: Re: BUG: blank items in the agenda

[Carsten Dominik]

Hi Peter,

is this only happening if the entry is the *first* entry
in the list in the agenda?

- Carsten

On Sep 2, 2009, at 11:02 PM, Peter Westlake wrote:

>
>
> On Wed, 02 Sep 2009 14:11 -0400, "Nick Dokos" <nicholas.dokos@hp.com>
> wrote:
>> Matt Lundin <mdl@imapmail.org> wrote:
> ...
>
>>> I can't duplicate this.
>>>
>>> GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.16.5)
>>>
>>> Org-mode version 6.30c
>>>
>>
>> Neither can I (same versions, more-or-less).
>>
>> Peter, can you check the faces? Maybe the item disappears in a
>> same-color background? I get 'org-agenda-dimmed-todo-face' for your  
>> item
>> and 'org-scheduled-previously' for other items (not sure why), so  
>> it's
>> conceivable that a face setting is responsible.
>>
>> M-x describe-face while the cursor is on the appropriate text will  
>> do it
>> (if you have hl-line-mode on, you may have to turn it off first).
>
> It's org-scheduled-today, foreground DarkGreen. That's the colour it
> appears
> when it isn't a TODO item. It doesn't change when I add a TODO, or  
> when
> the
> agenda is redisplayed with the blank line.
>
> One reason for treating this as a bug rather than an oddity of display
> is
> that the apparently blank line still responds to commands, so it could
> be
> modified without the user knowing.
>
> Peter.
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Re: BUG: blank items in the agenda

[Peter Westlake]

On Wed, 02 Sep 2009 23:35 +0200, "Carsten Dominik"
<carsten.dominik@gmail.com> wrote:
> Hi Peter,
>
> is this only happening if the entry is the *first* entry in the list
> in the agenda?

No, it's the same if it's second or third too (or more, but I stopped
there).

Thanks for looking at this,

Peter.

> - Carsten
>
> On Sep 2, 2009, at 11:02 PM, Peter Westlake wrote:
>
> >
> >
> > On Wed, 02 Sep 2009 14:11 -0400, "Nick Dokos"
> > <nicholas.dokos@hp.com> wrote:
> >> Matt Lundin <mdl@imapmail.org> wrote:
> > ...
> >
> >>> I can't duplicate this.
> >>>
> >>> GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.16.5)
> >>>
> >>> Org-mode version 6.30c
> >>>
> >>
> >> Neither can I (same versions, more-or-less).
> >>
> >> Peter, can you check the faces? Maybe the item disappears in a  same-
> >> color background? I get 'org-agenda-dimmed-todo-face' for your item
> >> and 'org-scheduled-previously' for other items (not sure why), so
> >> it's conceivable that a face setting is responsible.
> >>
> >> M-x describe-face while the cursor is on the appropriate text will
> >> do it (if you have hl-line-mode on, you may have to turn it off
> >> first).
> >
> > It's org-scheduled-today, foreground DarkGreen. That's the colour it
> > appears  when it isn't a TODO item. It doesn't change when I add a
> > TODO, or when the agenda is redisplayed with the blank line.
> >
> > One reason for treating this as a bug rather than an oddity of
> > display is that the apparently blank line still responds to
> > commands, so it could be modified without the user knowing.
> >
> > Peter.
> >
> >
> > _______________________________________________
> > Emacs-orgmode mailing list Remember: use `Reply All' to send replies
> > to the list. Emacs-orgmode@gnu.org
> > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>

Re: Re: BUG: blank items in the agenda

[Carsten Dominik]

Hi Peter,

I have pushed a fix, please verify.

- Carsten

On Sep 3, 2009, at 12:07 AM, Peter Westlake wrote:

>
>
> On Wed, 02 Sep 2009 23:35 +0200, "Carsten Dominik"
> <carsten.dominik@gmail.com> wrote:
>> Hi Peter,
>>
>> is this only happening if the entry is the *first* entry in the list
>> in the agenda?
>
> No, it's the same if it's second or third too (or more, but I stopped
> there).
>
> Thanks for looking at this,
>
> Peter.
>
>> - Carsten
>>
>> On Sep 2, 2009, at 11:02 PM, Peter Westlake wrote:
>>
>>>
>>>
>>> On Wed, 02 Sep 2009 14:11 -0400, "Nick Dokos"
>>> <nicholas.dokos@hp.com> wrote:
>>>> Matt Lundin <mdl@imapmail.org> wrote:
>>> ...
>>>
>>>>> I can't duplicate this.
>>>>>
>>>>> GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.16.5)
>>>>>
>>>>> Org-mode version 6.30c
>>>>>
>>>>
>>>> Neither can I (same versions, more-or-less).
>>>>
>>>> Peter, can you check the faces? Maybe the item disappears in a   
>>>> same-
>>>> color background? I get 'org-agenda-dimmed-todo-face' for your item
>>>> and 'org-scheduled-previously' for other items (not sure why), so
>>>> it's conceivable that a face setting is responsible.
>>>>
>>>> M-x describe-face while the cursor is on the appropriate text will
>>>> do it (if you have hl-line-mode on, you may have to turn it off
>>>> first).
>>>
>>> It's org-scheduled-today, foreground DarkGreen. That's the colour it
>>> appears  when it isn't a TODO item. It doesn't change when I add a
>>> TODO, or when the agenda is redisplayed with the blank line.
>>>
>>> One reason for treating this as a bug rather than an oddity of
>>> display is that the apparently blank line still responds to
>>> commands, so it could be modified without the user knowing.
>>>
>>> Peter.
>>>
>>>
>>> _______________________________________________
>>> Emacs-orgmode mailing list Remember: use `Reply All' to send replies
>>> to the list. Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>

Re: Re: BUG: blank items in the agenda

[Peter Westlake]

On Thu, 03 Sep 2009 08:50 +0200, "Carsten Dominik"
<carsten.dominik@gmail.com> wrote:
> Hi Peter,
> 
> I have pushed a fix, please verify.
> 
> - Carsten

Yes, the line is no longer there.

Thank you for always fixing bugs so quickly!

Peter.


> On Sep 3, 2009, at 12:07 AM, Peter Westlake wrote:
> 
> >
> >
> > On Wed, 02 Sep 2009 23:35 +0200, "Carsten Dominik"
> > <carsten.dominik@gmail.com> wrote:
> >> Hi Peter,
> >>
> >> is this only happening if the entry is the *first* entry in the list
> >> in the agenda?
> >
> > No, it's the same if it's second or third too (or more, but I stopped
> > there).
> >
> > Thanks for looking at this,
> >
> > Peter.
> >
> >> - Carsten
> >>
> >> On Sep 2, 2009, at 11:02 PM, Peter Westlake wrote:
> >>
> >>>
> >>>
> >>> On Wed, 02 Sep 2009 14:11 -0400, "Nick Dokos"
> >>> <nicholas.dokos@hp.com> wrote:
> >>>> Matt Lundin <mdl@imapmail.org> wrote:
> >>> ...
> >>>
> >>>>> I can't duplicate this.
> >>>>>
> >>>>> GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.16.5)
> >>>>>
> >>>>> Org-mode version 6.30c
> >>>>>
> >>>>
> >>>> Neither can I (same versions, more-or-less).
> >>>>
> >>>> Peter, can you check the faces? Maybe the item disappears in a   
> >>>> same-
> >>>> color background? I get 'org-agenda-dimmed-todo-face' for your item
> >>>> and 'org-scheduled-previously' for other items (not sure why), so
> >>>> it's conceivable that a face setting is responsible.
> >>>>
> >>>> M-x describe-face while the cursor is on the appropriate text will
> >>>> do it (if you have hl-line-mode on, you may have to turn it off
> >>>> first).
> >>>
> >>> It's org-scheduled-today, foreground DarkGreen. That's the colour it
> >>> appears  when it isn't a TODO item. It doesn't change when I add a
> >>> TODO, or when the agenda is redisplayed with the blank line.
> >>>
> >>> One reason for treating this as a bug rather than an oddity of
> >>> display is that the apparently blank line still responds to
> >>> commands, so it could be modified without the user knowing.
> >>>
> >>> Peter.
> >>>
> >>>
> >>> _______________________________________________
> >>> Emacs-orgmode mailing list Remember: use `Reply All' to send replies
> >>> to the list. Emacs-orgmode@gnu.org
> >>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
> >>
>