org-mobile-push breaks currently open org-agenda

org-mobile-push breaks currently open org-agenda

[Aaron Jensen]

[-- Attachment #1: Type: text/plain, Size: 4 bytes --]

html

[-- Attachment #2: Type: text/html, Size: 4353 bytes --]

Re: org-mobile-push breaks currently open org-agenda

[Nicolas Goaziou]

Hello,

Could you use Org uncompiled (C-u M-x org-reload)? your backtrace is
hardly usable.

Also, would you mind sending your message as plain test? It seems to be
HTML-only.

Regards,

-- 
Nicolas Goaziou

Re: org-mobile-push breaks currently open org-agenda

[Aaron Jensen]

[-- Attachment #1: Type: text/plain, Size: 8891 bytes --]

Hi,

> On Mar 10, 2017, at 8:20 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> 
> Hello,
> 
> Could you use Org uncompiled (C-u M-x org-reload)? your backtrace is
> hardly usable.

Thank you for the tip. Here is the trace:

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  set-buffer(nil)
  (save-current-buffer (set-buffer buffer) buffer-undo-list)
  (let ((--cline (org-current-line)) (--cmd this-command) (--buf1 (current-buffer)) (--buf2 buffer) (--undo1 buffer-undo-list) (--undo2 (save-current-buffer (set-buffer buffer) buffer-undo-list)) --c1 --c2) (save-current-buffer (set-buffer buffer) (widen) (goto-char pos) (org-show-context (quote agenda)) (let ((current-prefix-arg arg)) (call-interactively (quote org-todo))) (and (bolp) (forward-char 1)) (setq newhead (org-get-heading)) (if (and (and (boundp (quote org-agenda-headline-snapshot-before-repeat)) org-agenda-headline-snapshot-before-repeat) (not (equal org-agenda-headline-snapshot-before-repeat newhead)) todayp) (progn (setq newhead org-agenda-headline-snapshot-before-repeat just-one t))) (save-excursion (org-back-to-heading) (move-marker org-last-heading-marker (point)))) (beginning-of-line 1) (let ((wconfig (current-window-configuration))) (unwind-protect (progn (org-agenda-change-all-lines newhead hdmarker (quote fixface) just-one)) (set-window-configuration wconfig))) (if (and (boundp (quote org-clock-out-when-done)) org-clock-out-when-done) (progn (string-match (concat "^" (regexp-opt org-done-keywords-for-agenda)) newhead) (org-agenda-unmark-clocking-task))) (org-move-to-column col) (org-agenda-mark-clocking-task) (if org-agenda-allow-remote-undo (progn (setq --c1 (org-verify-change-for-undo --undo1 (save-current-buffer (set-buffer --buf1) buffer-undo-list)) --c2 (org-verify-change-for-undo --undo2 (save-current-buffer (set-buffer --buf2) buffer-undo-list))) (if (or --c1 --c2) (progn (and --c1 (save-current-buffer (set-buffer --buf1) (undo-boundary))) (and --c2 (save-current-buffer (set-buffer --buf2) (undo-boundary))) (setq org-agenda-undo-list (cons (list --cmd --cline --buf1 --c1 --buf2 --c2) org-agenda-undo-list)))))))
  (let* ((col (current-column)) (marker (or (org-get-at-bol (quote org-marker)) (org-agenda-error))) (buffer (marker-buffer marker)) (pos (marker-position marker)) (hdmarker (org-get-at-bol (quote org-hd-marker))) (todayp (org-agenda-today-p (org-get-at-bol (quote day)))) (inhibit-read-only t) org-agenda-headline-snapshot-before-repeat newhead just-one) (let ((--cline (org-current-line)) (--cmd this-command) (--buf1 (current-buffer)) (--buf2 buffer) (--undo1 buffer-undo-list) (--undo2 (save-current-buffer (set-buffer buffer) buffer-undo-list)) --c1 --c2) (save-current-buffer (set-buffer buffer) (widen) (goto-char pos) (org-show-context (quote agenda)) (let ((current-prefix-arg arg)) (call-interactively (quote org-todo))) (and (bolp) (forward-char 1)) (setq newhead (org-get-heading)) (if (and (and (boundp (quote org-agenda-headline-snapshot-before-repeat)) org-agenda-headline-snapshot-before-repeat) (not (equal org-agenda-headline-snapshot-before-repeat newhead)) todayp) (progn (setq newhead org-agenda-headline-snapshot-before-repeat just-one t))) (save-excursion (org-back-to-heading) (move-marker org-last-heading-marker (point)))) (beginning-of-line 1) (let ((wconfig (current-window-configuration))) (unwind-protect (progn (org-agenda-change-all-lines newhead hdmarker (quote fixface) just-one)) (set-window-configuration wconfig))) (if (and (boundp (quote org-clock-out-when-done)) org-clock-out-when-done) (progn (string-match (concat "^" (regexp-opt org-done-keywords-for-agenda)) newhead) (org-agenda-unmark-clocking-task))) (org-move-to-column col) (org-agenda-mark-clocking-task) (if org-agenda-allow-remote-undo (progn (setq --c1 (org-verify-change-for-undo --undo1 (save-current-buffer (set-buffer --buf1) buffer-undo-list)) --c2 (org-verify-change-for-undo --undo2 (save-current-buffer (set-buffer --buf2) buffer-undo-list))) (if (or --c1 --c2) (progn (and --c1 (save-current-buffer ... ...)) (and --c2 (save-current-buffer ... ...)) (setq org-agenda-undo-list (cons ... org-agenda-undo-list))))))))
  (lambda (&optional arg) "Cycle TODO state of line at point, also in Org file.\nThis changes the line at point, all other lines in the agenda referring to\nthe same tree node, and the headline of the tree node in the Org file." (interactive "P") (org-agenda-check-no-diary) (let* ((col (current-column)) (marker (or (org-get-at-bol (quote org-marker)) (org-agenda-error))) (buffer (marker-buffer marker)) (pos (marker-position marker)) (hdmarker (org-get-at-bol (quote org-hd-marker))) (todayp (org-agenda-today-p (org-get-at-bol (quote day)))) (inhibit-read-only t) org-agenda-headline-snapshot-before-repeat newhead just-one) (let ((--cline (org-current-line)) (--cmd this-command) (--buf1 (current-buffer)) (--buf2 buffer) (--undo1 buffer-undo-list) (--undo2 (save-current-buffer (set-buffer buffer) buffer-undo-list)) --c1 --c2) (save-current-buffer (set-buffer buffer) (widen) (goto-char pos) (org-show-context (quote agenda)) (let ((current-prefix-arg arg)) (call-interactively (quote org-todo))) (and (bolp) (forward-char 1)) (setq newhead (org-get-heading)) (if (and (and (boundp ...) org-agenda-headline-snapshot-before-repeat) (not (equal org-agenda-headline-snapshot-before-repeat newhead)) todayp) (progn (setq newhead org-agenda-headline-snapshot-before-repeat just-one t))) (save-excursion (org-back-to-heading) (move-marker org-last-heading-marker (point)))) (beginning-of-line 1) (let ((wconfig (current-window-configuration))) (unwind-protect (progn (org-agenda-change-all-lines newhead hdmarker (quote fixface) just-one)) (set-window-configuration wconfig))) (if (and (boundp (quote org-clock-out-when-done)) org-clock-out-when-done) (progn (string-match (concat "^" (regexp-opt org-done-keywords-for-agenda)) newhead) (org-agenda-unmark-clocking-task))) (org-move-to-column col) (org-agenda-mark-clocking-task) (if org-agenda-allow-remote-undo (progn (setq --c1 (org-verify-change-for-undo --undo1 (save-current-buffer ... buffer-undo-list)) --c2 (org-verify-change-for-undo --undo2 (save-current-buffer ... buffer-undo-list))) (if (or --c1 --c2) (progn (and --c1 ...) (and --c2 ...) (setq org-agenda-undo-list ...))))))))()
  apply((lambda (&optional arg) "Cycle TODO state of line at point, also in Org file.\nThis changes the line at point, all other lines in the agenda referring to\nthe same tree node, and the headline of the tree node in the Org file." (interactive "P") (org-agenda-check-no-diary) (let* ((col (current-column)) (marker (or (org-get-at-bol (quote org-marker)) (org-agenda-error))) (buffer (marker-buffer marker)) (pos (marker-position marker)) (hdmarker (org-get-at-bol (quote org-hd-marker))) (todayp (org-agenda-today-p (org-get-at-bol (quote day)))) (inhibit-read-only t) org-agenda-headline-snapshot-before-repeat newhead just-one) (let ((--cline (org-current-line)) (--cmd this-command) (--buf1 (current-buffer)) (--buf2 buffer) (--undo1 buffer-undo-list) (--undo2 (save-current-buffer (set-buffer buffer) buffer-undo-list)) --c1 --c2) (save-current-buffer (set-buffer buffer) (widen) (goto-char pos) (org-show-context (quote agenda)) (let ((current-prefix-arg arg)) (call-interactively (quote org-todo))) (and (bolp) (forward-char 1)) (setq newhead (org-get-heading)) (if (and (and (boundp ...) org-agenda-headline-snapshot-before-repeat) (not (equal org-agenda-headline-snapshot-before-repeat newhead)) todayp) (progn (setq newhead org-agenda-headline-snapshot-before-repeat just-one t))) (save-excursion (org-back-to-heading) (move-marker org-last-heading-marker (point)))) (beginning-of-line 1) (let ((wconfig (current-window-configuration))) (unwind-protect (progn (org-agenda-change-all-lines newhead hdmarker (quote fixface) just-one)) (set-window-configuration wconfig))) (if (and (boundp (quote org-clock-out-when-done)) org-clock-out-when-done) (progn (string-match (concat "^" (regexp-opt org-done-keywords-for-agenda)) newhead) (org-agenda-unmark-clocking-task))) (org-move-to-column col) (org-agenda-mark-clocking-task) (if org-agenda-allow-remote-undo (progn (setq --c1 (org-verify-change-for-undo --undo1 (save-current-buffer ... buffer-undo-list)) --c2 (org-verify-change-for-undo --undo2 (save-current-buffer ... buffer-undo-list))) (if (or --c1 --c2) (progn (and --c1 ...) (and --c2 ...) (setq org-agenda-undo-list ...)))))))) nil)
  org-agenda-todo()
  funcall-interactively(org-agenda-todo)
  call-interactively(org-agenda-todo nil nil)
  command-execute(org-agenda-todo)


> 
> Also, would you mind sending your message as plain test? It seems to be
> HTML-only.

Supposedly this email is plain text, please let me know if that is not the case. I did not realize that my email client sent HTML only.

Thanks,

Aaron

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 842 bytes --]

Re: org-mobile-push breaks currently open org-agenda

[Nicolas Goaziou]

Aaron Jensen <aaronjensen@gmail.com> writes:

> Thank you for the tip. Here is the trace:
>
> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
>   set-buffer(nil)
>   (save-current-buffer (set-buffer buffer) buffer-undo-list)
>   (let ((--cline (org-current-line)) (--cmd this-command) (--buf1
> (current-buffer)) (--buf2 buffer) (--undo1 buffer-undo-list) (--undo2
> (save-current-buffer (set-buffer buffer) buffer-undo-list)) --c1 --c2)
> (save-current-buffer (set-buffer buffer) (widen) (goto-char pos)
> (org-show-context (quote agenda)) (let ((current-prefix-arg arg))
> (call-interactively (quote org-todo))) (and (bolp) (forward-char 1))
> (setq newhead (org-get-heading)) (if (and (and (boundp (quote
> org-agenda-headline-snapshot-before-repeat))

It seems that the buffer containing the headline you're calling
`org-todo' on doesn't exist anymore. 

ATM, I am not sure how it happens since the headline was extracted from
some document. Could you try evaluating 

  M-: (org-get-at-bol 'org-marker)

on a problematic line and report back the problem?

Better, do you have any ECM for the problem?

Regards,

Re: org-mobile-push breaks currently open org-agenda

[Aaron Jensen]

On Fri, Mar 10, 2017 at 9:28 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> ATM, I am not sure how it happens since the headline was extracted from
> some document. Could you try evaluating
>
>   M-: (org-get-at-bol 'org-marker)
>
> on a problematic line and report back the problem?

I just get this:

#<marker (moves after insertion) in no buffer>

> Better, do you have any ECM for the problem?

Here is an ECM:
https://github.com/aaronjensen/org-mobile-push-breaks-org-agenda-ecm

$ mv ~/.emacs.d ~/.emacs.d.old
$ git clone git@github.com:aaronjensen/org-mobile-push-breaks-org-agenda-ecm.git
~/.emacs.d.old
$ emacs

In emacs:

1. M-x org-agenda a
2. M-x org-mobile-push
3. C-n to TODO and hit t to mark as done

This works fine with the built-in version of emacs, so this appears to
be either a regression or a contrib issue.

Thanks,

Aaron

Re: org-mobile-push breaks currently open org-agenda

[Aaron Jensen]

On Sat, Mar 11, 2017 at 7:53 AM, Aaron Jensen <aaronjensen@gmail.com> wrote:
> $ git clone git@github.com:aaronjensen/org-mobile-push-breaks-org-agenda-ecm.git
> ~/.emacs.d.old

Sorry, this line was wrong, it should clone to ~/.emacs.d:

$ git clone git@github.com:aaronjensen/org-mobile-push-breaks-org-agenda-ecm.git
~/.emacs.d

Re: org-mobile-push breaks currently open org-agenda

[Aaron Jensen]

FYI, I bisected and this is the first bad commit:

bed17f1bb505dd6ecf80b44bf1ef267d45efb206 is the first bad commit
commit bed17f1bb505dd6ecf80b44bf1ef267d45efb206
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date:   Sat Jan 14 16:12:43 2017 +0100

    org-mobile: Fix `org-mobile-push' with stick agendas

    * lisp/org-mobile.el (org-mobile-push): Do not move back to non-sticky
      agendas once called.

    Reported-by: Ian Dunn <dunni@gnu.org>
    <http://permalink.gmane.org/gmane.emacs.orgmode/111334>

:040000 040000 b51c5ae0d7d85ce3db8be72b495ba083f9104abd
3e1fb05b932e22cd0897baa94a8fb3073abe6a49 M  lisp



On Sat, Mar 11, 2017 at 7:54 AM, Aaron Jensen <aaronjensen@gmail.com> wrote:
> On Sat, Mar 11, 2017 at 7:53 AM, Aaron Jensen <aaronjensen@gmail.com> wrote:
>> $ git clone git@github.com:aaronjensen/org-mobile-push-breaks-org-agenda-ecm.git
>> ~/.emacs.d.old
>
> Sorry, this line was wrong, it should clone to ~/.emacs.d:
>
> $ git clone git@github.com:aaronjensen/org-mobile-push-breaks-org-agenda-ecm.git
> ~/.emacs.d