From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env Date: Fri, 17 Jun 2016 17:47:49 +0300 Message-ID: <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1466178396 18077 80.91.229.3 (17 Jun 2016 15:46:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jun 2016 15:46:36 +0000 (UTC) Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net To: Eli Zaretskii , Paul Eggert , Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 17 17:46:24 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDvyR-0008Lp-UN for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 17:46:24 +0200 Original-Received: from localhost ([::1]:58519 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDvyQ-0005Ny-Q6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 11:46:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDv43-0003Oz-Ho for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 10:48:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDv3y-00080f-I3 for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 10:48:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDv3y-00080X-F4 for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 10:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bDv3y-0007Fm-7B for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 10:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jun 2016 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23779 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23779-submit@debbugs.gnu.org id=B23779.146617487927873 (code B ref 23779); Fri, 17 Jun 2016 14:48:02 +0000 Original-Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 14:47:59 +0000 Original-Received: from localhost ([127.0.0.1]:44397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDv3v-0007FV-Ex for submit@debbugs.gnu.org; Fri, 17 Jun 2016 10:47:59 -0400 Original-Received: from mail-wm0-f53.google.com ([74.125.82.53]:38828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDv3u-0007FJ-8a for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 10:47:58 -0400 Original-Received: by mail-wm0-f53.google.com with SMTP id m124so2818202wme.1 for <23779@debbugs.gnu.org>; Fri, 17 Jun 2016 07:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=oHPQHJNprNV/QAGiFdjkl02O3xCL2gSKm0guZtAhCGs=; b=FLHPTkJ3Fndx1apYqFlPJ+jsr9PIL/P+IhG7PCAK8ZzLWNex4KojqyKoRbdOmODpMy 1oiw1C2mYJYRkXWCvlzeAoilYyN32f6W2NBbq9NM3o+1Mpcrkg6b5XpKUYK7iP0oHwUK ZwgwjhK+szeTPHXM6BtoL0Bi4sjO6QK32lWQ2IjaTPf6bNS2qg22c1/XQ3KSmMfxdSXI 4lqfWPpk0RXsDF46CR5lSPx44jEaZ4ZauF46ENoPpfqJgQnYwkbNbPc6kSd/cCZXGT14 kUw9wK3sK6nNPepFyM4d3jWL2YUKZWg9FGuHIJl6/5PGC6EC81QcII2GWlqlf15P664g 4Krg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=oHPQHJNprNV/QAGiFdjkl02O3xCL2gSKm0guZtAhCGs=; b=gliCj1HymilwCcJSTq5leZ3Ctn7gSbSGu2UiihD0Du7CYpowymrCkm7MzQyZ+n7mUS wW/hU3CiET36tD5xRmueb67bGZWb81oUDq+wVP7U3ysavzTjIlgGtK3mqTdb01sqC9Dr vvniK/K2Fojg0rgZOZEx180jwyoKZbwMacn9qdLKb/6hqJAKIwNIR/X+P1VmnZI9x2iv XZ7A5LWJ75V9rOCHawQ4xYkelw6IINGODT1dffePqZxgcuVzcD9tYHANhH95f3KvtBcG JG6F3NF+32Psa/hetyEw0aB3V0alTedOykueWWC+tDfh3/U/WqswiHSctXdIgKeN1yjF FW+Q== X-Gm-Message-State: ALyK8tLxCuNVoU9Yl4cuAhlx/7Q6OYLyAk0sW8FN40wAYFNO3By+DxnmkIV8zjHFMpUSsA== X-Received: by 10.194.216.232 with SMTP id ot8mr2662844wjc.131.1466174872624; Fri, 17 Jun 2016 07:47:52 -0700 (PDT) Original-Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id xs9sm46246270wjc.11.2016.06.17.07.47.50 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Jun 2016 07:47:51 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 In-Reply-To: <83vb17c2z3.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119674 Archived-At: On 06/17/2016 05:19 PM, Eli Zaretskii wrote: >> I wonder if we should make setenv work non-destructively now. > > Why should we do that? We have initial-environment if we need the > original value. Normally, we only want to change the environment for the duration of a command. So, what are the downsides? One the plus side: - setenv-internal will become simpler. - We won't have to cons manually anymore. The code will become a bit nicer, like: diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index f35c84d..5315e0a 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1450,7 +1450,8 @@ vc-git--call (or coding-system-for-read vc-git-log-output-coding-system)) (coding-system-for-write (or coding-system-for-write vc-git-commits-coding-system)) - (process-environment (cons "PAGER=" process-environment))) + (process-environment process-environment)) + (setenv "PAGER") (apply 'process-file vc-git-program nil buffer nil command args))) (defun vc-git--out-ok (command &rest args)