From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#30285: dired-do-chmod vs. top line of dired Date: Tue, 30 Jan 2018 07:15:56 -0800 (PST) Message-ID: <91a8c271-5d11-4ec9-ac95-ed8de1badc4b@default> References: <87mv0wg80c.fsf@jidanni.org> <87efm8snnr.fsf@gmail.com> <83efm8irac.fsf@gnu.org> <87d11sl08v.fsf@gmail.com> <1dd0ec16-7f13-4753-beef-0daeaf84ed8d@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1517325350 7715 195.159.176.226 (30 Jan 2018 15:15:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Jan 2018 15:15:50 +0000 (UTC) Cc: 30285@debbugs.gnu.org, jidanni@jidanni.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 30 16:15:45 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egXcz-00005s-VZ for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jan 2018 16:15:18 +0100 Original-Received: from localhost ([::1]:42853 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egXf0-00013r-Dz for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jan 2018 10:17:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egXel-000137-Db for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 10:17:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egXeg-0005QA-Eg for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 10:17:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41815) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1egXeg-0005PT-A7 for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 10:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1egXef-0003Qb-Re for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2018 10:17:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jan 2018 15:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30285 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30285-submit@debbugs.gnu.org id=B30285.151732536913116 (code B ref 30285); Tue, 30 Jan 2018 15:17:01 +0000 Original-Received: (at 30285) by debbugs.gnu.org; 30 Jan 2018 15:16:09 +0000 Original-Received: from localhost ([127.0.0.1]:49712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egXdo-0003PU-Q0 for submit@debbugs.gnu.org; Tue, 30 Jan 2018 10:16:08 -0500 Original-Received: from userp2120.oracle.com ([156.151.31.85]:59480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egXdm-0003Ol-FL for 30285@debbugs.gnu.org; Tue, 30 Jan 2018 10:16:07 -0500 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w0UF7MeQ083705; Tue, 30 Jan 2018 15:16:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=GVZUXKDpNdPIKJVQdkU9qZuGCNKw3frwakoyhn3pju8=; b=vvEr8u9CyFEiEuX3OBMU6Gn5R5+dH3kEiByeaUrM+b/a6c0yokFzkMxOkjohcN9+wLw1 eO7YITkse2iCo/JVb65sKc8/0V4IklLEjcDLhdL3AmMw7TuP1EiqqsWmj8RXDYhFF1wI p1ow37dJO5nI0n1AHKfJTDdiGWtu/Zs+7F9WLmuWjXrs93CWD8X5/h8qTbVkSQEp0YBj 1qWlwkVt8GDd7apnF+/VKTYSyP3d6N+Cs2ROmlownzZzxyyOa9Ai1AP6REg/nCX3UUX5 TizVSmNJSC2feTf+/VY247hKPfkExw5CAmDc8uKT94+CDNz8c1OF67JNvrwCsL7EA/i6 ig== Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2ftsgm0pfx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jan 2018 15:15:59 +0000 Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w0UFFwmv015724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 30 Jan 2018 15:15:58 GMT Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w0UFFv4f019920; Tue, 30 Jan 2018 15:15:57 GMT In-Reply-To: <1dd0ec16-7f13-4753-beef-0daeaf84ed8d@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4639.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8789 signatures=668655 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=959 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801300191 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142702 Archived-At: Sorry; I realize that my last msg was probably not clear about the possibility of using `dired-move-to-filename' or `dired-get-filename'. Obviously, for `dired-do-*' commands we still need to handle the case where files or dirs are marked. And in that case the command should DTRT even if called from a non-file line, i.e., one of the problematic places we've been discussing - it should not raise an error in that context. For `dired-do-*' commands that already call `dired-get-marked-files' the clear solution, I think, is to just test that return value and raise an error if it is nil. If there is are `dired-do-*' commands that do not call `dired-get-marked-files' then we have a choice how to solve the problem. But it might well be that even then the best solution is to use `dired-get-marked-files'.