all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>,
	"'Le Wang'" <l26wang@gmail.com>
Cc: 12583@debbugs.gnu.org
Subject: bug#12583: latest org-mode changes exposes bug in `comment-forward'in newcomment.el
Date: Sat, 6 Oct 2012 08:53:42 -0700	[thread overview]
Message-ID: <91FE7CF1DA974412A922D439CF16A994@us.oracle.com> (raw)
In-Reply-To: <jwv7gr322bo.fsf-monnier+emacs@gnu.org>

> Before using the comment-* functions, you need to call 
> comment-normalize-vars.

Which comment-* functions?  All of them?

Why don't you add a specific guideline about this to the code comments or to
some doc string?

The doc string of `comment-normalize-vars' says, BTW, that it is the functions
that are autoloaded from newcomment.el that should call `c-n-v'.  But you seem
to be saying that those are not the only ones.

It is also the case that not all functions that are autoloaded from
newcomment.el call `c-n-v'.  So what exactly is the proper criterion?  (Or do
some such functions in newcomment.el perhaps need to be corrected to call
`c-n-v'?)

For my own use, I wonder whether I should be calling `c-n-v' before I make use
of `comment-search-forward'.  That function has no autoload cookie, so it does
not fit your prescription, and I have not been calling `c-n-v' and have not
noticed any problem, but I wonder anyway, since you brought this up.  Just when
is it necessary or useful to call `c-n-v'?

BTW, why are there so many things besided commands that have autoload cookies in
newcomment.el?  I know that you are not particularly in favor of unnecessarily
autoloading variables, so I wonder what the story is here.  Thx.






  reply	other threads:[~2012-10-06 15:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-06 11:07 bug#12583: latest org-mode changes exposes bug in `comment-forward' in newcomment.el Le Wang
2012-10-06 12:49 ` Stefan Monnier
2012-10-06 15:53   ` Drew Adams [this message]
2012-10-06 16:12     ` bug#12583: latest org-mode changes exposes bug in `comment-forward'in newcomment.el Stefan Monnier
2012-10-06 16:37       ` Drew Adams
2012-10-06 16:48         ` Stefan Monnier
2012-10-06 16:57           ` Drew Adams
2012-10-06 17:07     ` Stefan Monnier
2012-10-06 17:12       ` Drew Adams
2012-10-07  0:48         ` Stefan Monnier
2012-10-07  2:51           ` Drew Adams
2012-10-23  2:18           ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91FE7CF1DA974412A922D439CF16A994@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=12583@debbugs.gnu.org \
    --cc=l26wang@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.