From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: master 09b5f00613: ; Fix calls to treesit functions Date: Mon, 19 Dec 2022 17:42:04 +0100 Message-ID: <916FA9FE-440F-4A8F-88FA-F08697EFCB3C@thornhill.no> References: <167138365421.15060.2886694741391315956@vcs2.savannah.gnu.org> <20221218171414.77B8EC0060F@vcs2.savannah.gnu.org> <831qowf54k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32598"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Eli Zaretskii To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 19 17:54:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7JPm-0008HM-P0 for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Dec 2022 17:54:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7JPA-0001K2-RM; Mon, 19 Dec 2022 11:54:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7JP8-0001JE-Dw for emacs-devel@gnu.org; Mon, 19 Dec 2022 11:54:18 -0500 Original-Received: from out-33.mta0.migadu.com ([91.218.175.33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7JP5-0004hA-J0; Mon, 19 Dec 2022 11:54:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1671468852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RUhl0DC5VljpF9+ImLP0mb99Ta1B1nmBCAlDN50n6sU=; b=kEVTkuwPoX/lNLABayKe/WcFrGtvCdt72CwYO/TgnjaSlQB2l6LOy3YwCpu2nnaXnU4OoY qE9WXRRAPV6C8DG2jshoSTqQ9dzizS97S/3I5DCc+fu5L8z/SNZcIdnk531qGlUH2ckYWO dAlYpQB2QHJDgmUMi0SPzv5fIjDD1wOoxacWdbZ3gGvg2pE1Eh/0HZowLUxD7tg9AoCn1n TbRc43tQ2Xq+U91dT7tvX84QW523ga2F+8jxp17qcNha8LdNfSrJqUZ/vqv1QYGp82xXl+ LkmCfVLoe40o+Y7K1HKtcTWVCgByCArcJSpsRXW1M1hg2hBp0sHcafRRkZI4MA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.33; envelope-from=theo@thornhill.no; helo=out-33.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301657 Archived-At: On 19 December 2022 17:13:00 CET, Stefan Monnier wrote: >> The treesit-parser-list is also kind of working just by accident, as >> it isn't its job to ensure availability=2E > >No, it's no accident: if Tree-sitter is not available, then indeed the >list of Tree-sitter parsers is empty=2E So defining that function to ret= urn >nil when Tree-sitter is not available is a perfectly correct definition= =2E > > > Stefan > Yeah, that's not what I meant=2E I meant that its primary purpose isn't to= o be used as a guard against treesit not being available at all=2E I'm fine= with using it like this, but seeing how that wasn't enough by itself we sh= ould either change it or make a similar function that has that purpose=2E F= wiw I like your suggestion to make it available without treesit being avail= able=2E Theo