From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: next emacs version? Date: Fri, 19 Mar 2010 11:46:18 -0700 Message-ID: <911BA1D06CEB4306924D0069BA2D3DFF@us.oracle.com> References: <56D10E2523764AC98D99CEBC55DBAD93@us.oracle.com> <83iq8sigyq.fsf@gnu.org> <83d3z0i3nu.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1269024537 15014 80.91.229.12 (19 Mar 2010 18:48:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 19 Mar 2010 18:48:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: "'Eli Zaretskii'" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 19 19:48:52 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NshFc-0004dl-9k for ged-emacs-devel@m.gmane.org; Fri, 19 Mar 2010 19:48:52 +0100 Original-Received: from localhost ([127.0.0.1]:53002 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NshFb-0007D8-FH for ged-emacs-devel@m.gmane.org; Fri, 19 Mar 2010 14:48:51 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NshFW-0007BC-7n for emacs-devel@gnu.org; Fri, 19 Mar 2010 14:48:46 -0400 Original-Received: from [140.186.70.92] (port=49783 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NshFU-00079V-PX for emacs-devel@gnu.org; Fri, 19 Mar 2010 14:48:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NshFS-0005wd-KF for emacs-devel@gnu.org; Fri, 19 Mar 2010 14:48:44 -0400 Original-Received: from acsinet12.oracle.com ([141.146.126.234]:46251) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NshFS-0005wV-ER; Fri, 19 Mar 2010 14:48:42 -0400 Original-Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by acsinet12.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o2JImD9m001070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 19 Mar 2010 18:48:40 GMT Original-Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o2JHjYaV006852; Fri, 19 Mar 2010 18:48:11 GMT Original-Received: from abhmt016.oracle.com by acsmt355.oracle.com with ESMTP id 101167421269024379; Fri, 19 Mar 2010 11:46:19 -0700 Original-Received: from dradamslap1 (/24.5.179.75) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 19 Mar 2010 11:46:19 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <83d3z0i3nu.fsf@gnu.org> Thread-Index: AcrHj4ND+zyrIfUVTFq97y/01Cq92AAAT9FA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt354.oracle.com [141.146.40.154] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090206.4BA3C6ED.0183:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:122302 Archived-At: > > > If you want to discern v23.x from v24.x, > > > emacs-major-version is the first thing I'd try. > > > > I said I want to discern this code change, which will be > > made by Emacs Dev to 23.2 (probably; it is made now in > > 24.0.50.1). So `emacs-major-version' is not > > the way to check that. > > Please explain more. The above advice was based on a guess, and it > turns out I guessed wrongly. What exactly do you want to test for? > > Was the change in files.el made before the 23.2 release branch was > cut, or after it? If the latter, was it made to both the trunk and > the branch? Dunno. The change is in the latest files.el: http://bazaar.launchpad.net/~vcs-imports/emacs/trunk/annotate/head%3A/lisp/files .el. And it is not in the 23.1 release. Clicking the change-indicator link closest to the regexp definition in question doesn't really provide useful info wrt the change, AFAICT. But clicking `View changes to the file' and searching for "regexp" leads me to this change, which seems to be the one: Chong Yidong2010-02-21 21:12:46Revision ID: cyd@stupidchicken.com-20100221211246-i6nketjrj58mq1qt * files.el (directory-listing-before-filename-regexp): Use stricter matching for iso-style dates, to avoid false matches with date-like filenames (Bug#5597). (The site is so slow and keeps telling me "Please try again. Sorry, there was a problem connecting to the Launchpad server." that it's almost unusable. I had to kill my browser, IE7, a couple of times and start over. And it kept telling me that the page was running a script that was slowing things down so much that it advised me to stop it.) The change I am interested in testing for is a change in the value of `directory-listing-before-filename-regexp', as I said before. Please see my previous email for more details. That is really what I want to check - the goal. Checking for a particular Emacs version would only be an indirect (and approximate) means toward that goal. > > In the past, I've checked `emacs-major-version' and > > `emacs-minor-version' together, or I've checked for the change > > using string-match with `emacs-version'. I was wondering if > > there is a recommendation here. > > Perhaps the various predicates for comparing versions could help you > (version<, version<=, etc.). Good to know; I wasn't aware of them. That's essentially what I was doing using string-match, but they simplify things. (However, I will need to combine them with `fboundp', since they don't exist in older Emacs versions.) The question remains, however, which >, <=, etc. test could do the job robustly, since the dev version is 24.0.50.1 and the first corresponding release will be 23.2?