all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Eli Zaretskii'" <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: RE: next emacs version?
Date: Fri, 19 Mar 2010 11:46:18 -0700	[thread overview]
Message-ID: <911BA1D06CEB4306924D0069BA2D3DFF@us.oracle.com> (raw)
In-Reply-To: <83d3z0i3nu.fsf@gnu.org>

> > > If you want to discern v23.x from v24.x, 
> > > emacs-major-version is the first thing I'd try.
> > 
> > I said I want to discern this code change, which will be 
> > made by Emacs Dev to 23.2 (probably; it is made now in
> > 24.0.50.1). So `emacs-major-version' is not
> > the way to check that.
> 
> Please explain more.  The above advice was based on a guess, and it
> turns out I guessed wrongly.  What exactly do you want to test for?
> 
> Was the change in files.el made before the 23.2 release branch was
> cut, or after it?  If the latter, was it made to both the trunk and
> the branch?

Dunno. The change is in the latest files.el:
http://bazaar.launchpad.net/~vcs-imports/emacs/trunk/annotate/head%3A/lisp/files
.el. And it is not in the 23.1 release.

Clicking the change-indicator link closest to the regexp definition in question
doesn't really provide useful info wrt the change, AFAICT. But clicking `View
changes to the file' and searching for "regexp" leads me to this change, which
seems to be the one:

 Chong Yidong2010-02-21 21:12:46Revision ID: 
 cyd@stupidchicken.com-20100221211246-i6nketjrj58mq1qt

 * files.el (directory-listing-before-filename-regexp): Use
 stricter matching for iso-style dates, to avoid false matches with
 date-like filenames (Bug#5597).

(The site is so slow and keeps telling me "Please try again. Sorry, there was a
problem connecting to the Launchpad server." that it's almost unusable. I had to
kill my browser, IE7, a couple of times and start over. And it kept telling me
that the page was running a script that was slowing things down so much that it
advised me to stop it.)

The change I am interested in testing for is a change in the value of
`directory-listing-before-filename-regexp', as I said before. Please see my
previous email for more details. That is really what I want to check - the goal.
Checking for a particular Emacs version would only be an indirect (and
approximate) means toward that goal.

> > In the past, I've checked `emacs-major-version' and 
> > `emacs-minor-version' together, or I've checked for the change
> > using string-match with `emacs-version'. I was wondering if
> > there is a recommendation here.
> 
> Perhaps the various predicates for comparing versions could help you
> (version<, version<=, etc.).

Good to know; I wasn't aware of them. That's essentially what I was doing using
string-match, but they simplify things. (However, I will need to combine them
with `fboundp', since they don't exist in older Emacs versions.)

The question remains, however, which >, <=, etc. test could do the job robustly,
since the dev version is 24.0.50.1 and the first corresponding release will be
23.2?





  reply	other threads:[~2010-03-19 18:46 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-19 11:23 next emacs version? Drew Adams
2010-03-19 13:22 ` Eli Zaretskii
2010-03-19 17:29   ` Drew Adams
2010-03-19 18:09     ` Eli Zaretskii
2010-03-19 18:46       ` Drew Adams [this message]
2010-03-19 19:02         ` Eli Zaretskii
2010-03-19 20:02           ` Drew Adams
2010-03-19 21:15             ` Eli Zaretskii
2010-03-19 21:23               ` Drew Adams
2010-03-20  2:35                 ` Ken Raeburn
2010-03-20  2:39                   ` Lennart Borgman
2010-03-20  3:42                     ` Óscar Fuentes
2010-03-20 15:51                       ` Lennart Borgman
2010-03-20  5:31                     ` Ken Raeburn
2010-03-23  2:05                     ` Stephen J. Turnbull
2010-03-20  3:38                   ` Drew Adams
2010-03-20  5:31                     ` Ken Raeburn
2010-03-20  6:51                       ` Drew Adams
2010-03-20  5:31                     ` Ken Raeburn
2010-03-20  6:51                       ` Drew Adams
2010-03-23  2:34                     ` Stephen J. Turnbull
2010-03-23  5:01                       ` Miles Bader
2010-03-23  5:39                       ` Drew Adams
2010-03-20  3:51                 ` Jason Rumney
2010-03-20  6:47                   ` Drew Adams
2010-03-20  8:39                   ` Eli Zaretskii
2010-03-20 14:58                     ` Drew Adams
2010-03-20 16:22                       ` Eli Zaretskii
2010-03-20  8:11                 ` Eli Zaretskii
2010-03-19 20:55           ` Stefan Monnier
2010-03-19 21:16             ` Drew Adams
2010-03-20 19:10               ` Stefan Monnier
2010-03-20 20:29                 ` Drew Adams
2010-03-20 21:53                   ` Stefan Monnier
2010-03-20 23:09                     ` Drew Adams
2010-03-20 23:26                       ` Drew Adams
2010-03-22  1:22                       ` Stefan Monnier
2010-03-22  7:22                         ` Drew Adams
2010-03-22 13:52                           ` Stefan Monnier
2010-03-21 21:34     ` Thien-Thi Nguyen
2010-03-21 23:20       ` Drew Adams
2010-03-19 14:52 ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=911BA1D06CEB4306924D0069BA2D3DFF@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.