Re: [PATCH] Re: Other details about completion.

[Ergus <spacibba@aol.com>]

On April 6, 2022 8:34:12 PM GMT+02:00, Juri Linkov <juri@linkov.net> wrote:
>>>Here is the next patch that does this and allows using all arrow keys
>>>only when the completions window is visible:
>>
>> Ok quick check :)
>>
>> With the new option the behavior gives a much better navigation.
>>
>> 1) There is still the issue with C-g or ESC canceling everything
>
>Do you mean addition step is needed where first C-g/ESC will clear
>the suffix, then another C-g/ESC will exit the minibuffer?
>
We need a simple handy way to restore the mini-buffer as it was before the navigation attempt...


Maybe, let's look more at zsh and similes... That's already tested to be intuitive so we don't need to reinvent the wheel and their users already know.


>> 2) In tabular navigation the down arrow always goes to the first column
>> which is wrong; maybe it should use next-line or line-move instead of
>> forward-line?
>
>This is what I tried first, but byte-compiler complained next-line
>is only for interactive use.
>
Then it should probably be line-move but forward-line goes to column zero.

>> 3) It still needs and extra binding to insert and then to another
>> execute... RET just removes the highlight and nothing else... which is
>> un-intuitive because the candidate in principle is already selected.
>
>Then it should always insert the selected candidate.
>
At the end I think that I will stay with completion-auto-select second-tab+ completion-auto-help visible... It is closer to my desired behavior as is. There are just some missing details probably I will try to solve step by step if they become annoying enough.

I don't like that this is getting complex and full of customs and variants that will be hard to support in the future... I would recommend to revert all this changes from master and move them to a branch untill we clarify what we want and what is possible to implement cleanly .

>> I am not a good lisper, but I think that an approach with a minor mode
>> or a transient-map could end up being simpler and more modular without
>> adding more complexity in the existing code... WDYT?
>
>A minor mode that adds a hook to minibuffer-setup-hook
>that activates another mode with additional keymap?
>Looks more complex.  And a transient-map on post-command-hook
>is even more complicated.

But mixing all these bindings behaviors and features all together is something that will break sonner than later. And the hybrid behavior will end up not being good enough for user who want a zsh experience and will bother the ones who don't.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.