Re: [Emacs-diffs] master 8e2b2a2: Minor cleanup in pdumper.c

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

Eli Zaretskii wrote:
> Any reason not to use timespectod?

Thanks, I had forgotten about timespectod. I installed the attached. Yay, one 
less use of ALLOW_IMPLICIT_CONVERSION, a macro I'm not a fan of.

[-- Attachment #2: 0001-Simplify-pdumper-load-via-timespectod.patch --]
[-- Type: text/x-patch, Size: 1016 bytes --]

From be73ed4338b37973eb67e8fd91aaa9e1166c665c Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Mon, 21 Jan 2019 12:48:42 -0800
Subject: [PATCH] Simplify pdumper-load via timespectod

Suggested by Eli Zaretskii in:
https://lists.gnu.org/r/emacs-devel/2019-01/msg00458.html
* src/pdumper.c (pdumper_load): Simplify.
---
 src/pdumper.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/pdumper.c b/src/pdumper.c
index e57aa8f2a0..6be26dc816 100644
--- a/src/pdumper.c
+++ b/src/pdumper.c
@@ -5545,10 +5545,7 @@ pdumper_load (const char *dump_filename)
 
   struct timespec load_timespec =
     timespec_sub (current_timespec (), start_time);
-  ALLOW_IMPLICIT_CONVERSION;
-  double s = load_timespec.tv_sec, ns = load_timespec.tv_nsec;
-  DISALLOW_IMPLICIT_CONVERSION;
-  dump_private.load_time = (s * 1e9 + ns) / 1e9;
+  dump_private.load_time = timespectod (load_timespec);
   dump_private.dump_filename = dump_filename_copy;
   dump_filename_copy = NULL;
 
-- 
2.17.1