all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Glenn Morris <rgm@gnu.org>,
	Robert Cochran <robert+Emacs@cochranmail.com>
Cc: 30431@debbugs.gnu.org
Subject: bug#30431: 27.0.50; "Work even if libpng is install in /usr/local" causes build failure
Date: Mon, 12 Feb 2018 11:42:30 -0800	[thread overview]
Message-ID: <90f70518-cdff-d8b6-de82-6e406947d5d4@cs.ucla.edu> (raw)
In-Reply-To: <ia6072dnsx.fsf@fencepost.gnu.org>

On 02/12/2018 11:13 AM, Glenn Morris wrote:
> AFAICS, the issue is that the CHECK_MODULES method sets PNG_LIBS (and
> PNG_CFLAGS), whereas the old method sets LIBPNG (and PNG_CFLAGS).
>
> So revert the reversion, and then apply eg:
>
> --- a/configure.ac
> +++ b/configure.ac
> @@ -3613,7 +3613,9 @@ elif test "${with_png}" != no; then
>       AC_CHECK_HEADER([png.h], [HAVE_PNG=yes])
>     elif test "${HAVE_X11}" = "yes" || test "${HAVE_W32}" = "yes"; then
>      EMACS_CHECK_MODULES([PNG], [libpng >= 1.0.0])
> -   if test $HAVE_PNG = no; then
> +   if test $HAVE_PNG = yes; then
> +    LIBPNG="$PNG_LIBS"
> +   else
>       # Test old way in case pkg-config doesn't have it (older machines).
>       AC_MSG_CHECKING([for libpng not configured by pkg-config])

Thanks, Glenn. Werner, does that work for you?





  reply	other threads:[~2018-02-12 19:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12  6:18 bug#30431: 27.0.50; "Work even if libpng is install in /usr/local" causes build failure Robert Cochran
2018-02-12 15:39 ` Michael Heerdegen
2018-02-12 16:07   ` Michael Heerdegen
2018-02-12 19:13 ` Glenn Morris
2018-02-12 19:42   ` Paul Eggert [this message]
2018-02-12 21:31     ` Werner LEMBERG
2018-02-13  0:42       ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90f70518-cdff-d8b6-de82-6e406947d5d4@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=30431@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    --cc=robert+Emacs@cochranmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.