all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* crash in delete_window
@ 2009-11-17 23:11 David Reitter
  2009-11-18  8:11 ` martin rudalics
  0 siblings, 1 reply; 3+ messages in thread
From: David Reitter @ 2009-11-17 23:11 UTC (permalink / raw
  To: Emacs discussions

I just had a crash in delete_window and thought I'd do something about it before/rather than filing a bug report....  From the trace below, it seems like Fdelq is called, followed by a process_pending_signals and some redisplay, which probably crashes because the window has been half-deleted.  

Would it be sensible in this case to add some BLOCK_INPUT statements to delete_window, or maybe SET_FRAME_GARBAGED?  (Sorry if this is a naive suggestion.)


----
Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   libSystem.B.dylib             	0x00007fff8435bfe6 __kill + 10
1   org.gnu.AquamacsEmacs         	0x00000001000abbd3 fatal_error_signal + 261 (emacs.c:403)
2   libSystem.B.dylib             	0x00007fff8436deaa _sigtramp + 26
3   ???                           	0x00007fff5fbf9cf0 0 + 140734799781104
4   org.gnu.AquamacsEmacs         	0x0000000100198ae2 ns_get_color + 0 (nsterm.m:1350)
5   org.gnu.AquamacsEmacs         	0x00000001000abc04 fatal_error_signal + 310 (emacs.c:388)
6   libSystem.B.dylib             	0x00007fff8436deaa _sigtramp + 26
7   ???                           	0x00007fff5fbfa1f0 0 + 140734799782384
8   org.gnu.AquamacsEmacs         	0x000000010004f415 expose_frame + 187 (xdisp.c:24443)
9   com.apple.AppKit              	0x00007fff85f8405e -[NSView _drawRect:clip:] + 3566
10  com.apple.AppKit              	0x00007fff85f81834 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 2112
11  com.apple.AppKit              	0x00007fff85f821bf -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 4555
12  com.apple.AppKit              	0x00007fff85f821bf -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 4555
13  com.apple.AppKit              	0x00007fff85f80e17 -[NSThemeFrame _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 254
14  com.apple.AppKit              	0x00007fff85f7d6bf -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 2683
15  com.apple.AppKit              	0x00007fff85ef6f37 -[NSView displayIfNeeded] + 969
16  com.apple.AppKit              	0x00007fff85ef1dde _handleWindowNeedsDisplay + 678
17  com.apple.CoreFoundation      	0x00007fff8453c427 __CFRunLoopDoObservers + 519
18  com.apple.CoreFoundation      	0x00007fff845182d4 __CFRunLoopRun + 468
19  com.apple.CoreFoundation      	0x00007fff84517c2f CFRunLoopRunSpecific + 575
20  com.apple.HIToolbox           	0x00007fff82142a4e RunCurrentEventLoopInMode + 333
21  com.apple.HIToolbox           	0x00007fff821427b1 ReceiveNextEventCommon + 148
22  com.apple.HIToolbox           	0x00007fff8214270c BlockUntilNextEventMatchingListInMode + 59
23  com.apple.AppKit              	0x00007fff85ec71f2 _DPSNextEvent + 708
24  com.apple.AppKit              	0x00007fff85ec6b41 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 155
25  com.apple.AppKit              	0x00007fff85e8c747 -[NSApplication run] + 395
26  org.gnu.AquamacsEmacs         	0x0000000100197500 ns_read_socket + 300 (nsterm.m:3175)
27  org.gnu.AquamacsEmacs         	0x00000001000b601e read_avail_input + 272 (keyboard.c:7128)
28  org.gnu.AquamacsEmacs         	0x00000001000b628f process_pending_signals + 66 (keyboard.c:7447)
29  org.gnu.AquamacsEmacs         	0x000000010013769a Fdelq + 146 (fns.c:1668)
30  org.gnu.AquamacsEmacs         	0x0000000100018d9e delete_frame + 474 (frame.c:1474)
31  org.gnu.AquamacsEmacs         	0x000000010012e377 Feval + 1664 (eval.c:2349)
32  org.gnu.AquamacsEmacs         	0x0000000100131222 internal_lisp_condition_case + 539 (eval.c:1435)
33  org.gnu.AquamacsEmacs         	0x000000010012e3e9 Feval + 1778 (eval.c:2293)
34  org.gnu.AquamacsEmacs         	0x000000010012e990 funcall_lambda + 691 (eval.c:415)
35  org.gnu.AquamacsEmacs         	0x000000010012eae8 apply_lambda + 193 (eval.c:3126)
36  org.gnu.AquamacsEmacs         	0x000000010012df6c Feval + 629 (eval.c:2406)
37  org.gnu.AquamacsEmacs         	0x000000010012e3e9 Feval + 1778 (eval.c:2293)
38  org.gnu.AquamacsEmacs         	0x000000010012e990 funcall_lambda + 691 (eval.c:415)
39  org.gnu.AquamacsEmacs         	0x000000010012eae8 apply_lambda + 193 (eval.c:3126)
40  org.gnu.AquamacsEmacs         	0x000000010012df6c Feval + 629 (eval.c:2406)
41  org.gnu.AquamacsEmacs         	0x0000000100131920 Fif + 110 (eval.c:415)



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: crash in delete_window
  2009-11-17 23:11 crash in delete_window David Reitter
@ 2009-11-18  8:11 ` martin rudalics
  2009-11-24 17:00   ` crash in delete_frame David Reitter
  0 siblings, 1 reply; 3+ messages in thread
From: martin rudalics @ 2009-11-18  8:11 UTC (permalink / raw
  To: David Reitter; +Cc: Emacs discussions

 > I just had a crash in delete_window and thought I'd do something about
 > it before/rather than filing a bug report....  From the trace below,
 > it seems like Fdelq is called, followed by a process_pending_signals
 > and some redisplay, which probably crashes because the window has been
 > half-deleted.

IIUC it was about to delete a single-window frame

 > 30  org.gnu.AquamacsEmacs         	0x0000000100018d9e delete_frame + 474 (frame.c:1474)

so the first question is whether there were other frames left at that
time.

 > Would it be sensible in this case to add some BLOCK_INPUT statements
 > to delete_window, or maybe SET_FRAME_GARBAGED?  (Sorry if this is a
 > naive suggestion.)

The downside of BLOCK_INPUT is that it makes Emacs unresponsive in the
sense that you can't even see a garbled frame when something goes wrong.
But yes - some general advice on why, whether and how BLOCK_INPUT should
be used would be very welcome.

martin




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: crash in delete_frame
  2009-11-18  8:11 ` martin rudalics
@ 2009-11-24 17:00   ` David Reitter
  0 siblings, 0 replies; 3+ messages in thread
From: David Reitter @ 2009-11-24 17:00 UTC (permalink / raw
  To: martin rudalics; +Cc: Emacs discussions

On Nov 18, 2009, at 3:11 AM, martin rudalics wrote:

> > I just had a crash in delete_window and thought I'd do something about
> > it before/rather than filing a bug report....  From the trace below,
> > it seems like Fdelq is called, followed by a process_pending_signals
> > and some redisplay, which probably crashes because the window has been
> > half-deleted.
> 
> IIUC it was about to delete a single-window frame

That's very likely.  The real crash occurred in delete_frame (not delete_window as indicated).

> 
> > 30  org.gnu.AquamacsEmacs         	0x0000000100018d9e delete_frame + 474 (frame.c:1474)
> 
> so the first question is whether there were other frames left at that
> time.

It's entirely possible that there were no other frames left, or that there were only hidden frames left - I usually hide the last frame in lieu of deleting it.  (I just had another one in delete_frame (see below), where this was the last visible frame, but can't trace the origins, presumably also because of compile-time optimizations used in that case).  This one came via kill-buffer-hook.

Any suggestions regarding tests or other debug code to insert?


> > Would it be sensible in this case to add some BLOCK_INPUT statements
> > to delete_window, or maybe SET_FRAME_GARBAGED?  (Sorry if this is a
> > naive suggestion.)
> 
> The downside of BLOCK_INPUT is that it makes Emacs unresponsive in the
> sense that you can't even see a garbled frame when something goes wrong.
> But yes - some general advice on why, whether and how BLOCK_INPUT should
> be used would be very welcome.


Yes, it would be good to see this written up somewhere (perhaps it already is).





Interval Since Last Report:          60693 sec
Crashes Since Last Report:           1
Per-App Interval Since Last Report:  226449 sec
Per-App Crashes Since Last Report:   1
Anonymous UUID:                      91FCF483-3023-4F2A-952D-036B2116B80B

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Crashed Thread:  0  Dispatch queue: com.apple.main-thread

Application Specific Information:
abort() called

Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   libSystem.B.dylib             	0x00007fff8435bfe6 __kill + 10
1   libSystem.B.dylib             	0x00007fff843fce32 abort + 83
2   org.gnu.AquamacsEmacs         	0x0000000100199ae2 ns_get_color + 0
3   org.gnu.AquamacsEmacs         	0x00000001000acbe8 fatal_error_signal + 310 (emacs.c:388)
4   libSystem.B.dylib             	0x00007fff8436deaa _sigtramp + 26
5   ???                           	0x00007fff5fbfcb70 0 + 140734799793008
6   org.gnu.AquamacsEmacs         	0x0000000100019a71 delete_frame + 77 (frame.c:1329)
7   org.gnu.AquamacsEmacs         	0x000000010012f51b Feval + 1664 (eval.c:2349)
8   org.gnu.AquamacsEmacs         	0x00000001001323c6 internal_lisp_condition_case + 539 (eval.c:1435)
9   org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
10  org.gnu.AquamacsEmacs         	0x000000010012fb34 funcall_lambda + 691 (eval.c:415)
11  org.gnu.AquamacsEmacs         	0x000000010012fc8c apply_lambda + 193 (eval.c:3126)
12  org.gnu.AquamacsEmacs         	0x000000010012f110 Feval + 629 (eval.c:2406)
13  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
14  org.gnu.AquamacsEmacs         	0x000000010012fb34 funcall_lambda + 691 (eval.c:415)
15  org.gnu.AquamacsEmacs         	0x000000010012fc8c apply_lambda + 193 (eval.c:3126)
16  org.gnu.AquamacsEmacs         	0x000000010012f110 Feval + 629 (eval.c:2406)
17  org.gnu.AquamacsEmacs         	0x0000000100132ac4 Fif + 110 (eval.c:415)
18  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
19  org.gnu.AquamacsEmacs         	0x000000010012f574 Feval + 1753 (eval.c:2404)
20  org.gnu.AquamacsEmacs         	0x000000010012f7c8 Fprogn + 44 (eval.c:415)
21  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
22  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
23  org.gnu.AquamacsEmacs         	0x000000010013291c FletX + 321 (eval.c:415)
24  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
25  org.gnu.AquamacsEmacs         	0x000000010012fb34 funcall_lambda + 691 (eval.c:415)
26  org.gnu.AquamacsEmacs         	0x000000010012fc8c apply_lambda + 193 (eval.c:3126)
27  org.gnu.AquamacsEmacs         	0x000000010012f110 Feval + 629 (eval.c:2406)
28  org.gnu.AquamacsEmacs         	0x000000010012f824 Fand + 65 (eval.c:336)
29  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
30  org.gnu.AquamacsEmacs         	0x000000010013291c FletX + 321 (eval.c:415)
31  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
32  org.gnu.AquamacsEmacs         	0x00000001001324d9 Fwhile + 146 (eval.c:416)
33  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
34  org.gnu.AquamacsEmacs         	0x000000010013272f Flet + 452 (eval.c:415)
35  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
36  org.gnu.AquamacsEmacs         	0x000000010012f7c8 Fprogn + 44 (eval.c:415)
37  org.gnu.AquamacsEmacs         	0x000000010012e35f internal_catch + 224 (eval.c:1226)
38  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
39  org.gnu.AquamacsEmacs         	0x000000010012f377 Feval + 1244 (eval.c:2331)
40  org.gnu.AquamacsEmacs         	0x000000010012f574 Feval + 1753 (eval.c:2404)
41  org.gnu.AquamacsEmacs         	0x000000010012f574 Feval + 1753 (eval.c:2404)
42  org.gnu.AquamacsEmacs         	0x000000010013291c FletX + 321 (eval.c:415)
43  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
44  org.gnu.AquamacsEmacs         	0x000000010012fb34 funcall_lambda + 691 (eval.c:415)
45  org.gnu.AquamacsEmacs         	0x000000010012ff10 Ffuncall + 470 (eval.c:3072)
46  org.gnu.AquamacsEmacs         	0x0000000100131b54 run_hook_with_args + 195 (eval.c:2674)
47  org.gnu.AquamacsEmacs         	0x0000000100131cd6 Frun_hooks + 54 (eval.c:2534)
48  org.gnu.AquamacsEmacs         	0x00000001000d5932 Fkill_buffer + 271 (buffer.c:1458)
49  org.gnu.AquamacsEmacs         	0x000000010012f52f Feval + 1684 (eval.c:2346)
50  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
51  org.gnu.AquamacsEmacs         	0x000000010013291c FletX + 321 (eval.c:415)
52  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
53  org.gnu.AquamacsEmacs         	0x000000010012fb34 funcall_lambda + 691 (eval.c:415)
54  org.gnu.AquamacsEmacs         	0x000000010012ff10 Ffuncall + 470 (eval.c:3072)
55  org.gnu.AquamacsEmacs         	0x000000010012f60a Feval + 1903 (eval.c:2319)
56  org.gnu.AquamacsEmacs         	0x000000010013272f Flet + 452 (eval.c:415)
57  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
58  org.gnu.AquamacsEmacs         	0x000000010012fb34 funcall_lambda + 691 (eval.c:415)
59  org.gnu.AquamacsEmacs         	0x000000010012fc8c apply_lambda + 193 (eval.c:3126)
60  org.gnu.AquamacsEmacs         	0x000000010012f110 Feval + 629 (eval.c:2406)
61  org.gnu.AquamacsEmacs         	0x000000010013272f Flet + 452 (eval.c:415)
62  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
63  org.gnu.AquamacsEmacs         	0x0000000100132a32 Fcond + 128 (eval.c:415)
64  org.gnu.AquamacsEmacs         	0x000000010012f58d Feval + 1778 (eval.c:2293)
65  org.gnu.AquamacsEmacs         	0x000000010012fb34 funcall_lambda + 691 (eval.c:415)
66  org.gnu.AquamacsEmacs         	0x000000010012ff10 Ffuncall + 470 (eval.c:3072)
67  org.gnu.AquamacsEmacs         	0x0000000100131fba apply1 + 62 (eval.c:2769)
68  org.gnu.AquamacsEmacs         	0x000000010012b444 Fcall_interactively + 1391 (callint.c:396)
69  org.gnu.AquamacsEmacs         	0x0000000100130336 Ffuncall + 1532 (eval.c:3021)
70  org.gnu.AquamacsEmacs         	0x00000001001304ba call3 + 38 (eval.c:2847)
71  org.gnu.AquamacsEmacs         	0x00000001000c1c8c command_loop_1 + 1442 (keyboard.c:1912)
72  org.gnu.AquamacsEmacs         	0x000000010012e268 internal_condition_case + 317 (eval.c:1490)
73  org.gnu.AquamacsEmacs         	0x00000001000b24e6 command_loop_2 + 44 (keyboard.c:1361)
74  org.gnu.AquamacsEmacs         	0x000000010012e35f internal_catch + 224 (eval.c:1226)
75  org.gnu.AquamacsEmacs         	0x00000001000b3705 recursive_edit_1 + 331 (keyboard.c:1340)
76  org.gnu.AquamacsEmacs         	0x00000001000b38c0 Frecursive_edit + 381 (keyboard.c:1017)
77  org.gnu.AquamacsEmacs         	0x00000001000ad9cd main + 3444 (emacs.c:1831)
78  org.gnu.AquamacsEmacs         	0x00000001000023c8 start + 52





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-11-24 17:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-17 23:11 crash in delete_window David Reitter
2009-11-18  8:11 ` martin rudalics
2009-11-24 17:00   ` crash in delete_frame David Reitter

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.