From: "Drew Adams" <drew.adams@oracle.com>
To: 7533@debbugs.gnu.org
Subject: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames'
Date: Thu, 2 Dec 2010 10:35:41 -0800 [thread overview]
Message-ID: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> (raw)
This is another one of those annoyances that come from not testing with
non-nil `pop-up-frames' (just a guess).
emacs -Q
M-x set-variable RET pop-up-frames RET t RET
In Dired, flag several files for deletion, then hit `x'.
Answer `yes' or `no'.
When you hit `x' buffer *Deletions* pops up in its own frame, as it
should. When you type `yes' or `no', the frame should disappear. It
should be deleted. The last part of `dired-mark-pop-up' should be
something like this:
(save-window-excursion
(dired-pop-to-buffer bufname)
(apply function args)
(if (one-window-p) (delete-frame) (delete-window))) ; <===== NEW
If you don't think the `delete-window' is needed, then just use
(when (one-window-p) (delete-frame)).
The important thing, for me, is that the frame that was created just to
show the files that will be deleted (or whatever) goes away. It should
be only a _temporary_ frame because its only raison d'etre is as part of
the deletion etc. _dialog_.
[Martin will explain that a different test from `one-window-p' is more
appropriate. ;-) IIRC, he generally prefers something like this to
(one-window-p win): (eq win (frame-root-window (window-frame win))).]
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2010-11-30 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags
-Ic:/imagesupport/include'
next reply other threads:[~2010-12-02 18:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 18:35 Drew Adams [this message]
2010-12-02 19:05 ` bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' martin rudalics
2010-12-02 19:22 ` Drew Adams
2010-12-03 8:17 ` martin rudalics
2010-12-03 16:22 ` Drew Adams
2010-12-03 18:16 ` martin rudalics
2010-12-03 18:33 ` Drew Adams
2010-12-03 18:41 ` martin rudalics
2010-12-04 22:44 ` Chong Yidong
2010-12-16 18:27 ` Drew Adams
2010-12-17 6:32 ` martin rudalics
2010-12-17 15:32 ` Drew Adams
2010-12-17 16:12 ` martin rudalics
2010-12-17 16:55 ` Drew Adams
2010-12-17 18:09 ` martin rudalics
2010-12-17 18:40 ` Drew Adams
2010-12-21 6:48 ` Chong Yidong
2010-12-03 20:27 ` Stefan Monnier
2012-04-05 20:23 ` Drew Adams
2012-04-06 14:02 ` martin rudalics
2012-04-06 14:44 ` Drew Adams
2012-04-06 14:53 ` martin rudalics
2012-04-06 15:34 ` Drew Adams
2012-04-06 15:47 ` martin rudalics
2012-04-06 16:10 ` Drew Adams
2012-04-06 16:56 ` martin rudalics
2012-04-06 17:08 ` Drew Adams
2012-04-18 14:32 ` Drew Adams
2012-05-25 20:52 ` Drew Adams
2012-05-26 17:55 ` bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' [PATCH] Drew Adams
2012-05-27 13:21 ` martin rudalics
2012-05-27 14:33 ` Drew Adams
2011-01-18 22:14 ` bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Drew Adams
2012-09-05 14:30 ` martin rudalics
2012-09-05 14:33 ` Drew Adams
2012-10-03 9:11 ` martin rudalics
2012-10-03 15:52 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90E09641E9264B37932D2315E5E7E2EA@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=7533@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.