From: "Drew Adams" <drew.adams@oracle.com>
To: <6256@debbugs.gnu.org>
Subject: bug#6256: 24.0.50; read-event in `repeat' command
Date: Mon, 24 May 2010 16:05:27 -0700 [thread overview]
Message-ID: <90A72397ABF34D84A3ACB3B6DE18F74A@us.oracle.com> (raw)
In-Reply-To: <058F2FC300154C1AB894694655B2A968@us.oracle.com>
> > Is changing `read-event' to `read-char-exclusive' the proper
> > fix for this bug? It works for me. If it is not the right fix,
> > then what is?
> >
> > If it is important for some use reason to keep `read-event',
> > and no fix is found that would DTRT to distinguish real user
> > events from events such as `switch-frame', then could we at
> > least use `(funcall repeat-read-function)' instead of
> > `(read-event)', so that code that wants to be sensitive to
> > only char events can bind `repeat-read-function' to
> > `read-char-exclusive' around the call to `repeat'?
> >
> > The default value of such a var could be `read-event', if
> > that's deemed the best default, but we at least need some
> > way to make `repeat' ignore non-char events
> > (if we cannot find a way to make it ignore non-user events).
>
> Actually, I think that using `read-char-exclusive' is the
> right fix. If the
> action were initiated by a mouse event it is unlikely that
> the next event would
> be the same mouse event, so repetition would not occur anyway.
>
> Could you please make this fix: replace the unique occurrence
> of `read-event' by `read-char-exclusive' in `repeat'. Thx.
I take it back. `read-char-exclusive' is not the right fix, because not all
keyboard events are character events. Hitting the key `left', for instance,
does not work.
And in fact, I do not seem to be able to reproduce the problem anymore in Emacs
23. (It does occur in Emacs 22.3, however.) Sorry for the noise.
So I guess this bug could be closed. But I still wonder if the code shouldn't
be tweaked somehow to read an event but ignore non-user (or at least
non-keyboard) events. I don't know how to do that.
Before closing, it would be great if someone knowledgable would reply with some
info about the question. Thx.
next prev parent reply other threads:[~2010-05-24 23:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-24 15:11 bug#6256: 24.0.50; read-event in `repeat' command Drew Adams
2010-05-24 16:28 ` Drew Adams
2010-05-24 23:05 ` Drew Adams [this message]
2010-05-25 0:06 ` Lennart Borgman
2010-05-25 2:41 ` Stefan Monnier
2010-07-03 21:24 ` Drew Adams
2010-07-04 22:45 ` Stefan Monnier
2010-07-07 14:43 ` Drew Adams
2010-07-21 15:54 ` Drew Adams
2010-08-28 15:19 ` Drew Adams
2010-09-11 18:25 ` Stefan Monnier
2010-09-11 22:34 ` Drew Adams
2010-09-12 16:06 ` Drew Adams
2010-09-17 3:34 ` Drew Adams
2010-09-22 14:01 ` bug#6256: [PATCH] " Drew Adams
2010-09-25 14:30 ` Drew Adams
2010-10-18 18:40 ` Stefan Monnier
2010-10-18 21:12 ` Drew Adams
2010-10-19 1:13 ` Stefan Monnier
2010-10-19 6:50 ` Jan Djärv
2010-10-19 14:03 ` Drew Adams
[not found] ` <jwv4ocjuvm1.fsf-monnier+emacs@gnu.org>
[not found] ` <0658C0CCC79D466BA9DE233F5980CAE5@us.oracle.com>
[not found] ` <jwvpqv7rp50.fsf-monnier+emacs@gnu.org>
2010-10-19 19:21 ` Drew Adams
2010-10-19 20:54 ` Stefan Monnier
2010-10-19 22:17 ` Drew Adams
2010-10-20 15:47 ` Stefan Monnier
2010-10-20 20:55 ` Drew Adams
2010-10-21 1:08 ` Stefan Monnier
2010-10-22 18:43 ` Drew Adams
2010-10-22 19:47 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90A72397ABF34D84A3ACB3B6DE18F74A@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=6256@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.