From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul W. Rankin via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode Date: Thu, 8 Aug 2024 19:37:56 +1000 Message-ID: <901E6F99-1756-424F-9470-838D572D8FCF@rnkn.xyz> References: <9417FE9A-2B7C-4A23-80DE-1322E0ECB812@rnkn.xyz> <9EE4E140-25B4-4F0D-BA28-E698BD438CF7@rnkn.xyz> <86h6bvmlwe.fsf@gnu.org> Reply-To: Paul W. Rankin Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_35117FF0-89E6-4C30-A953-E069218AE03F" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3810"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72521@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 08 11:39:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbzbq-0000h5-9c for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Aug 2024 11:39:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbzbS-0007gP-OC; Thu, 08 Aug 2024 05:38:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbzbQ-0007ft-Rt for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2024 05:38:36 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbzbQ-0005tr-IM for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2024 05:38:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:Date:Mime-Version:From:To:Subject; bh=aLAd/2g6Yr0sOyhmFszGFovAmaEGBxqKVjliFQsYExU=; b=sNv/NcTvZBy9dRaLDSmCURqi2beEr2A2L6ZjLzRtDxf1BptR+e5G7Kb9B3JsV2o0dKXyi4V5KJfG55BZXlI+irznQVcxb7VK/9TJWVXaWF4pANV0hWyvbSXCb7qXobHHiEBEcwb/fNWZ/Ceo92QHnyjiUzc38pI7LA8nyWl1WzUwag00y8bZLN9dpJfWjnJ7pYedD91mmT6FMrHDYhcVGiy5rQUKrhP5DB/wLSam3rDdxpBDjGhUSPM7enBZbaQFPqPbOJSVbxv7A1FWw9hIQATcU7MWyN6e/lpN+tkBoFAKrMf1MyEop+WrKgnkKaeM9KY2sj4lRoRlbqf/j4+MZA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sbzbq-0005BR-Qq for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2024 05:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul W. Rankin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Aug 2024 09:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72521-submit@debbugs.gnu.org id=B72521.172310992319892 (code B ref 72521); Thu, 08 Aug 2024 09:39:02 +0000 Original-Received: (at 72521) by debbugs.gnu.org; 8 Aug 2024 09:38:43 +0000 Original-Received: from localhost ([127.0.0.1]:35591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbzbX-0005Am-7N for submit@debbugs.gnu.org; Thu, 08 Aug 2024 05:38:43 -0400 Original-Received: from ms11p00im-qufo17282001.me.com ([17.58.38.57]:50692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbzbU-0005AW-Me for 72521@debbugs.gnu.org; Thu, 08 Aug 2024 05:38:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rnkn.xyz; s=sig1; t=1723109888; bh=aLAd/2g6Yr0sOyhmFszGFovAmaEGBxqKVjliFQsYExU=; h=From:Message-Id:Content-Type:Mime-Version:Subject:Date:To; b=wPiOA96ZepyrlJB2IMDpV5w8V1PF8kLJXwftbqqvoGBOcfJ6/0uZ2RQZ2I3hcDhMb erNgSN3AphE6LO5zzkwZDovuQiFPgFMB+MTj6/OzPRP6O2KapttHF9VII1ZWU8jcmv cA3mqWiXtph1p4g9RCC5jYCJrTSUKRCO2cfLlTyIIBskx1e8Y/Q0BA9sYENH1in1pQ Z29sdZXV3ML/fHnDaCGAYiM7d8e9Zz+3r5Zm3qvf4CB1txWrDJzL95TtXBeIa3OddK /oblMDC0OC7yvPPWkvQOvHYA/Zivs7mYb4xtl4vKHs957BeY5dEkb2R2BOMFsOh3DI nJV75RsGB2kxA== Original-Received: from smtpclient.apple (ms11p00im-dlb-asmtpmailmevip.me.com [17.57.154.19]) by ms11p00im-qufo17282001.me.com (Postfix) with ESMTPSA id 669471E0138; Thu, 8 Aug 2024 09:38:07 +0000 (UTC) In-Reply-To: <86h6bvmlwe.fsf@gnu.org> X-Mailer: Apple Mail (2.3774.600.62) X-Proofpoint-ORIG-GUID: 5zIQcYL85AjaJWC2LakMh2Pz06ns25xT X-Proofpoint-GUID: 5zIQcYL85AjaJWC2LakMh2Pz06ns25xT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-08_07,2024-08-07_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 mlxscore=0 clxscore=1030 malwarescore=0 mlxlogscore=929 suspectscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2408080069 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289931 Archived-At: --Apple-Mail=_35117FF0-89E6-4C30-A953-E069218AE03F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 8 Aug 2024, at 18:58, Eli Zaretskii wrote: >=20 > Thanks, but we cannot possible install this patch, since this behavior > was introduced in Emacs 29. I agree with making this feature > optional, of course (and it will then be ON by default), but your > patch doesn't do that. Hi Eli, Thanks. I=E2=80=99ve replaced the call to variable-pitch-mode with a = hook,=20 help-screen-hook, which defaults to calling variable-pitch-mode. Ideally I think this should just be help-mode-hook though, which of=20 course should not default to calling variable-pitch-mode. Anyway, how=E2=80=99s the patch (now attached) look to you? --Apple-Mail=_35117FF0-89E6-4C30-A953-E069218AE03F Content-Disposition: attachment; filename=0001-lisp-help-macro.el-add-help-screen-hook.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-lisp-help-macro.el-add-help-screen-hook.patch" Content-Transfer-Encoding: quoted-printable =46rom=2024b8ab0bd7b937b46d6faad05821b462019732cc=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20"Paul=20W.=20Rankin"=20=0ADate:=20= Thu,=208=20Aug=202024=2012:16:07=20+1000=0ASubject:=20[PATCH]=20*=20= lisp/help-macro.el:=20add=20help-screen-hook=0A=0Ahelp-screen-hook=20by=20= default=20calls=20variable-pitch-mode=20for=20backwards=0Acompatibility=20= with=20Emacs=2029=0A---=0A=20lisp/help-macro.el=20|=209=20++++++++-=0A=20= 1=20file=20changed,=208=20insertions(+),=201=20deletion(-)=0A=0Adiff=20= --git=20a/lisp/help-macro.el=20b/lisp/help-macro.el=0Aindex=20= 14d2a45f5f2..fce8f784076=20100644=0A---=20a/lisp/help-macro.el=0A+++=20= b/lisp/help-macro.el=0A@@=20-78,6=20+78,13=20@@=20three-step-help=0A=20=20= =20:type=20'boolean=0A=20=20=20:group=20'help)=0A=20=0A+(defcustom=20= help-screen-hook=0A+=20=20'(variable-pitch-mode)=0A+=20=20"Hook=20run=20= by=20`make-help-screen',=20called=20by=20command=20`help-for-help'."=0A+=20= =20:options=20'(variable-pitch-mode)=0A+=20=20:type=20'hook=0A+=20=20= :group=20'help)=0A+=0A=20(defmacro=20make-help-screen=20(fname=20= help-line=20help-text=20helped-map=0A=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= &optional=20buffer-name)=0A=20=20=20"Construct=20help-menu=20function=20= name=20FNAME.=0A@@=20-141,7=20+148,7=20@@=20make-help-screen=0A=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(insert=20= (substitute-command-keys=20help-screen)))=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20(let=20((minor-mode-map-alist=20= new-minor-mode-map-alist))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(help-mode)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(variable-pitch-mode)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(run-hooks=20'help-screen-hook)=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(setq=20= new-minor-mode-map-alist=20minor-mode-map-alist))=0A=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(goto-char=20(point-min))=0A=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(while=20(or=20(memq=20char=20= (append=20help-event-list=0A--=20=0A2.39.3=20(Apple=20Git-146)=0A=0A= --Apple-Mail=_35117FF0-89E6-4C30-A953-E069218AE03F--