From: Dmitry Gutov <dmitry@gutov.dev>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: 67171@debbugs.gnu.org, sbaugh@catern.com, juri@linkov.net
Subject: bug#67171: 30.0.50; (At least) some VC commands fail with project-prefix-or-any-command
Date: Wed, 6 Dec 2023 02:26:12 +0200 [thread overview]
Message-ID: <90011c72-b18f-5868-2430-66eee97f454e@gutov.dev> (raw)
In-Reply-To: <874jgwff35.fsf@melete.silentflame.com>
On 06/12/2023 00:40, Sean Whitton wrote:
> Alright, I've bisected it. After step 3, additionally eval this form:
>
> (define-key project-prefix-map "L" #'vc-print-root-log)
>
> I have this because I want to be able to type just L instead of C-x v L.
> That doesn't work -- possibly not a bug -- but surely adding that
> binding shouldn't affect C-x v L, at least?
All right, the full scenario is unexpected, but otherwise it's a
documented behavior, see the docstring for 'project-any-command'.
We discussed the possibility of the override in the other way (in
bug#63648, which resulted in this command), but not an opt-out for
commands in project-prefix-map, yet.
So... something like this?
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index a81bb63fba4..feef7ba5248 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -1861,9 +1861,10 @@ project-any-command
(when command
;; We could also check the command name against "\\`project-",
;; and/or (get command 'project-command).
- (map-keymap
- (lambda (_evt cmd) (if (eq cmd command) (setq found t)))
- project-prefix-map)
+ (unless (get command 'project-switch-with-default-directory)
+ (map-keymap
+ (lambda (_evt cmd) (if (eq cmd command) (setq found t)))
+ project-prefix-map))
(if found
(let ((project-current-directory-override root))
(call-interactively command))
Combined with
(put 'vc-print-root-log 'project-switch-with-default-directory t)
somewhere in your init script.
The alternative would be tagging all project-related commands. Even if
we also check for the 'project-' prefix in command's name, the
user-defined commands using the project API will be affected (I don't
know for how many it would be a problem, but still).
next prev parent reply other threads:[~2023-12-06 0:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 13:13 bug#67171: 30.0.50; (At least) some VC commands fail with project-prefix-or-any-command Sean Whitton
2023-11-20 2:17 ` Dmitry Gutov
2023-11-23 15:21 ` Sean Whitton
2023-11-23 17:20 ` Juri Linkov
2023-11-23 22:21 ` Dmitry Gutov
2023-11-24 7:46 ` Juri Linkov
2023-11-24 12:27 ` Dmitry Gutov
2023-11-25 18:39 ` Juri Linkov
2023-11-25 19:07 ` Dmitry Gutov
2023-11-25 19:10 ` Juri Linkov
2023-11-25 19:13 ` Dmitry Gutov
2023-11-25 19:13 ` Eli Zaretskii
2023-11-27 7:39 ` Juri Linkov
2023-11-23 22:30 ` Dmitry Gutov
2023-12-05 22:40 ` Sean Whitton
2023-12-06 0:26 ` Dmitry Gutov [this message]
2023-12-06 15:09 ` Sean Whitton
2023-12-07 0:10 ` Dmitry Gutov
2023-12-07 11:23 ` Sean Whitton
2023-12-08 20:37 ` Dmitry Gutov
2023-12-08 21:29 ` Sean Whitton
2023-12-06 17:10 ` Juri Linkov
2023-12-07 0:01 ` Dmitry Gutov
2023-12-07 17:22 ` Juri Linkov
2023-12-07 17:34 ` Dmitry Gutov
2023-12-08 7:40 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90011c72-b18f-5868-2430-66eee97f454e@gutov.dev \
--to=dmitry@gutov.dev \
--cc=67171@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=sbaugh@catern.com \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.