From: Glenn Morris <rgm@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Martin Pohlack <mp26@os.inf.tu-dresden.de>,
rms@gnu.org, emacs-devel@gnu.org
Subject: Re: Fwd: Patch for sgml-mode.el
Date: Sun, 02 Dec 2007 16:59:59 -0500 [thread overview]
Message-ID: <8qodd8g3kw.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <jwvlk8fun0z.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 30 Nov 2007 22:16:20 -0500")
Stefan Monnier wrote:
> The obvious one: no need to manually recompute the string when one of
> its constituents changes. I.e. sgml-xml-mode does not need to know that
> enabling/disabling it can change the mode-name from/to SGML/XML or
> HTML/XHTML. Cleaner code, more obviously correct.
I don't see that it's any cleaner than the following, but I'm not
going to argue about it.
*** sgml-mode.el.~1.129.~ 2007-08-14 00:36:28.000000000 -0700
--- sgml-mode.el 2007-12-02 13:55:42.000000000 -0800
***************
*** 408,414 ****
(eq (char-before) ?<))))
;;;###autoload
! (define-derived-mode sgml-mode text-mode '(sgml-xml-mode "XML" "SGML")
"Major mode for editing SGML documents.
Makes > match <.
Keys <, &, SPC within <>, \", / and ' can be electric depending on
--- 408,414 ----
(eq (char-before) ?<))))
;;;###autoload
! (define-derived-mode sgml-mode text-mode "SGML"
"Major mode for editing SGML documents.
Makes > match <.
Keys <, &, SPC within <>, \", / and ' can be electric depending on
***************
*** 462,468 ****
'sgml-mode-facemenu-add-face-function)
(set (make-local-variable 'sgml-xml-mode) (sgml-xml-guess))
(if sgml-xml-mode
! ()
(set (make-local-variable 'skeleton-transformation-function)
sgml-transformation-function))
;; This will allow existing comments within declarations to be
--- 462,468 ----
'sgml-mode-facemenu-add-face-function)
(set (make-local-variable 'sgml-xml-mode) (sgml-xml-guess))
(if sgml-xml-mode
! (setq mode-name "XML")
(set (make-local-variable 'skeleton-transformation-function)
sgml-transformation-function))
;; This will allow existing comments within declarations to be
next prev parent reply other threads:[~2007-12-02 21:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 4:36 [mp26@os.inf.tu-dresden.de: Patch for sgml-mode.el] Richard Stallman
2007-11-23 15:02 ` Fwd: Patch for sgml-mode.el Stefan Monnier
2007-11-23 15:26 ` Martin Pohlack
2007-11-23 16:26 ` Stefan Monnier
2007-11-23 19:55 ` Glenn Morris
2007-11-30 4:46 ` Stefan Monnier
2007-11-30 20:58 ` Glenn Morris
2007-12-01 3:16 ` Stefan Monnier
2007-12-02 21:59 ` Glenn Morris [this message]
2007-12-01 4:07 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8qodd8g3kw.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=mp26@os.inf.tu-dresden.de \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.