From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Date: Thu, 8 Dec 2022 11:52:53 +0100 Message-ID: <8fdc4d5d-17ac-3a06-d602-637df9fe1be1@secure.kjonigsen.net> References: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> <87zgby9pax.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38383"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: casouri@gmail.com, 59897@debbugs.gnu.org To: Theodor Thornhill , Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 08 11:54:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3EY1-0009Rb-Hv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Dec 2022 11:54:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3EXU-0002pr-Ro; Thu, 08 Dec 2022 05:54:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3EXT-0002pM-1t for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 05:54:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3EXS-0007L8-Pd for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 05:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3EXS-0000He-MM for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 05:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2022 10:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59897 X-GNU-PR-Package: emacs Original-Received: via spool by 59897-submit@debbugs.gnu.org id=B59897.16704967841058 (code B ref 59897); Thu, 08 Dec 2022 10:54:02 +0000 Original-Received: (at 59897) by debbugs.gnu.org; 8 Dec 2022 10:53:04 +0000 Original-Received: from localhost ([127.0.0.1]:56010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3EWV-0000H0-Q3 for submit@debbugs.gnu.org; Thu, 08 Dec 2022 05:53:04 -0500 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3EWT-0000GS-KE for 59897@debbugs.gnu.org; Thu, 08 Dec 2022 05:53:02 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 82C135C00D9; Thu, 8 Dec 2022 05:52:55 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 08 Dec 2022 05:52:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1670496775; x=1670583175; bh=GhV8zelzGu tQLDt4+rkUxnWADYanUYMAq5C2vncuAvw=; b=jHpKxH9P4D8H2ostt6sjdBwC7V fDVF7cwW2zT8QsGNOQDKbMKcNpbVHabFSJ/bmRO62f5nYeVJ4aMt4TTFzqOjR+0f 5UN/dyashu8LZcO3nR6J+j3cs7PfvIjZWuDUH8wXxARwMQ2asU76bbMpR8gnXdIE j3CrMpEYn+qVvLHMzBxp5cVtdHCKP9Q5Tf3kMIpv+UxQY8SZRL5EQlWnIyCVzTlC AC+axhoyJAUmfH6Rn3ts60bEz8t0ZlKCYMVnd2kv2V3pT78HSi68q/TUhkyKLzAp 6E3srxNs4366c2khfQr5awqJg7vqhLx8iB1699NCv0rWAagDbO29vj/2My1A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1670496775; x= 1670583175; bh=GhV8zelzGutQLDt4+rkUxnWADYanUYMAq5C2vncuAvw=; b=C KTKN9UP7Yrn3aslYNaCMl6EURMeDzMxI45A2N4cnCK4FqEQtKJ2MHVD79wmTEAdO 9tcq1k+18k40NLk4xRGXBl53/kK3IKFQ+GF2xRl9eM4OynxjnBKx/UFb/ZRN4VH+ if6qRgyJ2jpaNQMfsbeFwyd16A87G8wihj3twBVs4UCMMX0+xkFM9FhEYaM7m/Yt FMcttRHY0xs1JUt+9ifrD9Y5Z4O18IIEoKFikbSS+3+lzYdmzjLHK6+CjVmbP4D7 2JcgNWISvRTtABCMtLmCrKY46mLmhrt1wQxMLB4qHcJNfaZdeeuBX4MA0PfRqzVt G7sIBXeTSZCXR2EX5eGvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepffduleeiueegveffueekffeiffej udekleevhefgkeekueetlefhheeggefgtdehnecuffhomhgrihhnpegrshhprdhnvghtne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshht vghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Dec 2022 05:52:54 -0500 (EST) Content-Language: en-US In-Reply-To: <87zgby9pax.fsf@thornhill.no> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250268 Archived-At: On 08.12.2022 11:12, Theodor Thornhill wrote: > Jostein Kjønigsen writes: > >> When I use the new csharp-ts-mode, method fontification is usually accurate with only 1 exception which I have >> encountered so far: >> >> When calling methods on objects, and that method accepts a generic type-argument. You typically see this in >> Startup.cs-like files in ASP.Net Core projects: >> >> services.AddSomeExtensionWithoutTypeArguments(); >> services.AddSomeExtensionWithTypeArguments(); >> >> In the above cases we see that fontification of "services" differs. >> >> For the first line, services is fontified using font-lock-variable-name-face (correct), but in the latter case services >> is fontified using font-lock-function-name-face (incorrect). >> >> In both cases I expected services to be fontified using font-lock-variable-name-face. >> > Can you test this patch, Jostein, and if you're happy, please install, > Yuan :-) I beat you by 3 minutes, but I'll be a gentleman and test none the less :D You test mine, and we can see which one we prefer? > BTW, I think the ruleset is getting pretty gnarly in csharp-mode, so > maybe we should consider slimming it down a little (without losing > granularity) for perf reasons down the line! > > Theo It's getting somewhat intricate, agreed. It's IMO not entirely obvious what the different rules are for or what cases they are meant to support. In that regard, I miss our old test-suite from github's csharp-mode. It was a nice safety-net when making changes like this. -- Jostein