From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [Emacs-diffs] trunk r113747: lisp/frameset.el: Convert `frameset' to vector and add new slots. Date: Thu, 8 Aug 2013 10:18:13 -0700 (PDT) Message-ID: <8eca9cdf-dbe5-4bdc-b160-b7333b175123@default> References: <20fb587c-9b7d-48a1-9112-81c3d301ed9a@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1375982321 8118 80.91.229.3 (8 Aug 2013 17:18:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 8 Aug 2013 17:18:41 +0000 (UTC) Cc: Stefan Monnier , Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 08 19:18:42 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V7TrD-0005tz-46 for ged-emacs-devel@m.gmane.org; Thu, 08 Aug 2013 19:18:39 +0200 Original-Received: from localhost ([::1]:51816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7TrC-0005ub-Mn for ged-emacs-devel@m.gmane.org; Thu, 08 Aug 2013 13:18:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7Tr1-0005uO-CS for emacs-devel@gnu.org; Thu, 08 Aug 2013 13:18:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7Tqs-0006vo-R6 for emacs-devel@gnu.org; Thu, 08 Aug 2013 13:18:27 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:31947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7Tqs-0006vi-Ke for emacs-devel@gnu.org; Thu, 08 Aug 2013 13:18:18 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r78HIFOJ032606 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 8 Aug 2013 17:18:15 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r78HIDQf018993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 8 Aug 2013 17:18:13 GMT Original-Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r78HIDkB018990; Thu, 8 Aug 2013 17:18:13 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6668.5000 (x86)] X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 156.151.31.81 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162526 Archived-At: > > frameset-p or frameset-valid-p? >=20 > Also frameset-valid-p, but that function is already autoloaded. "Also"? Why would we ever want someone to use `frameset-p'? What's the point of testing only for a possibly invalid structure that happens to have the right tag? Not a rhetorical question. Do we really want people relying on `frameset-p' (and `cl-typep') to check whether something is of type frameset?