From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [SUSPECTED SPAM] Re: [Emacs-diffs] scratch/widen-less a4ba846: Replace prog-widen with consolidating widen calls Date: Thu, 21 Dec 2017 00:30:21 +0200 Message-ID: <8eb73f61-1ad0-da9c-98d9-36e30d86a7bf@yandex.ru> References: <20171129233237.27462.23351@vcs0.savannah.gnu.org> <83o9nexy48.fsf@gnu.org> <83d13uxug5.fsf@gnu.org> <41e3f343-816f-d2db-6575-6ef43d54957f@yandex.ru> <838tecuqjb.fsf@gnu.org> <83609etizl.fsf@gnu.org> <83wp1ts123.fsf@gnu.org> <1e8587a7-c98b-5183-3cfd-8e1034443f44@yandex.ru> <83shchrwia.fsf@gnu.org> <83lgi9ruo8.fsf@gnu.org> <01c15d4e-566b-3b7f-c4e6-6f199ba5bcc3@yandex.ru> <89c4a839-a124-a1a8-5cf9-583baf2b4dd6@yandex.ru> <0546455b-c757-5673-1888-66990127c7e6@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1513808972 29078 195.159.176.226 (20 Dec 2017 22:29:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 20 Dec 2017 22:29:32 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Thunderbird/58.0 To: Eli Zaretskii , monnier@iro.umontreal.ca, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 20 23:29:28 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRmrf-0007Cy-P9 for ged-emacs-devel@m.gmane.org; Wed, 20 Dec 2017 23:29:27 +0100 Original-Received: from localhost ([::1]:44836 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRmte-0007c4-8I for ged-emacs-devel@m.gmane.org; Wed, 20 Dec 2017 17:31:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRmsg-0007ay-NX for emacs-devel@gnu.org; Wed, 20 Dec 2017 17:30:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRmsc-0007vu-Jx for emacs-devel@gnu.org; Wed, 20 Dec 2017 17:30:30 -0500 Original-Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:35572) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRmsc-0007vF-AN; Wed, 20 Dec 2017 17:30:26 -0500 Original-Received: by mail-wm0-x243.google.com with SMTP id f9so12594970wmh.0; Wed, 20 Dec 2017 14:30:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6Q01OnDchOi1vlJq6J6gT++dWgMCRvhieK5ZSfHLJAQ=; b=NJnR7kePnAM5aH9RDQAYsCHz/3Zwi4NYfaLgQxTOPUygVf6lYR1p/7ZBCCrU3f9Eya vUYmgpS/ff+4/RgAWI12n98H/O0GP7uf5usXnm+khSee4ICQSdCGYqr+A5k9hn+DTpEx 0GAaYrmwpGGxE4+dsetvJ8S3+a7FN/GSWT8sHWYrqeF3vp+s+oft4LY/bVYvOHEH9xce h92fc9YA0zu+mPlP/D7aucDyeuTleG40yc17UIg4ybG+zAhWJa7Nwq8AgVB7bVSSo4fq vmo7CZieZxMLfvjjzxlMiZ4RWLSMsxUeLuDMUi9wdKK4gLJfxM/vGun7GRIPAsI6NCFx cSGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6Q01OnDchOi1vlJq6J6gT++dWgMCRvhieK5ZSfHLJAQ=; b=hcc21ady8dECC1cFAhOGGTHtI2sFosgYfETLM3H1EAOyP+zbSXJzR8HeYC8BtnYFCb SJr6AGPx19kPQsPm+1qD3l3IiRkzmj1P+C60RaSIr83Qmpzc3E+qANvfFccRT/6wAWeO GxQ5GrGE5CiquDVRj0oSuZWR5sX8xQPN2n6EN/PAdE0Jtgh+5bxl2jOZv5zqnSDe0MCU w6TxUh5Lc3GQcVYYFXEcHltj29oeDLrL5iYjSZvKyZFDnhvUF0/cmCp7MkcNkDMm+FUe fzQzRuP6cr+EWzZvlvc3WtikgvA3g5N1nSsTK2tGXJgav9HhlBfIRt2Euk59o75NCK14 hvGg== X-Gm-Message-State: AKGB3mL4WP+uOM8GTAJIFJBKO3PA+kewVESPPFBCj8dgS03Nb9Om7NB8 thYteBZpURjnvNyFZiYY3vQAPNZR X-Google-Smtp-Source: ACJfBotVTJXH6AQwsVhZo79iqlVMUPMxP3QuaP+1GHJJC/MBVcmkUZ8qRKw34WnIRJRZA07c72g1WA== X-Received: by 10.80.181.83 with SMTP id z19mr7483350edd.48.1513809024822; Wed, 20 Dec 2017 14:30:24 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id e29sm16160883edd.44.2017.12.20.14.30.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Dec 2017 14:30:23 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221289 Archived-At: On 12/20/17 9:13 PM, John Wiegley wrote: >>>>>> "DG" == Dmitry Gutov writes: > >>> I've pushed it to widen-less (without scratch/ now). Comments welcome! > > DG> The current state looks good to me. Okay to merge? > > It looks fine to me. Thanks! Merging. > Maybe indent--funcall-widened should be a macro or > defsubst? I'd rather avoid premature optimization (and there's a couple of way we could choose to rewrite indent-for-tab-command that this function is not needed), but I wouldn't argue if someone else did this. FWIW, I'm told define-inline is a better choice these days.