From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Xref completion Date: Sun, 6 Dec 2020 23:20:30 +0200 Message-ID: <8e80fe1e-3aac-85e3-7ace-72b65b3052bd@yandex.ru> References: <873617ets1.fsf@ambrevar.xyz> <878sazzsw5.fsf@mail.linkov.net> <7593e751-cff0-7c1a-7d4c-f927a16c07c9@yandex.ru> <3b255b14-6494-99dc-1e78-9607e0d1fcd9@yandex.ru> <87tut351ea.fsf@mail.linkov.net> <9bbe9827-8e96-e45c-2e0f-23a4fb5aea33@yandex.ru> <87pn3q8ulz.fsf@mail.linkov.net> <7e7e6923-851f-c1c0-4816-d84debe6570b@yandex.ru> <87tut0i39j.fsf@mail.linkov.net> <5440f9e8-6be8-2701-a6aa-3db4a84ad19e@yandex.ru> <87blf7b735.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34834"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: William Xu , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 06 22:23:22 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1km1V4-0008vl-6c for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Dec 2020 22:23:22 +0100 Original-Received: from localhost ([::1]:35830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1km1V3-00052k-85 for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Dec 2020 16:23:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1km1UC-0004Wl-7s for emacs-devel@gnu.org; Sun, 06 Dec 2020 16:22:28 -0500 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:39324) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1km1U9-0005wF-Kk for emacs-devel@gnu.org; Sun, 06 Dec 2020 16:22:27 -0500 Original-Received: by mail-wr1-x431.google.com with SMTP id e7so10840888wrv.6 for ; Sun, 06 Dec 2020 13:20:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=F0q4TWx8W1HietciR+DzpVPfX+frWVHbnhXPV2FWwXQ=; b=UAwugCRtOCuId3tLitYkCZm6svAakxPIm6s1eiCjD1tPYsJvG3k/8I6LiIkPCLQeo7 5mtj1Xr9+ZfOU9dE4cYWdEI638PU1kYcaGE7thfW+9TutL8t8oKGiC+52qD4i9DJPTGc LXKXfXc59zXJHiYqbJP+QJA5UzZZCAn+7SgDNugFeCgjbTNEEdemcboEqR8VxI2wYsRI 5QmX1kEdUcWhLDPgpcgXgEQaJ2x7W4+AGuiLAfVF4tHh3RlzLnEb1v3qyCg1dAPIX0tL NYfd2gWCaGbezqBcP591tLzCa7DM6V6Tv+fluSpD1Bm1v5Kse59pMBKGBLu6zKM/NE4R trdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=F0q4TWx8W1HietciR+DzpVPfX+frWVHbnhXPV2FWwXQ=; b=TreFyNmWSheMz4V9LvcFfaMl7OHLs/1qQ9yjCbof0WPo1xPyAcVK6owCnu4xJdIMgQ SLUml+rT1XkSAUOByDONCu3po4n4w9/YWo5PYs5tGgFluqSfEVclI+oow2rmGBCOfT8n 7Y7PB2xsX9vP0/AH2rtsrl5VAdBS4lgHE8pl1lbXxg1BYsrMqGQB/kVxt956Pdp35kSO UxmX4Z290ckcowj9IhgU4kYHVlnxzfOX7RhEXlj4KKoxkElgUrNoyD02cu2+qwPWhEgx Zfouun3En1uKvJFokwk2wirYIzCjXw46EAL5DpcxvStPns3s53amkTRKJyzGbhSi1lEz ZbAg== X-Gm-Message-State: AOAM533AUwammCnvZMZBybafRPikPJENZ1SUxPAzps6CPY+8Mnwx3x5x 6ZkwWqZimjWc+/VNOHO1E8WiGvOzuyXK3A== X-Google-Smtp-Source: ABdhPJzZOe05u+ePdrs3OwhfO474k9zrQEg/GRGU7DLmJuBHbD+VXsLJeq0hyYQjKst9l63rZ0XEgA== X-Received: by 2002:adf:e490:: with SMTP id i16mr16200525wrm.337.1607289632591; Sun, 06 Dec 2020 13:20:32 -0800 (PST) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id b200sm11839276wmb.10.2020.12.06.13.20.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Dec 2020 13:20:31 -0800 (PST) In-Reply-To: <87blf7b735.fsf@mail.linkov.net> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=raaahh@gmail.com; helo=mail-wr1-x431.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260459 Archived-At: On 06.12.2020 22:46, Juri Linkov wrote: >>>> Also added some highlighting with corresponding xref faces. It now looks >>>> closer to Pierre's original screenshot. >>> Thanks, everything works well. Would be nicer to add all available >>> choices to xref-show-definitions-function (i.e. "at bottom", "minibuffer"). >> >> Of course, a bit later. >> >> BTW, when we do that, should we also rename all involved functions to >> "public" names? > > Indeed, these functions are not "internal". All right. >>>> On the one hand, it feels kinda faster, on the other, it lacks the ability >>>> to "look around" when you really need it. In an ideal world, I guess the UI >>>> would be somewhere in the middle. >>> There are still too many differences between them. The most noteworthy >>> is that xref--show-defs-minibuffer doesn't show completions by default, >>> only after TAB TAB. >> >> That depends on the completion UI in use. >> >> To see them right away, just start with 'M-x fido-mode'. >> >> Or here is the config I'm currently trying out. It needs both ivy and >> ivy-posframe installed, though: > >> ;; See the result on the attached screenshot. > > But matches are not highlighted on your screenshot, whereas on Pierre's screenshot > matches are highlighted. That's only because there is no input on my screenshot (I aimed to show other things). And Pierre's features input "noti". Ivy, of course, highlights the matches.