eval-when-compile help?

[Dmitry Gutov <dgutov@yandex.ru>]

Hi all,

I need to add a piece of code to xref.el which will make it load eieio 
and define a class xref-location when [possibly byte-compiled and] 
loaded in Emacs 27 or older.

But preferably avoid loading EIEIO in Emacs 28+. Both at runtime when 
xref.el is loaded, and when it's compiled too.

The current patch is below. Am I overdoing it with 'eval-and-compile'?

diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index 1feb6ef915..c9334cfa04 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -74,6 +74,13 @@
  (require 'ring)
  (require 'project)

+(when (version< emacs-version "28")
+  (eval-and-compile
+    (require 'eieio)
+
+    (defclass xref-location () ()
+      :documentation "(Obsolete) location represents a position in a 
file or buffer.")))
+
  (defgroup xref nil "Cross-referencing commands."
    :version "25.1"
    :group 'tools)