From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Sun, 23 Apr 2023 02:46:05 +0300 Message-ID: <8e4ec101-adc3-0d1b-af3d-cce92f17b874@gutov.dev> References: <87a5zj2vfo.fsf@gmail.com> <83pm7z7nkc.fsf@gnu.org> <4b63ef62-5e1c-3dcf-ec7b-06b69e79133b@gutov.dev> <83o7nj7mfn.fsf@gnu.org> <556e0fbb-215e-c11d-0e8b-73e97441abbb@gutov.dev> <83pm7y6fdo.fsf@gnu.org> <47140c27-ba63-ca7b-8b9e-cc38a6f9a866@gutov.dev> <838rem636a.fsf@gnu.org> <83leil4u63.fsf@gnu.org> <8a9d0e2b-6ae2-bcdc-efd0-52a44ac862bb@gutov.dev> <83h6t94hru.fsf@gnu.org> <7676c8d2-1324-31e7-38b3-de167ecf683a@gutov.dev> <8e9bd99a-3093-3b69-8429-aa1ae6b7240d@gutov.dev> <834jp82u5c.fsf@gnu.org> <83ildo189j.fsf@gnu.org> <6e91a10e-e8bb-c7db-f6ce-917790e7e391@gutov.dev> <83edoc1602.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------9C9rN0NlB8Hpl5ZHrJYPc2Z2" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8902"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: jporterbugs@gmail.com, philipk@posteo.net, 62720@debbugs.gnu.org, monnier@iro.umontreal.ca, larsi@gnus.org, joaotavora@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 23 01:47:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pqMww-000241-D7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Apr 2023 01:47:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqMwa-0006NO-SJ; Sat, 22 Apr 2023 19:47:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqMwY-0006N8-Ot for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 19:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqMwY-0006HQ-DS for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 19:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pqMwX-0006br-M7 for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 19:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Apr 2023 23:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168220717725356 (code B ref 62720); Sat, 22 Apr 2023 23:47:01 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 22 Apr 2023 23:46:17 +0000 Original-Received: from localhost ([127.0.0.1]:44317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqMvo-0006as-Eg for submit@debbugs.gnu.org; Sat, 22 Apr 2023 19:46:16 -0400 Original-Received: from new2-smtp.messagingengine.com ([66.111.4.224]:39833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqMvn-0006ag-8S for 62720@debbugs.gnu.org; Sat, 22 Apr 2023 19:46:15 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 24C22582041; Sat, 22 Apr 2023 19:46:10 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 22 Apr 2023 19:46:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1682207170; x=1682210770; bh=nn NrJMQfAeRNWF/ddmXQiQNbpZaAiDPzI5xpqCPDEcM=; b=U48QdJm0Q09Shve2Yf 7rXcDa7hSy5gK3ikKPkz1KYPd744+z8lrdBHM7SUKkn+35a8wwz+6CLiZkE4FVSP 0zDkJ7oRyiIbqEo/j5EI/VPlL5URVqGxt2YVysYdNoV8zxw6R5cJIEqAgN6T3suo A3pNf5QNzM9HQnPZ4d2kY3GvanUbITyma9SN0i6Qts/b8RJ7XC+roJciJFupJspn qyA5/64t/1o38l2C4NqHee2mqoCEC4j/QWk6F/KJ3fKKcZTihsIvytQvzWMrbMcx 56+Z5StUtBOtC2EiAfPL0zHjh8fVqFGNL/p4NvC0/+9FKDpGZxas4KhEYat0bIKT aQhw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682207170; x=1682210770; bh=nnNrJMQfAeRNW F/ddmXQiQNbpZaAiDPzI5xpqCPDEcM=; b=jMtB1vQAFKgdfk2w57eqDAldNjH4d AGjdl/fjLME/JyQk6a8xt/m4nHsZlUEt6yKbbVH2NkheSLCUGOJDN0Min+35FfnO 7nPc/z4zgvQmJP+m8ymNpl9ZB5VAyqxHkgEwi1qB+JetgX9Ox8P5LKwn0XtRip2P kPS3bdZqBkSf5evEwj3EzWtf2UZ9aL/lZuPiAZH7MwYXpPOWybcZxluZ7kqRBfRJ 9jUPhmrKrk6S4aekF3vUrOYEWj/34ARE4q355IL1z3MdXpM9Zp8lg3GrG59oMre3 +bbWlNjZ2F8hsIqyQqgqvruIK9CQNUc8WdvqQsD8o48st07d+A7G917DA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtjedgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfevfhfhjgesmhdtreertdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeehteekgfetieeujeeuvddtvdelteffleejteduvdefffejieehheeuteffveei jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 22 Apr 2023 19:46:07 -0400 (EDT) Content-Language: en-US In-Reply-To: <83edoc1602.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260489 Archived-At: This is a multi-part message in MIME format. --------------9C9rN0NlB8Hpl5ZHrJYPc2Z2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/04/2023 15:00, Eli Zaretskii wrote: >>>> I think I explained in the previous email why reusing >>>> package-install-upgrade-built-in doesn't seem like a good idea. >>> >>> And I thought I've explained why I didn't see a need for another >>> option. >> >> I also don't see the point of using an option here. > > We must not change past behavior unconditionally and by default, not > this close to the release. We're still allowed bugfixing, I believe. >>>>> and only then >>>>> update built-in packages. >>>> >>>> I asked what plausible scenario you think might be broken by having >>>> package-update upgrade builtin package by default. >>> >>> That's obvious: this is how package-update behaved until now. >> >> That's not an answer to the question. > > It is for me (and I'm quite surprised that it is not for you). Not sure why you're surprised, you know my approach toward backward compatibility. Never a fan of enshrining problems in amber. But in this case it's also a function that's never been in a released Emacs, so the formal conditions are lacking as well. And it's okay to use the time since the code was added as a rough proxy for stability, but when it's pretty clear (just from the comments in this very thread) that most people never noticed or forgot that it's there. So it's obviously not very well tested. Just from reading it code and testing, I see another bug: it removes the updated package from package-selected-packages because it doesn't pass NOSAVE to package-delete. Meaning, 'M-x package-autoremove' at any time later will delete it. >> Alternatively, we could add an optional argument to package-install >> which would mean "install the latest version anyway". > > There is already such an option, added as part of fixing this bug. Ok, since you insist. See attached. >>>> Just to be clear, we are talking about the 4 lines at the end, right? >>> >>> Yes, and also the (somewhat mysterious) additions of tests for >>> pkg-desc. >> >> pkg-desc is nil for builtin packages in this case (they are not in >> package-alist, so (assq package package-alist) returns nil). > > This should either be commented, or a variable with a telltale name > added to reflect this subtlety. Not a problem. --------------9C9rN0NlB8Hpl5ZHrJYPc2Z2 Content-Type: text/x-patch; charset=UTF-8; name="package-update-fix.diff" Content-Disposition: attachment; filename="package-update-fix.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsIGIvbGlzcC9lbWFjcy1s aXNwL3BhY2thZ2UuZWwKaW5kZXggZmZhNjI3MmRkMWYuLjJjOGVlYzk5OGMxIDEwMDY0NAot LS0gYS9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbAorKysgYi9saXNwL2VtYWNzLWxpc3Av cGFja2FnZS5lbApAQCAtMjI3MCwxNyArMjI3MCwyMyBAQCBwYWNrYWdlLXVwZGF0ZQogICAi VXBkYXRlIHBhY2thZ2UgTkFNRSBpZiBhIG5ld2VyIHZlcnNpb24gZXhpc3RzLiIKICAgKGlu dGVyYWN0aXZlCiAgICAobGlzdCAoY29tcGxldGluZy1yZWFkCi0gICAgICAgICAgIlVwZGF0 ZSBwYWNrYWdlOiAiIChwYWNrYWdlLS11cGRhdGVhYmxlLXBhY2thZ2VzKSBuaWwgdCkpKQor ICAgICAgICAgICJVcGRhdGUgcGFja2FnZTogIiAocGFja2FnZS0tdXBkYXRlYWJsZS1wYWNr YWdlcyB0KSBuaWwgdCkpKQogICAobGV0KiAoKHBhY2thZ2UgKGlmIChzeW1ib2xwIG5hbWUp CiAgICAgICAgICAgICAgICAgICAgICAgbmFtZQogICAgICAgICAgICAgICAgICAgICAoaW50 ZXJuIG5hbWUpKSkKLSAgICAgICAgIChwa2ctZGVzYyAoY2FkciAoYXNzcSBwYWNrYWdlIHBh Y2thZ2UtYWxpc3QpKSkpCi0gICAgKGlmIChwYWNrYWdlLXZjLXAgcGtnLWRlc2MpCisgICAg ICAgICAocGtnLWRlc2MgKGNhZHIgKGFzc3EgcGFja2FnZSBwYWNrYWdlLWFsaXN0KSkpCisg ICAgICAgICAocGFja2FnZS1pbnN0YWxsLXVwZ3JhZGUtYnVpbHQtaW4gKG5vdCBwa2ctZGVz YykpKQorICAgIDs7IGBwa2ctZGVzYycgd2lsbCBiZSBuaWwgd2hlbiB0aGUgcGFja2FnZSBp cyBhbiAiYWN0aXZlIGJ1aWx0LWluIi4KKyAgICAoaWYgKGFuZCBwa2ctZGVzYyAocGFja2Fn ZS12Yy1wIHBrZy1kZXNjKSkKICAgICAgICAgKHBhY2thZ2UtdmMtdXBkYXRlIHBrZy1kZXNj KQotICAgICAgKHBhY2thZ2UtZGVsZXRlIHBrZy1kZXNjICdmb3JjZSkKLSAgICAgIChwYWNr YWdlLWluc3RhbGwgcGFja2FnZSAnZG9udC1zZWxlY3QpKSkpCi0KLShkZWZ1biBwYWNrYWdl LS11cGRhdGVhYmxlLXBhY2thZ2VzICgpCisgICAgICAod2hlbiBwa2ctZGVzYworICAgICAg ICAocGFja2FnZS1kZWxldGUgcGtnLWRlc2MgJ2ZvcmNlICdub3NhdmUpKQorICAgICAgKHBh Y2thZ2UtaW5zdGFsbCBwYWNrYWdlCisgICAgICAgICAgICAgICAgICAgICAgIDs7IEFuIGFj dGl2ZSBidWlsdC1pbiBoYXMgbmV2ZXIgYmVlbiAic2VsZWN0ZWQiCisgICAgICAgICAgICAg ICAgICAgICAgIDs7IGJlZm9yZS4gIE1hcmsgaXQgYXMgaW5zdGFsbGVkIGV4cGxpY2l0bHku CisgICAgICAgICAgICAgICAgICAgICAgIChhbmQgcGtnLWRlc2MgJ2RvbnQtc2VsZWN0KSkp KSkKKworKGRlZnVuIHBhY2thZ2UtLXVwZGF0ZWFibGUtcGFja2FnZXMgKCZvcHRpb25hbCBh bGxvdy1idWlsdGlucykKICAgOzsgSW5pdGlhbGl6ZSB0aGUgcGFja2FnZSBzeXN0ZW0gdG8g Z2V0IHRoZSBsaXN0IG9mIHBhY2thZ2UKICAgOzsgc3ltYm9scyBmb3IgY29tcGxldGlvbi4K ICAgKHBhY2thZ2UtLWFyY2hpdmVzLWluaXRpYWxpemUpCkBAIC0yMjkxLDExICsyMjk3LDIx IEBAIHBhY2thZ2UtLXVwZGF0ZWFibGUtcGFja2FnZXMKICAgICAgIChvciAobGV0ICgoYXZh aWxhYmxlCiAgICAgICAgICAgICAgICAgIChhc3NxIChjYXIgZWx0KSBwYWNrYWdlLWFyY2hp dmUtY29udGVudHMpKSkKICAgICAgICAgICAgIChhbmQgYXZhaWxhYmxlCi0gICAgICAgICAg ICAgICAgICh2ZXJzaW9uLWxpc3QtPAotICAgICAgICAgICAgICAgICAgKHBhY2thZ2UtZGVz Yy12ZXJzaW9uIChjYWRyIGVsdCkpCi0gICAgICAgICAgICAgICAgICAocGFja2FnZS1kZXNj LXZlcnNpb24gKGNhZHIgYXZhaWxhYmxlKSkpKSkKLSAgICAgICAgICAocGFja2FnZS12Yy1w IChjYWRyIChhc3NxIChjYXIgZWx0KSBwYWNrYWdlLWFsaXN0KSkpKSkKLSAgICBwYWNrYWdl LWFsaXN0KSkpCisgICAgICAgICAgICAgICAgIChvciAoYW5kCisgICAgICAgICAgICAgICAg ICAgICAgYWxsb3ctYnVpbHRpbnMKKyAgICAgICAgICAgICAgICAgICAgICAobm90IChwYWNr YWdlLWRlc2MtdmVyc2lvbiAoY2FkciBlbHQpKSkpCisgICAgICAgICAgICAgICAgICAgICAo dmVyc2lvbi1saXN0LTwKKyAgICAgICAgICAgICAgICAgICAgICAocGFja2FnZS1kZXNjLXZl cnNpb24gKGNhZHIgZWx0KSkKKyAgICAgICAgICAgICAgICAgICAgICAocGFja2FnZS1kZXNj LXZlcnNpb24gKGNhZHIgYXZhaWxhYmxlKSkpKSkpCisgICAgICAgICAgKHBhY2thZ2UtdmMt cCAoY2FkciBlbHQpKSkpCisgICAgKGlmIGFsbG93LWJ1aWx0aW5zCisgICAgICAgIChhcHBl bmQgcGFja2FnZS1hbGlzdAorICAgICAgICAgICAgICAgIChtYXBjYW4KKyAgICAgICAgICAg ICAgICAgKGxhbWJkYSAoZWx0KQorICAgICAgICAgICAgICAgICAgICh3aGVuIChub3QgKGFz c3EgKGNhciBlbHQpIHBhY2thZ2UtYWxpc3QpKQorICAgICAgICAgICAgICAgICAgICAgKGxp c3QgKGxpc3QgKGNhciBlbHQpIChwYWNrYWdlLS1mcm9tLWJ1aWx0aW4gZWx0KSkpKSkKKyAg ICAgICAgICAgICAgICAgcGFja2FnZS0tYnVpbHRpbnMpKQorICAgICAgcGFja2FnZS1hbGlz dCkpKSkKIAogOzs7IyMjYXV0b2xvYWQKIChkZWZ1biBwYWNrYWdlLXVwZGF0ZS1hbGwgKCZv cHRpb25hbCBxdWVyeSkK --------------9C9rN0NlB8Hpl5ZHrJYPc2Z2--